Fix mismatch ambiguous size compilation error #1209
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Prefer to use fixed size vnl_vector_fixed and vnl_matrix_fixed to match the required size for the algorithms. The previous implementation used generic sized objects and runtime if/else conditionals. Current implementation uses compile time function overloading to accomplish the same behavior.
The WriteImage function conflicts with the same named itk::WriteImage function. Dis-ambiguate by using the ANTs namespace.
|
Thank you very much, @hjmjohnson . |
|
The SuperBuild is failing on CircleCI (Ubuntu, GCC 7) and my Mac (Clang 12.0.0). Are there some config options that need to change? |
|
Did you include this commit? |
|
I didn't see that. Looks good now. Thanks |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Address compilation issues related to updated version of ITK.
ITK is supporting C++14, and tightening implicit conversion ambiguities. These changes
affect some coding practices that are not recommended.