BUG: Stop segmentation fault when Atropos is multi-threaded #1663
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Sorry @hjmjohnson, I meant to request @ntustison, though you're welcome to comment of course! |
|
Yeah, that should work. Thanks @cookpa . |
|
OK thanks @ntustison - I'm going to try to debug/fix the ManifoldParzenWindows model as well, then will merge |
|
Tested some more, this actually fixes #1627 , the ManifoldParzenWindows error looks to be unrelated to the multi-threading changes |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Partial fix for #1627.
@ntustison, I tried replacing the local interpolator with a vector of interpolators for each bin at the class level. It improves the performance issue. I initialize the interpolators in the
SetInputListSamplefunction, which I think will cause them to stay up to date with respect to the m_HistogramImages, but I'm not sure.