PERF: change computation type for fft: float --> double #866
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Huh, I think I've been bitten by this bug :) |
|
Yeah, I should've updated sooner. |
|
Does this address a known bug?
On Oct 7, 2019, at 9:37 PM, Nick Tustison <notifications@github.com<mailto:notifications@github.com>> wrote:
Yeah, I should've updated sooner.
—
You are receiving this because you are subscribed to this thread.
Reply to this email directly, view it on GitHub<#866?email_source=notifications&email_token=AAEVJM7ZSOPVZ52THXNLVETQNPP2NA5CNFSM4I6HL5M2YY3PNVWWK3TUL52HS4DFVREXG43VMVBW63LNMVXHJKTDN5WW2ZLOORPWSZGOEASK4TA#issuecomment-539274828>, or mute the thread<https://github.com/notifications/unsubscribe-auth/AAEVJM2GX4GBSWH5LSAPFUTQNPP2NANCNFSM4I6HL5MQ>.
|
|
No, not a known bug, but if you follow the link in my original posting, you'll see that @hjmjohnson encountered a float vs. double issue when processing many scans through N4. Since N3 and N4 share the same histogram sharpening function, I thought it should be propagated to our ANTs version of N3. The other commit was due to a recent change in the N4 code where they exposed the |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Mirrors the N4 changes in ITK here