Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update to workspace, include example adapter and package #68

Merged
merged 12 commits into from
May 14, 2024

Conversation

adairrr
Copy link
Contributor

@adairrr adairrr commented May 11, 2024

  • setup workspace
  • rename app directory to app
  • add comment about example binaries
  • Update workspace with a package and adapter example

Copy link
Contributor

@Buckram123 Buckram123 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice, we now have setup for everything now and latest version of abstract!
Closes ABS-408

Cargo.toml Outdated Show resolved Hide resolved
README.md Show resolved Hide resolved
README.md Outdated Show resolved Hide resolved
contracts/adapter/Cargo.toml Outdated Show resolved Hide resolved
contracts/adapter/examples/local_daemon.rs Outdated Show resolved Hide resolved
Copy link
Contributor

@CyberHoward CyberHoward left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the update!

I don't like having a package for apps/adapters. The way we designed the codebase is really oriented towards having each contract be its own self-contained package/crate. There really shouldn't be a need for packages when building modules unless you have some unified logic that you need access to. All the code that is currently in the my package is msgs, state and errs which should all be in the contract crate itself, together with its implementation IMO.

We do this with all our apps and adapters that we've developed internally and it works wonderfully.

Copy link
Contributor

@CyberHoward CyberHoward left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Would like to keep the counter logic in place and move the app/adapter types back into their respective crates. See my previous comment :)

contracts/adapter/src/lib.rs Outdated Show resolved Hide resolved
@CyberHoward CyberHoward merged commit 9f8edf7 into main May 14, 2024
11 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants