Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Get the build green for modern ruby and rack and rubocop-rspec #939

Commits on Jun 24, 2024

  1. Update how we use Rack::Utils to get status codes

    As part of rack/rack#2137 (released in Rack 3) Rack
    changed the values of `Rack::Utils::SYMBOL_TO_STATUS_CODE` so asking for
    `:unprocessable_entity` now returns `nil`. The guidance has always been to use
    `Rack::Util.status_code` (present in the API since Rack 1.1) so let's just do
    that.
    h-lame committed Jun 24, 2024
    Configuration menu
    Copy the full SHA
    a697e7a View commit details
    Browse the repository at this point in the history

Commits on Jul 5, 2024

  1. Handle a missing rack.input in the env

    Ever since rack/rack#2018 `rack.input` has been
    optional so we can't assume it's there and call `read` or `rewind` on it in
    `Apipie::Extractor::Recorder`. Using safe navigation to call these methods
    seems like the simplest approach because we want to look for
    `rack.request.form_hash` instead in both the situation where `rack.input` is
    missing, or it's empty.
    h-lame committed Jul 5, 2024
    Configuration menu
    Copy the full SHA
    a178e6d View commit details
    Browse the repository at this point in the history
  2. Add rubocop-rspec_rails and get rubocop run to green

    In rubocop/rubocop-rspec#1848 rubocop-rspec extracted
    some cops to separate gems, and because we referenced one of them in our
    rubocop_todo.yml the whole rubocop process wouldn't run because it doesn't like
    config for cops it doesn't know about. We introducing the missing gem,
    `rubocop-rspec_rails`, and fix the name in the config to let us run rubocop
    again.
    
    There is one infraction that exists in the source so we fix that to get us to a
    green rubocop run.
    h-lame committed Jul 5, 2024
    Configuration menu
    Copy the full SHA
    9a55365 View commit details
    Browse the repository at this point in the history

Commits on Jul 9, 2024

  1. Only add rubocop-rspec_rails for ruby >-= 2.7

    It's only available for 2.7+ and we still run this build on 2.6.
    h-lame committed Jul 9, 2024
    Configuration menu
    Copy the full SHA
    c7ad525 View commit details
    Browse the repository at this point in the history