fix/hot_restart_not_setting_method_call_handler (#231)

AppLovin · Jul 22, 2024 · 6061137 · 6061137
1 parent 8e003af
commit 6061137
Show file tree

Hide file tree

Showing 2 changed files with 9 additions and 14 deletions.
diff --git a/applovin_max/CHANGELOG.md b/applovin_max/CHANGELOG.md
@@ -1,6 +1,7 @@
 ## Versions
 
 ## x.x.x
+* Fix ad callbacks not firing after hot restart. https://github.com/AppLovin/AppLovin-MAX-Flutter/issues/229
 * Fix `Null check operator used on a null value` warning in `MaxNativeAdView.dispose()`.
 ## 3.10.1
 * Update `AppLovinMAX.initialize()` to return a `Future` on hot restart.

diff --git a/applovin_max/lib/applovin_max.dart b/applovin_max/lib/applovin_max.dart
@@ -40,13 +40,7 @@ class AppLovinMAX {
 
   /// Initializes the SDK.
   ///
-  /// This method must be called only once. Calling it multiple times may
-  /// cause the returned future to never complete.
-  ///
   /// For more information, see the [Initialize the SDK](https://developers.applovin.com/en/flutter/overview/integration).
-  ///
-  /// See [this GitHub issue](https://github.com/AppLovin/AppLovin-MAX-Flutter/issues/210)
-  /// for more details on why calling `initialize` multiple times can lead to issues.
   static Future<MaxConfiguration?> initialize(String sdkKey) async {
     if (_hasInitializeInvoked) {
       // Return a future object even when the actual value is not ready.
@@ -55,14 +49,6 @@ class AppLovinMAX {
 
     _hasInitializeInvoked = true;
 
-    // isInitialized() returns true when Flutter is performing hot restart
-    bool isPlatformSDKInitialized = await isInitialized() ?? false;
-    if (isPlatformSDKInitialized) {
-      Map conf = await channel.invokeMethod('getConfiguration');
-      _initializeCompleter.complete(MaxConfiguration.fromJson(Map<String, dynamic>.from(conf)));
-      return _initializeCompleter.future;
-    }
-
     channel.setMethodCallHandler((MethodCall call) async {
       var method = call.method;
       var arguments = call.arguments;
@@ -152,6 +138,14 @@ class AppLovinMAX {
       }
     });
 
+    // isInitialized() returns true when Flutter is performing hot restart
+    bool isPlatformSDKInitialized = await isInitialized() ?? false;
+    if (isPlatformSDKInitialized) {
+      Map conf = await channel.invokeMethod('getConfiguration');
+      _initializeCompleter.complete(MaxConfiguration.fromJson(Map<String, dynamic>.from(conf)));
+      return _initializeCompleter.future;
+    }
+
     var conf = await channel.invokeMethod('initialize', {
       'plugin_version': version,
       'sdk_key': sdkKey,