Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improve display of Battery and GPS data on HUD #2921

Merged
merged 5 commits into from
Aug 11, 2022

Conversation

sborenstein-ift
Copy link
Contributor

Changes to the HUD add display improvements for the Battery and GPS displays in single and dual line modes, and move all text to be "bottom justified".

@sborenstein-ift sborenstein-ift changed the title Dual batt fix Improve display of Battery and GPS data on HUD Aug 5, 2022
@@ -31,9 +31,9 @@

namespace MissionPlanner.Controls
{
public class HUD2: HUD
public class graphicsObject: HUD
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

can this be undone

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good question. I did not explicitly do this. I wonder if MVS took over here.

@@ -102,6 +102,21 @@ private void FreeBitmap()
bitmap = null;
}
}

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

and this undone

@meee1
Copy link
Contributor

meee1 commented Aug 6, 2022

could you post a before and after screenshot?

@sborenstein-ift
Copy link
Contributor Author

image
image
image

Attached are normal 2-line, min-size 2-line and single line screen caps.

@sborenstein-ift
Copy link
Contributor Author

Here's the "before" image, single line and a quick battery 2-line. Note, in dual batt and dual GPS view, the lines have no space between.
image
image

@sborenstein-ift
Copy link
Contributor Author

@meee1 I just reverted the first commit, which wasn't necessary, which addresses the questions you had. I think when I first started modifying this file, MVS did some wierd things to the RESX file. That wasn't necessary, I just removed that commit. Only the CS file is modified and changes should make more sense.

@meee1
Copy link
Contributor

meee1 commented Aug 8, 2022

@meee1 I just reverted the first commit, which wasn't necessary, which addresses the questions you had. I think when I first started modifying this file, MVS did some wierd things to the RESX file. That wasn't necessary, I just removed that commit. Only the CS file is modified and changes should make more sense.

yeah, i was going to say the resx is redundant, as its 100% user drawn in code, so no designed parts.

@meee1 meee1 merged commit 083d79b into ArduPilot:master Aug 11, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants