Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Param list improvements #3080

Merged
merged 8 commits into from
Apr 15, 2023
Merged

Conversation

robertlong13
Copy link
Collaborator

The really tall rows caused by long value descriptions makes the full param list hard to look at. Additionally, the cells causing this weren't particularly easy to read. Instead of auto-fitting the row height, I have opted to improve the look of the tooltip for overflowing cells. It is now significantly more readable.

image

While I was trying to bring some of those improvements over to the Full Parameter Tree view, I decided to overhaul it to make the two pages consistent. I think it looks and works much better to have a tree view separated in a split pane from the grid view. I'm pretty happy with how it turned out, and it could easily be combined into a single page instead of being offered as two separate options.

@meee1
Copy link
Contributor

meee1 commented Mar 15, 2023

the only thing to be mindfull of is Tree is not cross platform friendly. list is.

@meee1
Copy link
Contributor

meee1 commented Mar 15, 2023

although just knoticed you removed
BrightIdeasSoftware

so it might be friendly now

@robertlong13
Copy link
Collaborator Author

Yeah, the BrightIdeas tree control was being finnicky for me when I was trying to bring the tooltip changes over, and the documentation for it wasn't great, so I figured it was time to try an overhaul using built-in types. Should be cross-platform friendly. I can only test Windows, Android and Linux though.

@robertlong13
Copy link
Collaborator Author

robertlong13 commented Mar 15, 2023

I've actually decided to go all the way and eliminate the dedicated tree tab in favor of the merged set. I also added a button to collapse/expand the tree filter.
image

@robertlong13
Copy link
Collaborator Author

@meee1, any idea why I'm getting this issue on the Android build?

[Build Release APK](https://github.com/ArduPilot/MissionPlanner/actions/runs/4429522904/jobs/7770085962#step:1:41)
You are running out of disk space. The runner will stop working when the machine runs out of disk space. Free space left: 11 MB

I can't imagine that's related to this PR.

@meee1
Copy link
Contributor

meee1 commented Mar 15, 2023

@meee1, any idea why I'm getting this issue on the Android build?

[Build Release APK](https://github.com/ArduPilot/MissionPlanner/actions/runs/4429522904/jobs/7770085962#step:1:41)
You are running out of disk space. The runner will stop working when the machine runs out of disk space. Free space left: 11 MB

I can't imagine that's related to this PR.

fixed, cleared the build cache

@robertlong13
Copy link
Collaborator Author

Added comboboxes, numeric up/down, and a button for launching the bitmask editor, to the options column.

image

Reworked tooltip display for better viewing of now-hidden text
This also fixes the "favorites" feature, as well as a little-known
feature that opens urls in descriptions when clicked. These broke
the when the "default" column was added.
Also, driveby fix to ParameterMetaDataRepository, floats mixed in here
were causing rounding errors leading to errant warnings about being
out of bounds.
@meee1 meee1 merged commit f094171 into ArduPilot:master Apr 15, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants