Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

DatePicker/TimePicker popup positioning broken #7633

Closed
grokys opened this issue Feb 17, 2022 · 1 comment · Fixed by #7634
Closed

DatePicker/TimePicker popup positioning broken #7633

grokys opened this issue Feb 17, 2022 · 1 comment · Fixed by #7634
Labels
bug

Comments

@grokys
Copy link
Member

grokys commented Feb 17, 2022

Describe the bug

The popup in DatePicker/TimePicker is not displaying in the correct place.

To Reproduce
Steps to reproduce the behavior:

  1. Open ControlCatalog.NetCore
  2. Open a DatePicker/TimePicker
  3. Popup is no centered on control

Expected behavior

image

Actual behavior

image

Desktop (please complete the following information):

  • OS: All
  • Version: Since 0.10.11
@grokys grokys added the bug label Feb 17, 2022
@grokys
Copy link
Member Author

grokys commented Feb 17, 2022

Seems to have been broken by 54f82b2.

@grokys grokys mentioned this issue Feb 17, 2022
Merged
3 tasks
grokys added a commit that referenced this issue Feb 17, 2022
@grokys
Fix date/time picker popup positioning.
4a844e9 
Was broken by #7071 - `DatePicker` was doing a manual position configuration by calling `ConfigurePosition`. When the popup is shown, `Popup` gets a position change, and then re-calls `ConfigurePosition` with the settings in the popup, which are different to those passed during the manual configuration.

Change this to set properties on the `Popup` so that when the popup position is changed, the correct parameters are passed to `ConfigurePosition` by `Popup`.

Fixes #7633
@grokys grokys mentioned this issue Feb 17, 2022
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
bug
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Fix Date/Time picker popups AvaloniaUI/Avalonia
1 participant
@grokys