Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Feat/pricing fields #293

Merged
merged 20 commits into from
Aug 30, 2022
Merged

Feat/pricing fields #293

merged 20 commits into from
Aug 30, 2022

Conversation

justlevine
Copy link
Member

@justlevine justlevine commented Aug 22, 2022 •
edited
Loading

What

Adds support for pricing fields (product, quantity, option, shipping, total) to the schema.

Why

#195

How

  • feat: add support for Product, Quantity, Option, Shipping and Total GF fields.
  • test: ensure $_gf_state is reset between tests.
  • fix: ensure up-to-date entry is used to prepare field values for save.

Testing Instructions

Additional Info

Checklist:

  • My code is tested to the best of my abilities.
  • My code follows the WordPress Coding Standards.
  • My code has proper inline documentation.
  • I have added unit tests to verify the code works as intended.

@justlevine justlevine added the safe to test ✔ This PR can be run using repository secrets label Aug 28, 2022
justlevine and others added 13 commits August 29, 2022 09:44
@justlevine
Feat: Refactor FormField registration (AxeWP#273)
b0da3ae 
* feat!: refactor form field settings to use interfaces

* feat!: refactor form field choice and inputs to use interfaces

* chore: cleanup

* chore: rename types

* chore: cleanup filters

* docs: add new actions/filters

* chore: update composer deps
@justlevine
fix: remove duplicate $ignored_field values.
246c81b
@justlevine
fix: use the correct GF_Field for child types with their own classes
bcbc9b1
@justlevine
chore: order value methods alphabetically
307d145
@justlevine
feat: graduate product Field (query)
48f0ede
@justlevine
feat: gradiuate option, price, quantity, shipping, and `total…
b33dd56 
…` fields (query
@justlevine
fix: set fallback product quantity to 1
4657537
@justlevine
fix: change quantity GraphQL type to float
7f49441
@justlevine
chore: fix composer deps post rebase
896619e
@justlevine
feat: add Product mutation support
bfefdd1
@justlevine
feat: add price and formattedPrice to QuantitySelectFieldChoice
cf62527
@justlevine
tests: quantity field tests
52cc8e0
@justlevine
fix: docblock headers
08a7013
@justlevine justlevine force-pushed the feat/pricing-fields branch 2 times, most recently from 62d6c3e to 52bb138 Compare August 29, 2022 10:27
@justlevine justlevine marked this pull request as ready for review August 30, 2022 08:54
@justlevine justlevine merged commit fe69948 into AxeWP:develop Aug 30, 2022
@justlevine justlevine deleted the feat/pricing-fields branch August 30, 2022 08:58
@justlevine justlevine mentioned this pull request Aug 30, 2022
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
safe to test ✔ This PR can be run using repository secrets
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@justlevine