Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update PingPong and BazaarListing for compatibility with solc 0.5 (WorkBench) #221

Merged
merged 1 commit into from
Jan 6, 2020
Merged

Update PingPong and BazaarListing for compatibility with solc 0.5 (WorkBench) #221

merged 1 commit into from
Jan 6, 2020

Conversation

theMobiusStrip
Copy link
Contributor

Purpose

  • Update remaining samples for compatibility with solc 0.5 for WorkBench

Does this introduce a breaking change?

[ ] Yes
[x] No

Pull Request Type

What kind of change does this Pull Request introduce?

[ ] Bugfix
[x] Feature
[ ] Code style update (formatting, local variables)
[ ] Refactoring (no functional changes, no api changes)
[ ] Documentation content changes
[ ] Other... Please describe:

How to Test

  • Test the samples in WorkBench 1.8.0

What to Check

  • Check if the samples run in expected way

Other Information

brendalee
brendalee approved these changes Jan 6, 2020
View reviewed changes
Copy link
Contributor

@brendalee brendalee left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thanks - looks good to me!

@theMobiusStrip theMobiusStrip merged commit a25d849 into master Jan 6, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@brendalee brendalee brendalee approved these changes

@val-bc val-bc val-bc approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@theMobiusStrip @brendalee @val-bc