Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: remove invalid k8s v1.27 flags and feature gates #197

Merged
merged 7 commits into from
Oct 11, 2023

Conversation

christinalau0
Copy link
Contributor

Reason for Change:

  • In Kubernetes v1.27, several flags and feature gates were removed.
    • Users with existing api-models containing such a flag or feature gate would get broken deployments and upgrades. This PR will automatically remove the flag even if the user specifies it, for k8s v1.27+.
  • Added proper unit tests for all removed flags and feature gates.

Flags removed:
master-service-namespace (api-server, kubelet)
kubernetes/kubernetes#114446

container-runtime (kubelet)
kubernetes/kubernetes#114017

enable-taint-manager, pod-eviction-timeout (controller-manager)
kubernetes/kubernetes#115840

Feature gates removed:
ControllerManagerLeaderMigration
kubernetes/kubernetes#113534

ExpandCSIVolumes, ExpandInUsePersistentVolumes, ExpandPersistentVolumes
kubernetes/kubernetes#113942

CSIInlineVolume, CSIMigration, CSIMigrationAzureDisk, DaemonSetUpdateSurge, EphemeralContainers, IdentifyPodOS, LocalStorageCapacityIsolation, NetworkPolicyEndPort, StatefulSetMinReadySeconds
kubernetes/kubernetes#114410

Issue Fixed:

Credit Where Due:

Does this change contain code from or inspired by another project?

  • No
  • Yes

If "Yes," did you notify that project's maintainers and provide attribution?

  • No
  • Yes

Requirements:

Notes:

@christinalau0
Copy link
Contributor Author

/azp run

@azure-pipelines
Copy link

Azure Pipelines successfully started running 1 pipeline(s).

@christinalau0 christinalau0 merged commit 17b7c4b into Azure:master Oct 11, 2023
6 checks passed
@christinalau0 christinalau0 deleted the v1.27-flags branch October 11, 2023 22:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants