Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Python] Operation rename and bug fix #1302

Merged
merged 12 commits into from
Aug 8, 2016
Merged

[Python] Operation rename and bug fix #1302

merged 12 commits into from
Aug 8, 2016

Conversation

annatisch
Copy link
Member

Fix for issues #1196 and #1165

@tbombach
Copy link
Member

👍 LGTM

@@ -603,6 +603,8 @@ def serialize_date(attr, **kwargs):
:param Date attr: Object to be serialized.
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@lmazuel - I've made a couple of minor changes to serialization.py, if you could do a quick review :)
They should not be breaking, and I doubt are used by the existing clients so may not need a new release yet.

Effectively it's a change to support default/constant date and datetime values by allowing strings to passed in instead of date or datetime objects. The strings would need to already be in the correct ISO formatting that the request will serialize to. Let me know if you think this is okay.

@annatisch
Copy link
Member Author

@tbombach, @lmazuel,

Sorrry guys - I have to rebase the PR in order to merge and a bunch of other bug fixes got added to the PR - could I trouble you to take another look at the latest changes?
Fixes included for #1196, #1165 and #1304.

This PR also includes a fix to Python SDK bug #697

Please don't merge until @lmazuel has signed off that the Python SDK bug has been fully address to his liking.

Thanks!!

@tbombach
Copy link
Member

tbombach commented Aug 8, 2016

Looks good to me! I'll hold off on merging until Laurent signs off

@lmazuel lmazuel added the Python label Aug 8, 2016
@lmazuel
Copy link
Member

lmazuel commented Aug 8, 2016

@tbombach I take a look right now and tell you asap.
However, it's important to merge #1338 first when the tests here will be ok (a critical bug I had to fix in emergency).
Thanks!

@lmazuel
Copy link
Member

lmazuel commented Aug 8, 2016

@tbombach All Python SDK for services are green. I valid this!

@tbombach tbombach merged commit 5e87bce into Azure:master Aug 8, 2016
@tbombach
Copy link
Member

tbombach commented Aug 8, 2016

Merged

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants