-
Notifications
You must be signed in to change notification settings - Fork 734
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Python] Operation rename and bug fix #1302
Conversation
👍 LGTM |
More work to do here
@@ -603,6 +603,8 @@ def serialize_date(attr, **kwargs): | |||
:param Date attr: Object to be serialized. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@lmazuel - I've made a couple of minor changes to serialization.py, if you could do a quick review :)
They should not be breaking, and I doubt are used by the existing clients so may not need a new release yet.
Effectively it's a change to support default/constant date and datetime values by allowing strings to passed in instead of date or datetime objects. The strings would need to already be in the correct ISO formatting that the request will serialize to. Let me know if you think this is okay.
Sorrry guys - I have to rebase the PR in order to merge and a bunch of other bug fixes got added to the PR - could I trouble you to take another look at the latest changes? This PR also includes a fix to Python SDK bug #697 Please don't merge until @lmazuel has signed off that the Python SDK bug has been fully address to his liking. Thanks!! |
Looks good to me! I'll hold off on merging until Laurent signs off |
@tbombach All Python SDK for services are green. I valid this! |
Merged |
Fix for issues #1196 and #1165