-
Notifications
You must be signed in to change notification settings - Fork 3.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
adding TimeCreated property to PSVirtualMachineScaleSetVMProfile object #25657
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
grizzlytheodore
requested review from
bilaakpan-ms,
Sandido and
haagha
as code owners
July 25, 2024 22:27
️✔️Az.Accounts
️✔️Az.Compute
️✔️Az.KeyVault
️✔️Az.ManagedServiceIdentity
️✔️Az.Monitor
️✔️Az.Network
️✔️Az.OperationalInsights
️✔️Az.PrivateDns
️✔️Az.RecoveryServices
️✔️Az.Security
️✔️Az.Sql
️✔️Az.Ssh
️✔️Az.Storage
|
dolauli
reviewed
Jul 31, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Please add a changelog for this change.
Sandido
requested changes
Aug 5, 2024
src/Compute/Compute/ChangeLog.md
Outdated
@@ -21,6 +21,7 @@ | |||
--> | |||
## Upcoming Release | |||
* Renamed parameter `-VmId` to `-SourceId` and added `-VmId` as an alias to `New-AzRestorePointCollection` cmdlet. | |||
* Added `TimeCreated` field to `PSVirtualMachineScaleSetVMProfile` object. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Mention that this field is read only.
grizzlytheodore
changed the title
Update PSVirtualMachineScaleSetVMProfile.cs
adding TimeCreated property to PSVirtualMachineScaleSetVMProfile object
Aug 5, 2024
Sandido
approved these changes
Aug 5, 2024
dolauli
approved these changes
Aug 6, 2024
github-actions bot
pushed a commit
that referenced
this pull request
Aug 6, 2024
…ct (#25657) * Update PSVirtualMachineScaleSetVMProfile.cs * Update ChangeLog.md * Update ChangeLog.md * Update ChangeLog.md
6 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
addressing #22774
adding TimeCreated property to PSVirtualMachineScaleSetVMProfile object
locally tested:
Mandatory Checklist
Please choose the target release of Azure PowerShell. (⚠️ Target release is a different concept from API readiness. Please click below links for details.)
Check this box to confirm: I have read the Submitting Changes section of
CONTRIBUTING.md
and reviewed the following information:ChangeLog.md
file(s) appropriatelysrc/{{SERVICE}}/{{SERVICE}}/ChangeLog.md
.## Upcoming Release
header in the past tense.ChangeLog.md
if no new release is required, such as fixing test case only.