-
Notifications
You must be signed in to change notification settings - Fork 3.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Migrate RedisEnterpriseCache from generation to main #26103
Conversation
️✔️Az.Accounts
|
Type | Cmdlet | Description | Remediation |
---|---|---|---|
Get-AzRedisEnterpriseCache | Get-AzRedisEnterpriseCache Changes the ConfirmImpact but does not set the SupportsShouldProcess property to true in the cmdlet attribute. | Determine if the cmdlet should implement ShouldProcess and if so determine if it should implement Force / ShouldContinue | |
Get-AzRedisEnterpriseCache | Get-AzRedisEnterpriseCache changes the confirm impact. Please ensure that the change in ConfirmImpact is justified | Verify that ConfirmImpact is changed appropriately by the cmdlet. It is very rare for a cmdlet to change the ConfirmImpact. | |
Get-AzRedisEnterpriseCacheAccessPolicyAssignment | Get-AzRedisEnterpriseCacheAccessPolicyAssignment Changes the ConfirmImpact but does not set the SupportsShouldProcess property to true in the cmdlet attribute. | Determine if the cmdlet should implement ShouldProcess and if so determine if it should implement Force / ShouldContinue | |
Get-AzRedisEnterpriseCacheAccessPolicyAssignment | Get-AzRedisEnterpriseCacheAccessPolicyAssignment changes the confirm impact. Please ensure that the change in ConfirmImpact is justified | Verify that ConfirmImpact is changed appropriately by the cmdlet. It is very rare for a cmdlet to change the ConfirmImpact. | |
Get-AzRedisEnterpriseCacheDatabase | Get-AzRedisEnterpriseCacheDatabase Changes the ConfirmImpact but does not set the SupportsShouldProcess property to true in the cmdlet attribute. | Determine if the cmdlet should implement ShouldProcess and if so determine if it should implement Force / ShouldContinue | |
Get-AzRedisEnterpriseCacheDatabase | Get-AzRedisEnterpriseCacheDatabase changes the confirm impact. Please ensure that the change in ConfirmImpact is justified | Verify that ConfirmImpact is changed appropriately by the cmdlet. It is very rare for a cmdlet to change the ConfirmImpact. | |
Get-AzRedisEnterpriseCacheOperationStatus | Get-AzRedisEnterpriseCacheOperationStatus Changes the ConfirmImpact but does not set the SupportsShouldProcess property to true in the cmdlet attribute. | Determine if the cmdlet should implement ShouldProcess and if so determine if it should implement Force / ShouldContinue | |
Get-AzRedisEnterpriseCacheOperationStatus | Get-AzRedisEnterpriseCacheOperationStatus changes the confirm impact. Please ensure that the change in ConfirmImpact is justified | Verify that ConfirmImpact is changed appropriately by the cmdlet. It is very rare for a cmdlet to change the ConfirmImpact. |
⚠️ Windows PowerShell - Windows
Type | Cmdlet | Description | Remediation |
---|---|---|---|
Get-AzRedisEnterpriseCache | Get-AzRedisEnterpriseCache Changes the ConfirmImpact but does not set the SupportsShouldProcess property to true in the cmdlet attribute. | Determine if the cmdlet should implement ShouldProcess and if so determine if it should implement Force / ShouldContinue | |
Get-AzRedisEnterpriseCache | Get-AzRedisEnterpriseCache changes the confirm impact. Please ensure that the change in ConfirmImpact is justified | Verify that ConfirmImpact is changed appropriately by the cmdlet. It is very rare for a cmdlet to change the ConfirmImpact. | |
Get-AzRedisEnterpriseCacheAccessPolicyAssignment | Get-AzRedisEnterpriseCacheAccessPolicyAssignment Changes the ConfirmImpact but does not set the SupportsShouldProcess property to true in the cmdlet attribute. | Determine if the cmdlet should implement ShouldProcess and if so determine if it should implement Force / ShouldContinue | |
Get-AzRedisEnterpriseCacheAccessPolicyAssignment | Get-AzRedisEnterpriseCacheAccessPolicyAssignment changes the confirm impact. Please ensure that the change in ConfirmImpact is justified | Verify that ConfirmImpact is changed appropriately by the cmdlet. It is very rare for a cmdlet to change the ConfirmImpact. | |
Get-AzRedisEnterpriseCacheDatabase | Get-AzRedisEnterpriseCacheDatabase Changes the ConfirmImpact but does not set the SupportsShouldProcess property to true in the cmdlet attribute. | Determine if the cmdlet should implement ShouldProcess and if so determine if it should implement Force / ShouldContinue | |
Get-AzRedisEnterpriseCacheDatabase | Get-AzRedisEnterpriseCacheDatabase changes the confirm impact. Please ensure that the change in ConfirmImpact is justified | Verify that ConfirmImpact is changed appropriately by the cmdlet. It is very rare for a cmdlet to change the ConfirmImpact. | |
Get-AzRedisEnterpriseCacheOperationStatus | Get-AzRedisEnterpriseCacheOperationStatus Changes the ConfirmImpact but does not set the SupportsShouldProcess property to true in the cmdlet attribute. | Determine if the cmdlet should implement ShouldProcess and if so determine if it should implement Force / ShouldContinue | |
Get-AzRedisEnterpriseCacheOperationStatus | Get-AzRedisEnterpriseCacheOperationStatus changes the confirm impact. Please ensure that the change in ConfirmImpact is justified | Verify that ConfirmImpact is changed appropriately by the cmdlet. It is very rare for a cmdlet to change the ConfirmImpact. |
⚠️ Help Example Check
⚠️ PowerShell Core - Windows
Type Cmdlet Example Line RuleName Description Extent Remediation ⚠️ New-AzRedisEnterpriseCache 2 1 Mismatched_Parameter_Value_Type New-AzRedisEnterpriseCache -Module '{name:RedisBloom, args: 'ERROR_RATE 0.00 INITIAL_SIZE 400
'}','{name:RedisTimeSeries, args:'RETENTION_POLICY 20
'}','{name:RediSearch}' is not an expected parameter value type.-Module Use correct parameter value type. Expected Type is Microsoft.Azure.PowerShell.Cmdlets.RedisEnterpriseCache.Models.Api20240901Preview.IModule. Now the type is string.(Static). ⚠️ New-AzRedisEnterpriseCache 4 1 Mismatched_Parameter_Value_Type New-AzRedisEnterpriseCache -LinkedDatabase '{id:'/subscriptions/6b9ac7d2-7f6d-4de4-962c-43fda44bc3f2/resourceGroups/MyGroup/providers/Microsoft.Cache/redisEnterprise/MyCache/databases/default'}' is not an expected parameter value type. -LinkedDatabase Use correct parameter value type. Expected Type is Microsoft.Azure.PowerShell.Cmdlets.RedisEnterpriseCache.Models.Api20240901Preview.ILinkedDatabase. Now the type is string.(Static). ⚠️ New-AzRedisEnterpriseCacheDatabase 1 1 Mismatched_Parameter_Value_Type New-AzRedisEnterpriseCacheDatabase -Module '{name:RedisBloom, args: 'ERROR_RATE 0.00 INITIAL_SIZE 400
'}','{name:RedisTimeSeries, args:'RETENTION_POLICY 20
'}','{name:RediSearch}' is not an expected parameter value type.-Module Use correct parameter value type. Expected Type is Microsoft.Azure.PowerShell.Cmdlets.RedisEnterpriseCache.Models.Api20240901Preview.IModule. Now the type is string.(Static). ⚠️ New-AzRedisEnterpriseCacheDatabase 2 1 Mismatched_Parameter_Value_Type New-AzRedisEnterpriseCacheDatabase -LinkedDatabase '{id:'/subscriptions/sub1/resourceGroups/MyGroup/providers/Microsoft.Cache/redisEnterprise/MyCache1/databases/default'}','{id:'/subscriptions/sub1/resourceGroups/MyGroup/providers/Microsoft.Cache/redisEnterprise/MyCache2/databases/default'}' is not an expected parameter value type. -LinkedDatabase Use correct parameter value type. Expected Type is Microsoft.Azure.PowerShell.Cmdlets.RedisEnterpriseCache.Models.Api20240901Preview.ILinkedDatabase. Now the type is string.(Static). ⚠️ New-AzRedisEnterpriseCache 2 1 Mismatched_Parameter_Value_Type New-AzRedisEnterpriseCache -Module '{name:RedisBloom, args: 'ERROR_RATE 0.00 INITIAL_SIZE 400
'}','{name:RedisTimeSeries, args:'RETENTION_POLICY 20
'}','{name:RediSearch}' is not an expected parameter value type.-Module Use correct parameter value type. Expected Type is Microsoft.Azure.PowerShell.Cmdlets.RedisEnterpriseCache.Models.Api20240901Preview.IModule. Now the type is string.(Static). ⚠️ New-AzRedisEnterpriseCache 4 1 Mismatched_Parameter_Value_Type New-AzRedisEnterpriseCache -LinkedDatabase '{id:'/subscriptions/6b9ac7d2-7f6d-4de4-962c-43fda44bc3f2/resourceGroups/MyGroup/providers/Microsoft.Cache/redisEnterprise/MyCache/databases/default'}' is not an expected parameter value type. -LinkedDatabase Use correct parameter value type. Expected Type is Microsoft.Azure.PowerShell.Cmdlets.RedisEnterpriseCache.Models.Api20240901Preview.ILinkedDatabase. Now the type is string.(Static). ⚠️ New-AzRedisEnterpriseCacheDatabase 1 1 Mismatched_Parameter_Value_Type New-AzRedisEnterpriseCacheDatabase -Module '{name:RedisBloom, args: 'ERROR_RATE 0.00 INITIAL_SIZE 400
'}','{name:RedisTimeSeries, args:'RETENTION_POLICY 20
'}','{name:RediSearch}' is not an expected parameter value type.-Module Use correct parameter value type. Expected Type is Microsoft.Azure.PowerShell.Cmdlets.RedisEnterpriseCache.Models.Api20240901Preview.IModule. Now the type is string.(Static). ⚠️ New-AzRedisEnterpriseCacheDatabase 2 1 Mismatched_Parameter_Value_Type New-AzRedisEnterpriseCacheDatabase -LinkedDatabase '{id:'/subscriptions/sub1/resourceGroups/MyGroup/providers/Microsoft.Cache/redisEnterprise/MyCache1/databases/default'}','{id:'/subscriptions/sub1/resourceGroups/MyGroup/providers/Microsoft.Cache/redisEnterprise/MyCache2/databases/default'}' is not an expected parameter value type. -LinkedDatabase Use correct parameter value type. Expected Type is Microsoft.Azure.PowerShell.Cmdlets.RedisEnterpriseCache.Models.Api20240901Preview.ILinkedDatabase. Now the type is string.(Static).
⚠️ Windows PowerShell - Windows
Type Cmdlet Example Line RuleName Description Extent Remediation ⚠️ New-AzRedisEnterpriseCache 2 1 Mismatched_Parameter_Value_Type New-AzRedisEnterpriseCache -Module '{name:RedisBloom, args: 'ERROR_RATE 0.00 INITIAL_SIZE 400
'}','{name:RedisTimeSeries, args:'RETENTION_POLICY 20
'}','{name:RediSearch}' is not an expected parameter value type.-Module Use correct parameter value type. Expected Type is Microsoft.Azure.PowerShell.Cmdlets.RedisEnterpriseCache.Models.Api20240901Preview.IModule. Now the type is string.(Static). ⚠️ New-AzRedisEnterpriseCache 4 1 Mismatched_Parameter_Value_Type New-AzRedisEnterpriseCache -LinkedDatabase '{id:'/subscriptions/6b9ac7d2-7f6d-4de4-962c-43fda44bc3f2/resourceGroups/MyGroup/providers/Microsoft.Cache/redisEnterprise/MyCache/databases/default'}' is not an expected parameter value type. -LinkedDatabase Use correct parameter value type. Expected Type is Microsoft.Azure.PowerShell.Cmdlets.RedisEnterpriseCache.Models.Api20240901Preview.ILinkedDatabase. Now the type is string.(Static). ⚠️ New-AzRedisEnterpriseCacheDatabase 1 1 Mismatched_Parameter_Value_Type New-AzRedisEnterpriseCacheDatabase -Module '{name:RedisBloom, args: 'ERROR_RATE 0.00 INITIAL_SIZE 400
'}','{name:RedisTimeSeries, args:'RETENTION_POLICY 20
'}','{name:RediSearch}' is not an expected parameter value type.-Module Use correct parameter value type. Expected Type is Microsoft.Azure.PowerShell.Cmdlets.RedisEnterpriseCache.Models.Api20240901Preview.IModule. Now the type is string.(Static). ⚠️ New-AzRedisEnterpriseCacheDatabase 2 1 Mismatched_Parameter_Value_Type New-AzRedisEnterpriseCacheDatabase -LinkedDatabase '{id:'/subscriptions/sub1/resourceGroups/MyGroup/providers/Microsoft.Cache/redisEnterprise/MyCache1/databases/default'}','{id:'/subscriptions/sub1/resourceGroups/MyGroup/providers/Microsoft.Cache/redisEnterprise/MyCache2/databases/default'}' is not an expected parameter value type. -LinkedDatabase Use correct parameter value type. Expected Type is Microsoft.Azure.PowerShell.Cmdlets.RedisEnterpriseCache.Models.Api20240901Preview.ILinkedDatabase. Now the type is string.(Static). ⚠️ New-AzRedisEnterpriseCache 2 1 Mismatched_Parameter_Value_Type New-AzRedisEnterpriseCache -Module '{name:RedisBloom, args: 'ERROR_RATE 0.00 INITIAL_SIZE 400
'}','{name:RedisTimeSeries, args:'RETENTION_POLICY 20
'}','{name:RediSearch}' is not an expected parameter value type.-Module Use correct parameter value type. Expected Type is Microsoft.Azure.PowerShell.Cmdlets.RedisEnterpriseCache.Models.Api20240901Preview.IModule. Now the type is string.(Static). ⚠️ New-AzRedisEnterpriseCache 4 1 Mismatched_Parameter_Value_Type New-AzRedisEnterpriseCache -LinkedDatabase '{id:'/subscriptions/6b9ac7d2-7f6d-4de4-962c-43fda44bc3f2/resourceGroups/MyGroup/providers/Microsoft.Cache/redisEnterprise/MyCache/databases/default'}' is not an expected parameter value type. -LinkedDatabase Use correct parameter value type. Expected Type is Microsoft.Azure.PowerShell.Cmdlets.RedisEnterpriseCache.Models.Api20240901Preview.ILinkedDatabase. Now the type is string.(Static). ⚠️ New-AzRedisEnterpriseCacheDatabase 1 1 Mismatched_Parameter_Value_Type New-AzRedisEnterpriseCacheDatabase -Module '{name:RedisBloom, args: 'ERROR_RATE 0.00 INITIAL_SIZE 400
'}','{name:RedisTimeSeries, args:'RETENTION_POLICY 20
'}','{name:RediSearch}' is not an expected parameter value type.-Module Use correct parameter value type. Expected Type is Microsoft.Azure.PowerShell.Cmdlets.RedisEnterpriseCache.Models.Api20240901Preview.IModule. Now the type is string.(Static). ⚠️ New-AzRedisEnterpriseCacheDatabase 2 1 Mismatched_Parameter_Value_Type New-AzRedisEnterpriseCacheDatabase -LinkedDatabase '{id:'/subscriptions/sub1/resourceGroups/MyGroup/providers/Microsoft.Cache/redisEnterprise/MyCache1/databases/default'}','{id:'/subscriptions/sub1/resourceGroups/MyGroup/providers/Microsoft.Cache/redisEnterprise/MyCache2/databases/default'}' is not an expected parameter value type. -LinkedDatabase Use correct parameter value type. Expected Type is Microsoft.Azure.PowerShell.Cmdlets.RedisEnterpriseCache.Models.Api20240901Preview.ILinkedDatabase. Now the type is string.(Static).
️✔️Help File Existence Check
️✔️PowerShell Core - Windows
️✔️Windows PowerShell - Windows
⚠️ File Change Check
⚠️ PowerShell Core - Windows
Type Cmdlet Description Remediation ⚠️ It is required to update ChangeLog.md if you want to release a new version for Az.RedisEnterpriseCache. Add a changelog record under Upcoming Release section with past tense.
⚠️ Windows PowerShell - Windows
Type Cmdlet Description Remediation ⚠️ It is required to update ChangeLog.md if you want to release a new version for Az.RedisEnterpriseCache. Add a changelog record under Upcoming Release section with past tense.
️✔️UX Metadata Check
️✔️PowerShell Core - Windows
️✔️Windows PowerShell - Windows
⚠️ Test
⚠️ - Linux
Type Title Current Coverage Description ⚠️ Test Coverage Less Than 50% 40.00 % Test coverage for the module cannot be lower than 50%.
⚠️ - MacOS
Type Title Current Coverage Description ⚠️ Test Coverage Less Than 50% 40.00% Test coverage for the module cannot be lower than 50%.
⚠️ PowerShell Core - Windows
Type Title Current Coverage Description ⚠️ Test Coverage Less Than 50% 40.00% Test coverage for the module cannot be lower than 50%.
⚠️ Windows PowerShell - Windows
Type Title Current Coverage Description ⚠️ Test Coverage Less Than 50% 40.00% Test coverage for the module cannot be lower than 50%.
Thank you for your contribution azure-pipelines[bot]! We will review the pull request and get back to you soon. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
No change log
## SYNTAX | ||
|
||
``` | ||
Update-AzRedisEnterpriseCacheDatabaseDbRedisVersion -ClusterName <String> -DatabaseName <String> |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Update-AzRedisEnterpriseCacheDatabaseDbRedisVersion doesn't have expanded version and so we shall keep UpgradeViaIdentity
This PR was labeled "needs-revision" because it has unresolved review comments or CI failures. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@revanthballa1188
Please revise the directive to add back UpgradeViaIdentity of Update-AzRedisEnterpriseCacheDatabaseDbRedisVersion and provide the change log.
Please create a new PR targeting to generation branch and I will update the current PR
require: | ||
- $(this-folder)/../../readme.azure.noprofile.md | ||
# lock the commit | ||
input-file: | ||
- $(repo)/specification/redisenterprise/resource-manager/Microsoft.Cache/preview/2023-03-01-preview/redisenterprise.json |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
- where:
verb: Update
subject: ^$|Database
variant: ^Update$|ViaIdentity$
The directive above removes the UpgradeViaIdentity
of Update-AzRedisEnterpriseCacheDatabaseDbRedisVersion
.
remove: true
c88484f
to
a47b1d8
Compare
There is Changelog.md file in the generation branch. Adding it here for now: |
Description
Migrate RedisEnterpriseCache from generation to main
The last commit of src/RedisEnterpriseCache in generation is:
commit a5ac1e5 Author: revanthballa1188 125347990+revanthballa1188@users.noreply.github.com Date: Fri Sep 6 00:15:30 2024 +0530 Add 2024-06-01-preview for redis enterprise (#25460) * Add 2024-06-01-preview for redis enterprise * Update New-AzRedisEnterpriseCache.ps1 * update files aftre building modules * Add test recordings * Update examples of force unlink and upgrade db * fix SKU naming * fix examples --------- Co-authored-by: Yabo Hu yabhu@microsoft.com
Checklist