Add xms-ids for machinelearning, machinelearningcompute, machinelearningexperimentation and machinelearningservices #17734
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Hi, @LinglingTong Thanks for your PR. I am workflow bot for review process. Here are some small tips. Any feedback about review process or workflow bot, pls contact swagger and tools team. vsswagger@microsoft.com |
|
[Call for Action] To better understand Azure service dev/test scenario, and support Azure service developer better on Swagger and REST API related tests in early phase, please help to fill in with this survey https://aka.ms/SurveyForEarlyPhase. It will take 5 to 10 minutes. If you already complete survey, please neglect this comment. Thanks. |
Swagger Generation Artifacts
|
|
This PR is to add the missing x-ms-identifiers metadata: http://azure.github.io/autorest/extensions/#x-ms-identifiers for machinelearning, machinelearningcompute, machinelearningexperimentation and machinelearningservices |
|
Hi @LinglingTong, Your PR has some issues. Please fix the CI sequentially by following the order of
|
This was referenced Feb 9, 2022
This was referenced Feb 9, 2022
|
Looked at the ModelValidation failures and they don't seem to relate to my current changes. |
This was referenced Feb 16, 2022
zhaomuzhi
reviewed
Feb 16, 2022
| } | ||
| }, | ||
| "x-ms-identifiers": [ | ||
| "code" |
There was a problem hiding this comment.
code is not unique, the message will be unique though.
There was a problem hiding this comment.
Thanks for pointing it out. I have change the identifiers to message in the new iteration.
zhaomuzhi
reviewed
Feb 16, 2022
| } | ||
| }, | ||
| "x-ms-identifiers": [ | ||
| "code" |
zhaomuzhi
reviewed
Feb 16, 2022
| @@ -3161,6 +3204,9 @@ | |||
| "items": { | |||
| "$ref": "../../../../../common-types/resource-management/v2/types.json#/definitions/ErrorResponse" | |||
| }, | |||
| "x-ms-identifiers": [ | |||
| "error/code" | |||
There was a problem hiding this comment.
'error/code' or '/error/code'?
There was a problem hiding this comment.
Should be /error/code. I have updated it in the new iteration.
zhaomuzhi
approved these changes
Feb 24, 2022
|
Suppress the modelValidation and SemanticValidation since this PR never touches anything related |
ArcturusZhang
approved these changes
Feb 25, 2022
This was referenced Feb 25, 2022
Closed
FredericHeem
pushed a commit
to grucloud/azure-rest-api-specs
that referenced
this pull request
Mar 7, 2022
…ingexperimentation and machinelearningservices (Azure#17734) * add xmsids for machinelearning rps * update inner properties * address code review comments
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
MSFT employees can try out our new experience at OpenAPI Hub - one location for using our validation tools and finding your workflow.
Changelog
Add a changelog entry for this PR by answering the following questions:
About the Change
APIs will need to start indicating item uniqueness in arrays. By default, uniqueness is the string property called "id" of items in an array. When that property does not exist, the x-ms-identifiers extension property must be used to specify the identifying property(s) or lack thereof. This pull request is my best guess effort to ease resource providers into the new requirement before it becomes enforced. Compliance and accuracy will need to be owned and maintained by the resource provider going forward.
See https://github.com/Azure/autorest/tree/main/docs/extensions#x-ms-identifiers.
Contribution checklist:
If any further question about AME onboarding or validation tools, please view the FAQ.
ARM API Review Checklist
Otherwise your PR may be subject to ARM review requirements. Complete the following:
Check this box if any of the following apply to the PR so that label "WaitForARMFeedback" will be added automatically to begin ARM API Review. Failure to comply may result in delays to the manifest.
-[ ] To review changes efficiently, ensure you are using OpenAPIHub to initialize the PR for adding a new version. More details, refer to the wiki.
Ensure you've reviewed following guidelines including ARM resource provider contract and REST guidelines. Estimated time (4 hours). This is required before you can request review from ARM API Review board.
If you are blocked on ARM review and want to get the PR merged with urgency, please get the ARM oncall for reviews (RP Manifest Approvers team under Azure Resource Manager service) from IcM and reach out to them.
Breaking Change Review Checklist
If any of the following scenarios apply to the PR, request approval from the Breaking Change Review Board as defined in the Breaking Change Policy.
Action: to initiate an evaluation of the breaking change, create a new intake using the template for breaking changes. Addition details on the process and office hours are on the Breaking change Wiki.
Please follow the link to find more details on PR review process.