Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adding new Automation API version (2017-05-15-preview) #1953

Merged
merged 9 commits into from
Nov 7, 2017

Conversation

finiteattractor
Copy link
Contributor

@finiteattractor finiteattractor commented Oct 31, 2017

Changes included:

  • Older commits:
    • Added extension properties to Get & GetNode
    • Indentation fixes
  • Latest commit:
    • Added new API version (2017-5-15-preview). This includes only 3 new resources and all other resources were referenced as is from the previous version. Passed both azure validation, SDK code generation, and example validation.

eshaparmar and others added 8 commits September 11, 2017 12:42
Added extension properties to DSCNode for Get/GetNode api calls
Bring in the changes from Upstream to
AzureAutomationTeam
Adding new API version (2017-05-15-preview). Only three new resources added and all others reference the previous version. 

- Added resources:
 - SoftwareUpdateConfiguration
 - SoftwareUpdateConfigurationRun
 - SoftwareUpdateConfigurationMachineRun

- Validations:
 - Autorest azure validations passed
  - x-ms-examples validated with no errors
@@ -59,6 +59,34 @@ input-file:
```


### Tag: package-2017-05-preview
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Do you want to add this tag to the Basic Configuration section???

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yes, noticed that other resource providers add tag per version (which seems to help in constructing a version by composing resources from different directories - which I wanted to do). Let me know if there is any undesirable side effect of this as I'm pretty new to swagger world.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@finiteattractor To explain the process, You create a swagger file and you have a configuration file (README.md) where you specify the tags which lists the swagger files you would like to use for that specific tag and also specify which tag you would like to use (There can be multiple tags) for the generation of the SDK.

That is, the SDK generation looks for the configuration file, finds the tag to be used, finds the swagger files and uses them to generate the SDK. That version of SDK will have the code from those specifically picked swagger files.

What will happen if you have a swagger file that is not referenced in the configuration file? That swagger file will never get picked up and thus never be used in the SDK generation.

Now, Where do you need to add the file? It depends on your use case. Do you have other swagger files also that need to be used in the generation of the SDK? If so, all of them must go inside one tag. Else, create a tag with this file alone and mark that as default tag. It really depends on your requirement. If you still have any questions, I am always here to help and you could arrange a call.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@sarangan12 Thanks a lot for detailed explanation! This makes sense. Now It seems that the only thing I need to add is to add the new package-2017-preview to the Tag element in the beginning (line 31). Could you please shed some light on the use of this element and can it accept comma separated values?

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@finiteattractor It accepts a single value. So it will be package-2017-05-preview

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great! I updated the file to reflect this! Thanks!

Updated tag in global configuration to use the latest api version as per azure PR review comment
@sarangan12 sarangan12 merged commit ed7a298 into Azure:current Nov 7, 2017
@AutorestCI
Copy link

No modification for AutorestCI/azure-sdk-for-node

@AutorestCI
Copy link

No modification for AutorestCI/azure-sdk-for-python

@AutorestCI
Copy link

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants