Update logicAppsManagementClient.json to current offerings #2761

refortie · 2018-03-27T23:21:26Z

This checklist is used to make sure that common issues in a pull request are addressed. This will expedite the process of getting your pull request merged and avoid extra work on your part to fix issues discovered during the review process.

PR information

The title of the PR is clear and informative.
There are a small number of commits, each of which have an informative message. This means that previously merged commits do not appear in the history of the PR. For information on cleaning up the commits in your pull request, see this page.
Except for special cases involving multiple contributors, the PR is started from a fork of the main repository, not a branch.
If applicable, the PR references the bug/issue that it fixes.
Swagger files are correctly named (e.g. the api-version in the path should match the api-version in the spec).

Quality of Swagger

I have read the contribution guidelines.
My spec meets the review criteria:
- The spec conforms to the Swagger 2.0 specification.
- The spec follows the guidelines described in the Swagger checklist document.
- Validation tools were run on swagger spec(s) and have all been fixed in this PR.

Added examples to support the swagger endpoints. Did some cleanup on the swagger itself, such as organizing the parameters alphabetically.

AutorestCI · 2018-03-27T23:24:13Z

Automation for azure-sdk-for-python

The initial PR has been merged into your service PR:
Azure/azure-sdk-for-python#2065

AutorestCI · 2018-03-27T23:27:18Z

Automation for azure-sdk-for-go

A PR has been created for you based on this PR content.

Once this PR will be merged, content will be added to your service PR:
Azure/azure-sdk-for-go#1456

AutorestCI · 2018-03-27T23:33:33Z

Automation for azure-libraries-for-java

The initial PR has been merged into your service PR:
AutorestCI/azure-libraries-for-java#4

AutorestCI · 2018-03-27T23:46:10Z

Automation for azure-sdk-for-node

A PR has been created for you:
Azure/azure-sdk-for-node#2568

jhendrixMSFT

There are model validation errors with regards to samples, please see the log here.
Also this new swagger has not been added to any package in the README.md file, is that intentional?

refortie · 2018-03-29T18:21:26Z

@jhendrixMSFT Fixed the model build. I'm not sure what you mean by the readme.md file

jhendrixMSFT · 2018-03-29T18:24:34Z

@refortie thanks I'll review the changes. The README file here. If you want your new swagger to get included in SDKs then you must add it to the appropriate package(s) in the README.

jhendrixMSFT · 2018-03-29T19:42:07Z

@refortie Also has this new API been reviewed by ARM and the API review board?

jhendrixMSFT · 2018-03-29T19:45:02Z

...fication/web/resource-manager/Microsoft.Web/stable/2016-06-01/logicAppsManagementClient.json

+                    "Connection Gateways"
+                ],
+                "summary": "Lists all of the connection gateways",
+                "operationId": "ConnectionGateways_ListAll",


This should be ConnectionGateways_List.

jhendrixMSFT · 2018-03-29T19:45:29Z

...fication/web/resource-manager/Microsoft.Web/stable/2016-06-01/logicAppsManagementClient.json

+                    "Connection Gateways"
+                ],
+                "summary": "Lists all of the connection gateways",
+                "operationId": "ConnectionGateways_List",


This should be ConnectionGateways_ListByResourceGroup.

jhendrixMSFT · 2018-03-29T19:46:32Z

...fication/web/resource-manager/Microsoft.Web/stable/2016-06-01/logicAppsManagementClient.json

+                    "Custom APIs"
+                ],
+                "summary": "List of custom APIs",
+                "operationId": "CustomApis_ListAll",


This should be CustomApis_List.

jhendrixMSFT · 2018-03-29T19:46:50Z

...fication/web/resource-manager/Microsoft.Web/stable/2016-06-01/logicAppsManagementClient.json

+                    "Custom APIs"
+                ],
+                "summary": "List of custom APIs",
+                "operationId": "CustomApis_List",


This should be CustomApis_ListByResourceGroup.

refortie · 2018-03-29T20:17:02Z

We will be holding off on adding it to the SDK for the time being. We will be coming back next month to do more endpoints. This is just to bring us up to compliance.

Also this isn't a new API, these APIs have already existed in prod for a while now, this is just to put out swagger for them.

refortie added 5 commits March 21, 2018 15:29

Added missing endpoints to swagger and updated existing endpoints

106212d

Add examples to support swagger

b042890

Added examples to support the swagger endpoints. Did some cleanup on the swagger itself, such as organizing the parameters alphabetically.

PR changes

bd42802

PR Updates

3212743

PR Updates

a708b01

azuresdkci assigned jhendrixMSFT Mar 27, 2018

azuresdkci requested a review from jhendrixMSFT March 27, 2018 23:22

AutorestCI mentioned this pull request Mar 27, 2018

[AutoPR web/resource-manager] Update logicAppsManagementClient.json to current offerings Azure/azure-sdk-for-python#2289

Merged

AutorestCI mentioned this pull request Mar 27, 2018

[AutoPR web/resource-manager] Update logicAppsManagementClient.json to current offerings Azure/azure-sdk-for-go#1455

Closed

AutorestCI mentioned this pull request Mar 27, 2018

[AutoPR web/resource-manager] Update logicAppsManagementClient.json to current offerings AutorestCI/azure-libraries-for-java#16

Merged

AutorestCI mentioned this pull request Mar 27, 2018

[AutoPR web/resource-manager] Update logicAppsManagementClient.json to current offerings Azure/azure-sdk-for-node#2568

Closed

refortie added 2 commits March 28, 2018 10:31

Extra comma

79c7d6e

Fix for semantic build

673450f

jhendrixMSFT requested changes Mar 28, 2018

View reviewed changes

refortie added 10 commits March 28, 2018 12:35

Fix for some of the build errors, more to be fixed still

eb473a9

Further build fixes, still more to be done

47b1f3e

Further refinement

5b76b85

Further refinement

ca820bb

Further refinement

e1d723a

Further refinement

7027418

Further refinement

b7d6a15

Removed anonymous types from responses

a511219

errant S

184fe02

Fix casing

50c0b66

jhendrixMSFT requested changes Mar 29, 2018

View reviewed changes

PR Updates

d8ef072

jhendrixMSFT approved these changes Mar 29, 2018

View reviewed changes

jhendrixMSFT merged commit 9f1cdba into Azure:master Mar 29, 2018

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Update logicAppsManagementClient.json to current offerings #2761

Update logicAppsManagementClient.json to current offerings #2761

refortie commented Mar 27, 2018 •

edited by azuresdkci

Loading

AutorestCI commented Mar 27, 2018 •

edited

Loading

AutorestCI commented Mar 27, 2018 •

edited

Loading

AutorestCI commented Mar 27, 2018 •

edited

Loading

AutorestCI commented Mar 27, 2018 •

edited

Loading

jhendrixMSFT left a comment

refortie commented Mar 29, 2018

jhendrixMSFT commented Mar 29, 2018

jhendrixMSFT commented Mar 29, 2018

jhendrixMSFT Mar 29, 2018

refortie Mar 29, 2018

jhendrixMSFT Mar 29, 2018

refortie Mar 29, 2018

jhendrixMSFT Mar 29, 2018

refortie Mar 29, 2018

jhendrixMSFT Mar 29, 2018

refortie Mar 29, 2018

refortie commented Mar 29, 2018

Update logicAppsManagementClient.json to current offerings #2761

Update logicAppsManagementClient.json to current offerings #2761

Conversation

refortie commented Mar 27, 2018 • edited by azuresdkci Loading

PR information

Quality of Swagger

AutorestCI commented Mar 27, 2018 • edited Loading

Automation for azure-sdk-for-python

AutorestCI commented Mar 27, 2018 • edited Loading

Automation for azure-sdk-for-go

AutorestCI commented Mar 27, 2018 • edited Loading

Automation for azure-libraries-for-java

AutorestCI commented Mar 27, 2018 • edited Loading

Automation for azure-sdk-for-node

jhendrixMSFT left a comment

Choose a reason for hiding this comment

refortie commented Mar 29, 2018

jhendrixMSFT commented Mar 29, 2018

jhendrixMSFT commented Mar 29, 2018

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

refortie commented Mar 29, 2018

refortie commented Mar 27, 2018 •

edited by azuresdkci

Loading

AutorestCI commented Mar 27, 2018 •

edited

Loading

AutorestCI commented Mar 27, 2018 •

edited

Loading

AutorestCI commented Mar 27, 2018 •

edited

Loading

AutorestCI commented Mar 27, 2018 •

edited

Loading