-
Notifications
You must be signed in to change notification settings - Fork 5.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update spec PR review workflow diagram: simplify + make it also applicable to data-plane. #28930
Conversation
Next Steps to Merge✅ All automated merging requirements have been met! To get your PR merged, see aka.ms/azsdk/specreview/merge. |
Swagger Validation Report
|
Swagger Generation Artifacts
|
PR validation pipeline restarted successfully. If there is ApiView generated, it will be updated in this comment. |
@konrad-jamrozik Looking into consolidating information across , in the diagram Step #2 "ARM or data-plane review` the message doesn't talk about data plane review at all. Is this because the message is no in the Next steps to Merge? |
I discussed this with @maririos offline. I didn't mention data-plane review because it was a bit too complex and I wanted to keep the diagram lightweight. But perhaps I can figure out a way to update the diagram to make it clear it is ARM xor data-plane. |
This PR, before it can be merged, requires changes to aka.ms/azsdk/specreview/merge because currently that URL refers to text in the diagram that is being removed by this PR. I also need to review any mentions of the diagram in the
openapi-alps
code to ensure it is not referencing information erased by this PR.Prerequisite PRs:
This PR addresses:
This PR builds on recent improvements made to
Next Steps to Merge
comment:The new diagram:
The diagram was updated based on these instructions: