Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Moving missed changes from 2023-11-01 packet capture swagger fix to l… #29473

Merged
merged 19 commits into from
Jun 21, 2024

Conversation

nikhilpadhye1
Copy link
Contributor

@nikhilpadhye1 nikhilpadhye1 commented Jun 17, 2024

…atest api version

ARM (Control Plane) API Specification Update Pull Request

This PR was approved in the private branch for api-version 2023-11-01 but was missed for the public api version. Adding the change to 2023-11-01 retroactively and this latest version. Need future APIs to have the correct bug fixed swagger, need this pr checked in here.
Following up with jeffery (previous breaking change ARM reviewer/approver) and vertika who is assigned the pr in the main repo linked below.

Retroactive pr to main 2023-11-01 api: #29451
Merged pr into the private repo: https://github.com/Azure/azure-rest-api-specs-pr/pull/17364/files

Tip

Overwhelmed by all this guidance? See the Getting help section at the bottom of this PR description.

PR review workflow diagram

Please understand this diagram before proceeding. It explains how to get your PR approved & merged.

spec_pr_review_workflow_diagram

Purpose of this PR

What's the purpose of this PR? Check the specific option that applies. This is mandatory!

  • New resource provider.
  • New API version for an existing resource provider. (If API spec is not defined in TypeSpec, the PR should have been created in adherence to OpenAPI specs PR creation guidance).
  • Update existing version for a new feature. (This is applicable only when you are revising a private preview API version.)
  • Update existing version to fix OpenAPI spec quality issues in S360.
  • Other, please clarify:
    • edit this with your clarification

Due diligence checklist

To merge this PR, you must go through the following checklist and confirm you understood
and followed the instructions by checking all the boxes:

  • I confirm this PR is modifying Azure Resource Manager (ARM) related specifications, and not data plane related specifications.
  • I have reviewed following Resource Provider guidelines, including
    ARM resource provider contract and
    REST guidelines (estimated time: 4 hours).
    I understand this is required before I can proceed to the diagram Step 2, "ARM API changes review", for this PR.

Additional information

Viewing API changes

For convenient view of the API changes made by this PR, refer to the URLs provided in the table
in the Generated ApiView comment added to this PR. You can use ApiView to show API versions diff.

Suppressing failures

If one or multiple validation error/warning suppression(s) is detected in your PR, please follow the
suppressions guide to get approval.

Getting help

  • First, please carefully read through this PR description, from top to bottom. Please fill out the Purpose of this PR and Due diligence checklist.
  • If you don't have permissions to remove or add labels to the PR, request write access per aka.ms/azsdk/access#request-access-to-rest-api-or-sdk-repositories
  • To understand what you must do next to merge this PR, see the Next Steps to Merge comment. It will appear within few minutes of submitting this PR and will continue to be up-to-date with current PR state.
  • For guidance on fixing this PR CI check failures, see the hyperlinks provided in given failure
    and https://aka.ms/ci-fix.
  • For help with ARM review (PR workflow diagram Step 2), see https://aka.ms/azsdk/pr-arm-review.
  • If the PR CI checks appear to be stuck in queued state, please add a comment with contents /azp run.
    This should result in a new comment denoting a PR validation pipeline has started and the checks should be updated after few minutes.
  • If the help provided by the previous points is not enough, post to https://aka.ms/azsdk/support/specreview-channel and link to this PR.

GuptaVertika and others added 13 commits April 16, 2024 18:31
Add examples for Subnet peering and v6 Subnet peering.
---------

Co-authored-by: saurabh83 <saugu@microsoft.com>
Co-authored-by: Abhishek Shah <shabhis@microsoft.com>
…gger to match the bugfix in 2023-11-01 (#29048)

Co-authored-by: Arsheen Khatib (from Dev Box) <akhatib@microsoft.com>
Added the property "NoHealthyBackendsBehavior" to the Probe properties.
…28760)

* Add parameters for cert based auth connection

* retrigger checks

* retrigger checks

* lintDiff

* Trigger Build

* revert PATCH changes

* fix

* change managed identity to v5

* add format and description
* added networkidentifier under vnet->subet->serviceendpoint
…tication. (#29357)

* Fix

* Fix2

---------

Co-authored-by: Khushboo Baheti <khbaheti@microsoft.com>
Copy link

openapi-pipeline-app bot commented Jun 17, 2024

Next Steps to Merge

✅ All automated merging requirements have been met! To get your PR merged, see aka.ms/azsdk/specreview/merge.

Copy link

openapi-pipeline-app bot commented Jun 17, 2024

Swagger Validation Report

️❌BreakingChange: 10 Errors, 2 Warnings failed [Detail]
Compared specs (v0.10.9) new version base version
azureFirewall.json 2024-01-01(6f7ccec) 2024-01-01(main)
Rule Message
1006 - RemovedDefinition The new version is missing a definition that was found in the old version. Was 'FirewallPacketCaptureParametersFormat' removed or renamed?
New: Microsoft.Network/stable/2024-01-01/azureFirewall.json#L510:3
Old: Microsoft.Network/stable/2024-01-01/azureFirewall.json#L510:3
1033 - RemovedProperty The new version is missing a property found in the old version. Was 'properties' renamed or removed?
New: Microsoft.Network/stable/2024-01-01/azureFirewall.json#L1222:7
Old: Microsoft.Network/stable/2024-01-01/azureFirewall.json#L1327:7
1033 - RemovedProperty The new version is missing a property found in the old version. Was 'id' renamed or removed?
New: Microsoft.Network/stable/2024-01-01/azureFirewall.json#L1222:7
Old: Microsoft.Network/stable/2024-01-01/azureFirewall.json#L1327:7
1045 - AddedOptionalProperty The new version has a new optional property 'durationInSeconds' that was not found in the old version.
New: Microsoft.Network/stable/2024-01-01/azureFirewall.json#L1222:7
Old: Microsoft.Network/stable/2024-01-01/azureFirewall.json#L1327:7
1045 - AddedOptionalProperty The new version has a new optional property 'numberOfPacketsToCapture' that was not found in the old version.
New: Microsoft.Network/stable/2024-01-01/azureFirewall.json#L1222:7
Old: Microsoft.Network/stable/2024-01-01/azureFirewall.json#L1327:7
1045 - AddedOptionalProperty The new version has a new optional property 'sasUrl' that was not found in the old version.
New: Microsoft.Network/stable/2024-01-01/azureFirewall.json#L1222:7
Old: Microsoft.Network/stable/2024-01-01/azureFirewall.json#L1327:7
1045 - AddedOptionalProperty The new version has a new optional property 'fileName' that was not found in the old version.
New: Microsoft.Network/stable/2024-01-01/azureFirewall.json#L1222:7
Old: Microsoft.Network/stable/2024-01-01/azureFirewall.json#L1327:7
1045 - AddedOptionalProperty The new version has a new optional property 'protocol' that was not found in the old version.
New: Microsoft.Network/stable/2024-01-01/azureFirewall.json#L1222:7
Old: Microsoft.Network/stable/2024-01-01/azureFirewall.json#L1327:7
1045 - AddedOptionalProperty The new version has a new optional property 'flags' that was not found in the old version.
New: Microsoft.Network/stable/2024-01-01/azureFirewall.json#L1222:7
Old: Microsoft.Network/stable/2024-01-01/azureFirewall.json#L1327:7
1045 - AddedOptionalProperty The new version has a new optional property 'filters' that was not found in the old version.
New: Microsoft.Network/stable/2024-01-01/azureFirewall.json#L1222:7
Old: Microsoft.Network/stable/2024-01-01/azureFirewall.json#L1327:7
⚠️ 1032 - DifferentAllOf The new version has a different 'allOf' property than the previous one.
New: Microsoft.Network/stable/2024-01-01/azureFirewall.json#L470:13
Old: Microsoft.Network/stable/2024-01-01/azureFirewall.json#L470:13
⚠️ 1032 - DifferentAllOf The new version has a different 'allOf' property than the previous one.
New: Microsoft.Network/stable/2024-01-01/azureFirewall.json#L1220:5
Old: Microsoft.Network/stable/2024-01-01/azureFirewall.json#L1325:5
️️✔️Breaking Change(Cross-Version) succeeded [Detail] [Expand]
There are no breaking changes.
️️✔️CredScan succeeded [Detail] [Expand]
There is no credential detected.
️⚠️LintDiff: 0 Warnings warning [Detail]
Compared specs (v2.2.2) new version base version
package-2024-01 package-2024-01(6f7ccec) package-2024-01(main)

The following errors/warnings exist before current PR submission:

Only 30 items are listed, please refer to log for more details.

Rule Message
ResourceNameRestriction The resource name parameter 'azureFirewallName' should be defined with a 'pattern' restriction.
Location: Microsoft.Network/stable/2024-01-01/azureFirewall.json#L37
DeleteResponseCodes Long-running delete operations must have responses with 202, 204 and default return codes. They also must have no other response codes.
Location: Microsoft.Network/stable/2024-01-01/azureFirewall.json#L38
LroLocationHeader A 202 response should include an Location response header.
Location: Microsoft.Network/stable/2024-01-01/azureFirewall.json#L67
LroLocationHeader A 202 response should include an Location response header.
Location: Microsoft.Network/stable/2024-01-01/azureFirewall.json#L275
ResourceNameRestriction The resource name parameter 'azureFirewallName' should be defined with a 'pattern' restriction.
Location: Microsoft.Network/stable/2024-01-01/azureFirewall.json#L387
LroLocationHeader A 202 response should include an Location response header.
Location: Microsoft.Network/stable/2024-01-01/azureFirewall.json#L420
MissingTypeObject The schema 'AzureFirewallIPConfigurationPropertiesFormat' is considered an object but without a 'type:object', please add the missing 'type:object'.
Location: Microsoft.Network/stable/2024-01-01/azureFirewall.json#L511
MissingTypeObject The schema 'AzureFirewallIPConfiguration' is considered an object but without a 'type:object', please add the missing 'type:object'.
Location: Microsoft.Network/stable/2024-01-01/azureFirewall.json#L534
MissingTypeObject The schema 'AzureFirewallPublicIPAddress' is considered an object but without a 'type:object', please add the missing 'type:object'.
Location: Microsoft.Network/stable/2024-01-01/azureFirewall.json#L563
MissingTypeObject The schema 'AzureFirewallIpGroups' is considered an object but without a 'type:object', please add the missing 'type:object'.
Location: Microsoft.Network/stable/2024-01-01/azureFirewall.json#L572
MissingTypeObject The schema 'HubPublicIPAddresses' is considered an object but without a 'type:object', please add the missing 'type:object'.
Location: Microsoft.Network/stable/2024-01-01/azureFirewall.json#L587
MissingTypeObject The schema 'HubIPAddresses' is considered an object but without a 'type:object', please add the missing 'type:object'.
Location: Microsoft.Network/stable/2024-01-01/azureFirewall.json#L604
MissingTypeObject The schema 'AzureFirewallPropertiesFormat' is considered an object but without a 'type:object', please add the missing 'type:object'.
Location: Microsoft.Network/stable/2024-01-01/azureFirewall.json#L624
AvoidAdditionalProperties Definitions must not have properties named additionalProperties except for user defined tags or predefined references.
Location: Microsoft.Network/stable/2024-01-01/azureFirewall.json#L625
MissingTypeObject The schema 'AzureFirewall' is considered an object but without a 'type:object', please add the missing 'type:object'.
Location: Microsoft.Network/stable/2024-01-01/azureFirewall.json#L695
MissingTypeObject The schema 'AzureFirewallListResult' is considered an object but without a 'type:object', please add the missing 'type:object'.
Location: Microsoft.Network/stable/2024-01-01/azureFirewall.json#L722
AvoidAdditionalProperties Definitions must not have properties named additionalProperties except for user defined tags or predefined references.
Location: Microsoft.Network/stable/2024-01-01/azureFirewall.json#L751
MissingTypeObject The schema 'AzureFirewallApplicationRuleCollectionPropertiesFormat' is considered an object but without a 'type:object', please add the missing 'type:object'.
Location: Microsoft.Network/stable/2024-01-01/azureFirewall.json#L758
MissingTypeObject The schema 'AzureFirewallApplicationRuleCollection' is considered an object but without a 'type:object', please add the missing 'type:object'.
Location: Microsoft.Network/stable/2024-01-01/azureFirewall.json#L788
MissingTypeObject The schema 'AzureFirewallApplicationRuleProtocol' is considered an object but without a 'type:object', please add the missing 'type:object'.
Location: Microsoft.Network/stable/2024-01-01/azureFirewall.json#L812
MissingTypeObject The schema 'AzureFirewallApplicationRule' is considered an object but without a 'type:object', please add the missing 'type:object'.
Location: Microsoft.Network/stable/2024-01-01/azureFirewall.json#L830
MissingTypeObject The schema 'AzureFirewallNatRuleCollectionProperties' is considered an object but without a 'type:object', please add the missing 'type:object'.
Location: Microsoft.Network/stable/2024-01-01/azureFirewall.json#L878
MissingTypeObject The schema 'AzureFirewallNatRuleCollection' is considered an object but without a 'type:object', please add the missing 'type:object'.
Location: Microsoft.Network/stable/2024-01-01/azureFirewall.json#L908
MissingTypeObject The schema 'AzureFirewallNatRule' is considered an object but without a 'type:object', please add the missing 'type:object'.
Location: Microsoft.Network/stable/2024-01-01/azureFirewall.json#L932
MissingTypeObject The schema 'AzureFirewallNatRCAction' is considered an object but without a 'type:object', please add the missing 'type:object'.
Location: Microsoft.Network/stable/2024-01-01/azureFirewall.json#L992
MissingTypeObject The schema 'AzureFirewallNetworkRuleCollectionPropertiesFormat' is considered an object but without a 'type:object', please add the missing 'type:object'.
Location: Microsoft.Network/stable/2024-01-01/azureFirewall.json#L1013
MissingTypeObject The schema 'AzureFirewallNetworkRuleCollection' is considered an object but without a 'type:object', please add the missing 'type:object'.
Location: Microsoft.Network/stable/2024-01-01/azureFirewall.json#L1043
MissingTypeObject The schema 'AzureFirewallNetworkRule' is considered an object but without a 'type:object', please add the missing 'type:object'.
Location: Microsoft.Network/stable/2024-01-01/azureFirewall.json#L1067
MissingTypeObject The schema 'AzureFirewallRCAction' is considered an object but without a 'type:object', please add the missing 'type:object'.
Location: Microsoft.Network/stable/2024-01-01/azureFirewall.json#L1129
MissingTypeObject The schema 'AzureFirewallSku' is considered an object but without a 'type:object', please add the missing 'type:object'.
Location: Microsoft.Network/stable/2024-01-01/azureFirewall.json#L1177
️️✔️Avocado succeeded [Detail] [Expand]
Validation passes for Avocado.
️️✔️SwaggerAPIView succeeded [Detail] [Expand]
️️✔️TypeSpecAPIView succeeded [Detail] [Expand]
️❌ModelValidation: 108 Errors, 0 Warnings failed [Detail]

Only 30 items are listed, please refer to log for more details.

Rule Message
LRO_RESPONSE_HEADER Long running operation should return location or azure-AsyncOperation in header but not provided
Url: Microsoft.Network/stable/2024-01-01/azureFirewall.json#L66:22
ExampleUrl: stable/2024-01-01/examples/AzureFirewallDelete.json
MISSING_RESOURCE_ID id is required to return in response of GET/PUT resource calls but not being provided
Url: Microsoft.Network/stable/2024-01-01/azureFirewall.json#L788:47
ExampleUrl: stable/2024-01-01/examples/AzureFirewallGet.json#L45:13
MISSING_RESOURCE_ID id is required to return in response of GET/PUT resource calls but not being provided
Url: Microsoft.Network/stable/2024-01-01/azureFirewall.json#L908:39
ExampleUrl: stable/2024-01-01/examples/AzureFirewallGet.json#L75:13
MISSING_RESOURCE_ID id is required to return in response of GET/PUT resource calls but not being provided
Url: Microsoft.Network/stable/2024-01-01/azureFirewall.json#L1043:43
ExampleUrl: stable/2024-01-01/examples/AzureFirewallGet.json#L124:13
MISSING_RESOURCE_ID id is required to return in response of GET/PUT resource calls but not being provided
Url: Microsoft.Network/stable/2024-01-01/azureFirewall.json#L788:47
ExampleUrl: stable/2024-01-01/examples/AzureFirewallGetWithZones.json#L49:13
MISSING_RESOURCE_ID id is required to return in response of GET/PUT resource calls but not being provided
Url: Microsoft.Network/stable/2024-01-01/azureFirewall.json#L908:39
ExampleUrl: stable/2024-01-01/examples/AzureFirewallGetWithZones.json#L79:13
MISSING_RESOURCE_ID id is required to return in response of GET/PUT resource calls but not being provided
Url: Microsoft.Network/stable/2024-01-01/azureFirewall.json#L1043:43
ExampleUrl: stable/2024-01-01/examples/AzureFirewallGetWithZones.json#L128:13
MISSING_RESOURCE_ID id is required to return in response of GET/PUT resource calls but not being provided
Url: Microsoft.Network/stable/2024-01-01/azureFirewall.json#L788:47
ExampleUrl: stable/2024-01-01/examples/AzureFirewallGetWithMgmtSubnet.json#L59:13
MISSING_RESOURCE_ID id is required to return in response of GET/PUT resource calls but not being provided
Url: Microsoft.Network/stable/2024-01-01/azureFirewall.json#L908:39
ExampleUrl: stable/2024-01-01/examples/AzureFirewallGetWithMgmtSubnet.json#L89:13
MISSING_RESOURCE_ID id is required to return in response of GET/PUT resource calls but not being provided
Url: Microsoft.Network/stable/2024-01-01/azureFirewall.json#L1043:43
ExampleUrl: stable/2024-01-01/examples/AzureFirewallGetWithMgmtSubnet.json#L138:13
MISSING_RESOURCE_ID id is required to return in response of GET/PUT resource calls but not being provided
Url: Microsoft.Network/stable/2024-01-01/azureFirewall.json#L788:47
ExampleUrl: stable/2024-01-01/examples/AzureFirewallGetWithAdditionalProperties.json#L45:13
MISSING_RESOURCE_ID id is required to return in response of GET/PUT resource calls but not being provided
Url: Microsoft.Network/stable/2024-01-01/azureFirewall.json#L908:39
ExampleUrl: stable/2024-01-01/examples/AzureFirewallGetWithAdditionalProperties.json#L75:13
MISSING_RESOURCE_ID id is required to return in response of GET/PUT resource calls but not being provided
Url: Microsoft.Network/stable/2024-01-01/azureFirewall.json#L1043:43
ExampleUrl: stable/2024-01-01/examples/AzureFirewallGetWithAdditionalProperties.json#L124:13
MISSING_RESOURCE_ID id is required to return in response of GET/PUT resource calls but not being provided
Url: Microsoft.Network/stable/2024-01-01/azureFirewall.json#L788:47
ExampleUrl: stable/2024-01-01/examples/AzureFirewallGetWithIpGroups.json#L45:13
MISSING_RESOURCE_ID id is required to return in response of GET/PUT resource calls but not being provided
Url: Microsoft.Network/stable/2024-01-01/azureFirewall.json#L908:39
ExampleUrl: stable/2024-01-01/examples/AzureFirewallGetWithIpGroups.json#L74:13
MISSING_RESOURCE_ID id is required to return in response of GET/PUT resource calls but not being provided
Url: Microsoft.Network/stable/2024-01-01/azureFirewall.json#L1043:43
ExampleUrl: stable/2024-01-01/examples/AzureFirewallGetWithIpGroups.json#L123:13
MISSING_RESOURCE_ID id is required to return in response of GET/PUT resource calls but not being provided
Url: Microsoft.Network/stable/2024-01-01/azureFirewall.json#L788:47
ExampleUrl: stable/2024-01-01/examples/AzureFirewallPut.json#L199:13
MISSING_RESOURCE_ID id is required to return in response of GET/PUT resource calls but not being provided
Url: Microsoft.Network/stable/2024-01-01/azureFirewall.json#L908:39
ExampleUrl: stable/2024-01-01/examples/AzureFirewallPut.json#L229:13
MISSING_RESOURCE_ID id is required to return in response of GET/PUT resource calls but not being provided
Url: Microsoft.Network/stable/2024-01-01/azureFirewall.json#L1043:43
ExampleUrl: stable/2024-01-01/examples/AzureFirewallPut.json#L278:13
MISSING_RESOURCE_ID id is required to return in response of GET/PUT resource calls but not being provided
Url: Microsoft.Network/stable/2024-01-01/azureFirewall.json#L788:47
ExampleUrl: stable/2024-01-01/examples/AzureFirewallPut.json#L366:13
MISSING_RESOURCE_ID id is required to return in response of GET/PUT resource calls but not being provided
Url: Microsoft.Network/stable/2024-01-01/azureFirewall.json#L908:39
ExampleUrl: stable/2024-01-01/examples/AzureFirewallPut.json#L396:13
MISSING_RESOURCE_ID id is required to return in response of GET/PUT resource calls but not being provided
Url: Microsoft.Network/stable/2024-01-01/azureFirewall.json#L1043:43
ExampleUrl: stable/2024-01-01/examples/AzureFirewallPut.json#L445:13
MISSING_RESOURCE_ID id is required to return in response of GET/PUT resource calls but not being provided
Url: Microsoft.Network/stable/2024-01-01/azureFirewall.json#L788:47
ExampleUrl: stable/2024-01-01/examples/AzureFirewallPutWithZones.json#L207:13
MISSING_RESOURCE_ID id is required to return in response of GET/PUT resource calls but not being provided
Url: Microsoft.Network/stable/2024-01-01/azureFirewall.json#L908:39
ExampleUrl: stable/2024-01-01/examples/AzureFirewallPutWithZones.json#L237:13
MISSING_RESOURCE_ID id is required to return in response of GET/PUT resource calls but not being provided
Url: Microsoft.Network/stable/2024-01-01/azureFirewall.json#L1043:43
ExampleUrl: stable/2024-01-01/examples/AzureFirewallPutWithZones.json#L286:13
MISSING_RESOURCE_ID id is required to return in response of GET/PUT resource calls but not being provided
Url: Microsoft.Network/stable/2024-01-01/azureFirewall.json#L788:47
ExampleUrl: stable/2024-01-01/examples/AzureFirewallPutWithZones.json#L378:13
MISSING_RESOURCE_ID id is required to return in response of GET/PUT resource calls but not being provided
Url: Microsoft.Network/stable/2024-01-01/azureFirewall.json#L908:39
ExampleUrl: stable/2024-01-01/examples/AzureFirewallPutWithZones.json#L408:13
MISSING_RESOURCE_ID id is required to return in response of GET/PUT resource calls but not being provided
Url: Microsoft.Network/stable/2024-01-01/azureFirewall.json#L1043:43
ExampleUrl: stable/2024-01-01/examples/AzureFirewallPutWithZones.json#L457:13
MISSING_RESOURCE_ID id is required to return in response of GET/PUT resource calls but not being provided
Url: Microsoft.Network/stable/2024-01-01/azureFirewall.json#L788:47
ExampleUrl: stable/2024-01-01/examples/AzureFirewallPutWithMgmtSubnet.json#L210:13
MISSING_RESOURCE_ID id is required to return in response of GET/PUT resource calls but not being provided
Url: Microsoft.Network/stable/2024-01-01/azureFirewall.json#L908:39
ExampleUrl: stable/2024-01-01/examples/AzureFirewallPutWithMgmtSubnet.json#L240:13
️️✔️SemanticValidation succeeded [Detail] [Expand]
Validation passes for SemanticValidation.
️️✔️PoliCheck succeeded [Detail] [Expand]
Validation passed for PoliCheck.
️️✔️SpellCheck succeeded [Detail] [Expand]
Validation passes for SpellCheck.
️️✔️Lint(RPaaS) succeeded [Detail] [Expand]
Validation passes for Lint(RPaaS).
️️✔️PR Summary succeeded [Detail] [Expand]
Validation passes for Summary.
️️✔️Automated merging requirements met succeeded [Detail] [Expand]
Posted by Swagger Pipeline | How to fix these errors?

Copy link

openapi-pipeline-app bot commented Jun 17, 2024

Swagger Generation Artifacts

️❌ApiDocPreview: 1 Errors, 0 Warnings failed [Detail]
Rule Message
RestBuild error "logUrl":"https://apidrop.visualstudio.com/Content%20CI/_build/results?buildId=435610&view=logs&j=fd490c07-0b22-5182-fac9-6d67fe1e939b",
"detail":"Run.ps1 failed with exit code 1 "
️❌ azure-sdk-for-net failed [Detail]
    For more instructions, please refer to the FAQ .
  • Code Generator Failed in generating from 79cfbcac74af39d8c93c26b8f171b51f8b384137. SDK Automation 14.0.0
    command	pwsh ./eng/scripts/Automation-Sdk-Init.ps1 ../azure-sdk-for-net_tmp/initInput.json ../azure-sdk-for-net_tmp/initOutput.json
    command	autorest --version=2.0.4421 --csharp --reflect-api-versions --license-header=MICROSOFT_MIT_NO_VERSION --use=@microsoft.azure/autorest.csharp@2.3.101 --csharp-sdks-folder=/mnt/vss/_work/1/s/azure-sdk-for-net/sdk ../azure-rest-api-specs/specification/network/resource-manager/readme.md
    cmderr	[Autorest] realpath(): Permission denied
    cmderr	[Autorest] realpath(): Permission denied
    cmderr	[Autorest] realpath(): Permission denied
  • Microsoft.Azure.Management.Network [Preview SDK Changes]
    cmdout	[msbuild]      2>/mnt/vss/_work/1/s/azure-sdk-for-net/sdk/network/Microsoft.Azure.Management.Network/src/Generated/Models/VirtualNetworkTap.cs(148,60): error CS1061: 'NetworkInterfaceIPConfiguration' does not contain a definition for 'Validate' and no accessible extension method 'Validate' accepting a first argument of type 'NetworkInterfaceIPConfiguration' could be found (are you missing a using directive or an assembly reference?) [/mnt/vss/_work/1/s/azure-sdk-for-net/sdk/network/Microsoft.Azure.Management.Network/src/Microsoft.Azure.Management.Network.csproj::TargetFramework=netstandard1.4]
    cmdout	[msbuild]      2>/mnt/vss/_work/1/s/azure-sdk-for-net/sdk/network/Microsoft.Azure.Management.Network/src/Generated/Models/InboundNatRule.cs(238,40): error CS1061: 'NetworkInterfaceIPConfiguration' does not contain a definition for 'Validate' and no accessible extension method 'Validate' accepting a first argument of type 'NetworkInterfaceIPConfiguration' could be found (are you missing a using directive or an assembly reference?) [/mnt/vss/_work/1/s/azure-sdk-for-net/sdk/network/Microsoft.Azure.Management.Network/src/Microsoft.Azure.Management.Network.csproj::TargetFramework=netstandard1.4]
    cmdout	[msbuild]      2>/mnt/vss/_work/1/s/azure-sdk-for-net/sdk/network/Microsoft.Azure.Management.Network/src/Generated/Models/ApplicationGatewayBackendHealthServer.cs(89,33): error CS1061: 'NetworkInterfaceIPConfiguration' does not contain a definition for 'Validate' and no accessible extension method 'Validate' accepting a first argument of type 'NetworkInterfaceIPConfiguration' could be found (are you missing a using directive or an assembly reference?) [/mnt/vss/_work/1/s/azure-sdk-for-net/sdk/network/Microsoft.Azure.Management.Network/src/Microsoft.Azure.Management.Network.csproj::TargetFramework=netstandard1.4]
    cmdout	[msbuild]      2>/mnt/vss/_work/1/s/azure-sdk-for-net/sdk/network/Microsoft.Azure.Management.Network/src/Generated/Models/VirtualNetworkTap.cs(148,60): error CS1061: 'NetworkInterfaceIPConfiguration' does not contain a definition for 'Validate' and no accessible extension method 'Validate' accepting a first argument of type 'NetworkInterfaceIPConfiguration' could be found (are you missing a using directive or an assembly reference?) [/mnt/vss/_work/1/s/azure-sdk-for-net/sdk/network/Microsoft.Azure.Management.Network/src/Microsoft.Azure.Management.Network.csproj::TargetFramework=netstandard2.0]
    cmdout	[msbuild]      2>/mnt/vss/_work/1/s/azure-sdk-for-net/sdk/network/Microsoft.Azure.Management.Network/src/Generated/Models/InboundNatRule.cs(238,40): error CS1061: 'NetworkInterfaceIPConfiguration' does not contain a definition for 'Validate' and no accessible extension method 'Validate' accepting a first argument of type 'NetworkInterfaceIPConfiguration' could be found (are you missing a using directive or an assembly reference?) [/mnt/vss/_work/1/s/azure-sdk-for-net/sdk/network/Microsoft.Azure.Management.Network/src/Microsoft.Azure.Management.Network.csproj::TargetFramework=netstandard2.0]
    cmdout	[msbuild]      2>/mnt/vss/_work/1/s/azure-sdk-for-net/sdk/network/Microsoft.Azure.Management.Network/src/Generated/Models/ApplicationGatewayBackendHealthServer.cs(89,33): error CS1061: 'NetworkInterfaceIPConfiguration' does not contain a definition for 'Validate' and no accessible extension method 'Validate' accepting a first argument of type 'NetworkInterfaceIPConfiguration' could be found (are you missing a using directive or an assembly reference?) [/mnt/vss/_work/1/s/azure-sdk-for-net/sdk/network/Microsoft.Azure.Management.Network/src/Microsoft.Azure.Management.Network.csproj::TargetFramework=netstandard2.0]
    cmdout	[msbuild]      2>/mnt/vss/_work/1/s/azure-sdk-for-net/sdk/network/Microsoft.Azure.Management.Network/src/Generated/Models/VirtualNetworkTap.cs(148,60): error CS1061: 'NetworkInterfaceIPConfiguration' does not contain a definition for 'Validate' and no accessible extension method 'Validate' accepting a first argument of type 'NetworkInterfaceIPConfiguration' could be found (are you missing a using directive or an assembly reference?) [/mnt/vss/_work/1/s/azure-sdk-for-net/sdk/network/Microsoft.Azure.Management.Network/src/Microsoft.Azure.Management.Network.csproj::TargetFramework=net452]
    cmdout	[msbuild]      2>/mnt/vss/_work/1/s/azure-sdk-for-net/sdk/network/Microsoft.Azure.Management.Network/src/Generated/Models/InboundNatRule.cs(238,40): error CS1061: 'NetworkInterfaceIPConfiguration' does not contain a definition for 'Validate' and no accessible extension method 'Validate' accepting a first argument of type 'NetworkInterfaceIPConfiguration' could be found (are you missing a using directive or an assembly reference?) [/mnt/vss/_work/1/s/azure-sdk-for-net/sdk/network/Microsoft.Azure.Management.Network/src/Microsoft.Azure.Management.Network.csproj::TargetFramework=net452]
    cmdout	[msbuild]      2>/mnt/vss/_work/1/s/azure-sdk-for-net/sdk/network/Microsoft.Azure.Management.Network/src/Generated/Models/ApplicationGatewayBackendHealthServer.cs(89,33): error CS1061: 'NetworkInterfaceIPConfiguration' does not contain a definition for 'Validate' and no accessible extension method 'Validate' accepting a first argument of type 'NetworkInterfaceIPConfiguration' could be found (are you missing a using directive or an assembly reference?) [/mnt/vss/_work/1/s/azure-sdk-for-net/sdk/network/Microsoft.Azure.Management.Network/src/Microsoft.Azure.Management.Network.csproj::TargetFramework=net452]
    cmdout	[msbuild]          /mnt/vss/_work/1/s/azure-sdk-for-net/sdk/network/Microsoft.Azure.Management.Network/src/Generated/Models/VirtualNetworkTap.cs(148,60): error CS1061: 'NetworkInterfaceIPConfiguration' does not contain a definition for 'Validate' and no accessible extension method 'Validate' accepting a first argument of type 'NetworkInterfaceIPConfiguration' could be found (are you missing a using directive or an assembly reference?) [/mnt/vss/_work/1/s/azure-sdk-for-net/sdk/network/Microsoft.Azure.Management.Network/src/Microsoft.Azure.Management.Network.csproj::TargetFramework=netstandard1.4]
    cmdout	[msbuild]          /mnt/vss/_work/1/s/azure-sdk-for-net/sdk/network/Microsoft.Azure.Management.Network/src/Generated/Models/InboundNatRule.cs(238,40): error CS1061: 'NetworkInterfaceIPConfiguration' does not contain a definition for 'Validate' and no accessible extension method 'Validate' accepting a first argument of type 'NetworkInterfaceIPConfiguration' could be found (are you missing a using directive or an assembly reference?) [/mnt/vss/_work/1/s/azure-sdk-for-net/sdk/network/Microsoft.Azure.Management.Network/src/Microsoft.Azure.Management.Network.csproj::TargetFramework=netstandard1.4]
    cmdout	[msbuild]          /mnt/vss/_work/1/s/azure-sdk-for-net/sdk/network/Microsoft.Azure.Management.Network/src/Generated/Models/ApplicationGatewayBackendHealthServer.cs(89,33): error CS1061: 'NetworkInterfaceIPConfiguration' does not contain a definition for 'Validate' and no accessible extension method 'Validate' accepting a first argument of type 'NetworkInterfaceIPConfiguration' could be found (are you missing a using directive or an assembly reference?) [/mnt/vss/_work/1/s/azure-sdk-for-net/sdk/network/Microsoft.Azure.Management.Network/src/Microsoft.Azure.Management.Network.csproj::TargetFramework=netstandard1.4]
    cmdout	[msbuild]          /mnt/vss/_work/1/s/azure-sdk-for-net/sdk/network/Microsoft.Azure.Management.Network/src/Generated/Models/VirtualNetworkTap.cs(148,60): error CS1061: 'NetworkInterfaceIPConfiguration' does not contain a definition for 'Validate' and no accessible extension method 'Validate' accepting a first argument of type 'NetworkInterfaceIPConfiguration' could be found (are you missing a using directive or an assembly reference?) [/mnt/vss/_work/1/s/azure-sdk-for-net/sdk/network/Microsoft.Azure.Management.Network/src/Microsoft.Azure.Management.Network.csproj::TargetFramework=netstandard2.0]
    cmdout	[msbuild]          /mnt/vss/_work/1/s/azure-sdk-for-net/sdk/network/Microsoft.Azure.Management.Network/src/Generated/Models/InboundNatRule.cs(238,40): error CS1061: 'NetworkInterfaceIPConfiguration' does not contain a definition for 'Validate' and no accessible extension method 'Validate' accepting a first argument of type 'NetworkInterfaceIPConfiguration' could be found (are you missing a using directive or an assembly reference?) [/mnt/vss/_work/1/s/azure-sdk-for-net/sdk/network/Microsoft.Azure.Management.Network/src/Microsoft.Azure.Management.Network.csproj::TargetFramework=netstandard2.0]
    cmdout	[msbuild]          /mnt/vss/_work/1/s/azure-sdk-for-net/sdk/network/Microsoft.Azure.Management.Network/src/Generated/Models/ApplicationGatewayBackendHealthServer.cs(89,33): error CS1061: 'NetworkInterfaceIPConfiguration' does not contain a definition for 'Validate' and no accessible extension method 'Validate' accepting a first argument of type 'NetworkInterfaceIPConfiguration' could be found (are you missing a using directive or an assembly reference?) [/mnt/vss/_work/1/s/azure-sdk-for-net/sdk/network/Microsoft.Azure.Management.Network/src/Microsoft.Azure.Management.Network.csproj::TargetFramework=netstandard2.0]
    cmdout	[msbuild]          /mnt/vss/_work/1/s/azure-sdk-for-net/sdk/network/Microsoft.Azure.Management.Network/src/Generated/Models/VirtualNetworkTap.cs(148,60): error CS1061: 'NetworkInterfaceIPConfiguration' does not contain a definition for 'Validate' and no accessible extension method 'Validate' accepting a first argument of type 'NetworkInterfaceIPConfiguration' could be found (are you missing a using directive or an assembly reference?) [/mnt/vss/_work/1/s/azure-sdk-for-net/sdk/network/Microsoft.Azure.Management.Network/src/Microsoft.Azure.Management.Network.csproj::TargetFramework=net452]
    cmdout	[msbuild]          /mnt/vss/_work/1/s/azure-sdk-for-net/sdk/network/Microsoft.Azure.Management.Network/src/Generated/Models/InboundNatRule.cs(238,40): error CS1061: 'NetworkInterfaceIPConfiguration' does not contain a definition for 'Validate' and no accessible extension method 'Validate' accepting a first argument of type 'NetworkInterfaceIPConfiguration' could be found (are you missing a using directive or an assembly reference?) [/mnt/vss/_work/1/s/azure-sdk-for-net/sdk/network/Microsoft.Azure.Management.Network/src/Microsoft.Azure.Management.Network.csproj::TargetFramework=net452]
    cmdout	[msbuild]          /mnt/vss/_work/1/s/azure-sdk-for-net/sdk/network/Microsoft.Azure.Management.Network/src/Generated/Models/ApplicationGatewayBackendHealthServer.cs(89,33): error CS1061: 'NetworkInterfaceIPConfiguration' does not contain a definition for 'Validate' and no accessible extension method 'Validate' accepting a first argument of type 'NetworkInterfaceIPConfiguration' could be found (are you missing a using directive or an assembly reference?) [/mnt/vss/_work/1/s/azure-sdk-for-net/sdk/network/Microsoft.Azure.Management.Network/src/Microsoft.Azure.Management.Network.csproj::TargetFramework=net452]
    error	Script return with result [failed] code [1] signal [null] cwd [azure-sdk-for-net]: dotnet
️⚠️ azure-sdk-for-net-track2 warning [Detail]
    For more instructions, please refer to the FAQ .
  • ⚠️Warning in generating from 79cfbcac74af39d8c93c26b8f171b51f8b384137. SDK Automation 14.0.0
    command	pwsh ./eng/scripts/Automation-Sdk-Init.ps1 ../azure-sdk-for-net_tmp/initInput.json ../azure-sdk-for-net_tmp/initOutput.json
    command	pwsh ./eng/scripts/Invoke-GenerateAndBuildV2.ps1 ../azure-sdk-for-net_tmp/generateInput.json ../azure-sdk-for-net_tmp/generateOutput.json
    cmderr	[Invoke-GenerateAndBuildV2.ps1] Get-ChildItem: /mnt/vss/_work/1/s/azure-sdk-for-net/eng/scripts/automation/GenerateAndBuildLib.ps1:807
    cmderr	[Invoke-GenerateAndBuildV2.ps1] Line |
    cmderr	[Invoke-GenerateAndBuildV2.ps1]  807 |  … rtifacts += Get-ChildItem $artifactsPath -Filter *.nupkg -exclude *.s …
    cmderr	[Invoke-GenerateAndBuildV2.ps1]      |                ~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
    cmderr	[Invoke-GenerateAndBuildV2.ps1]      | Cannot find path
    cmderr	[Invoke-GenerateAndBuildV2.ps1]      | '/mnt/vss/_work/1/s/azure-sdk-for-net/artifacts/packages/Debug/' because
    cmderr	[Invoke-GenerateAndBuildV2.ps1]      | it does not exist.
    cmderr	[Invoke-GenerateAndBuildV2.ps1] GeneratePackage: /mnt/vss/_work/1/s/azure-sdk-for-net/eng/scripts/automation/GenerateAndBuildLib.ps1:714
    cmderr	[Invoke-GenerateAndBuildV2.ps1] Line |
    cmderr	[Invoke-GenerateAndBuildV2.ps1]  714 |          GeneratePackage -projectFolder $projectFolder -sdkRootPath $s …
    cmderr	[Invoke-GenerateAndBuildV2.ps1]      |          ~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
    cmderr	[Invoke-GenerateAndBuildV2.ps1]      | Failed to generate sdk artifact
  • ️✔️Azure.ResourceManager.Network [Preview SDK Changes] Breaking Change Detected
    info	[Changelog] Breaking Changes: /home/cloudtest/.nuget/packages/microsoft.dotnet.apicompat/5.0.0-beta.20467.1/build/Microsoft.DotNet.ApiCompat.targets(82,5): error : MembersMustExist : Member 'public Azure.ResourceManager.ArmOperation<Azure.ResourceManager.Network.Models.InboundSecurityRule> Azure.ResourceManager.Network.NetworkVirtualApplianceResource.CreateOrUpdateInboundSecurityRule(Azure.WaitUntil, System.String, Azure.ResourceManager.Network.Models.InboundSecurityRule, System.Threading.CancellationToken)' does not exist in the implementation but it does exist in the contract. [/mnt/vss/_work/1/s/azure-sdk-for-net/sdk/network/Azure.ResourceManager.Network/src/Azure.ResourceManager.Network.csproj::TargetFramework=netstandard2.0],
    info	[Changelog] /home/cloudtest/.nuget/packages/microsoft.dotnet.apicompat/5.0.0-beta.20467.1/build/Microsoft.DotNet.ApiCompat.targets(82,5): error : MembersMustExist : Member 'public System.Threading.Tasks.Task<Azure.ResourceManager.ArmOperation<Azure.ResourceManager.Network.Models.InboundSecurityRule>> Azure.ResourceManager.Network.NetworkVirtualApplianceResource.CreateOrUpdateInboundSecurityRuleAsync(Azure.WaitUntil, System.String, Azure.ResourceManager.Network.Models.InboundSecurityRule, System.Threading.CancellationToken)' does not exist in the implementation but it does exist in the contract. [/mnt/vss/_work/1/s/azure-sdk-for-net/sdk/network/Azure.ResourceManager.Network/src/Azure.ResourceManager.Network.csproj::TargetFramework=netstandard2.0],
    info	[Changelog] /home/cloudtest/.nuget/packages/microsoft.dotnet.apicompat/5.0.0-beta.20467.1/build/Microsoft.DotNet.ApiCompat.targets(82,5): error : MembersMustExist : Member 'public Azure.Pageable<Azure.ResourceManager.Network.ExpressRouteCrossConnectionResource> Azure.ResourceManager.Network.Mocking.MockableNetworkSubscriptionResource.GetExpressRouteCrossConnections(System.Threading.CancellationToken)' does not exist in the implementation but it does exist in the contract. [/mnt/vss/_work/1/s/azure-sdk-for-net/sdk/network/Azure.ResourceManager.Network/src/Azure.ResourceManager.Network.csproj::TargetFramework=netstandard2.0],
    info	[Changelog] /home/cloudtest/.nuget/packages/microsoft.dotnet.apicompat/5.0.0-beta.20467.1/build/Microsoft.DotNet.ApiCompat.targets(82,5): error : MembersMustExist : Member 'public Azure.AsyncPageable<Azure.ResourceManager.Network.ExpressRouteCrossConnectionResource> Azure.ResourceManager.Network.Mocking.MockableNetworkSubscriptionResource.GetExpressRouteCrossConnectionsAsync(System.Threading.CancellationToken)' does not exist in the implementation but it does exist in the contract. [/mnt/vss/_work/1/s/azure-sdk-for-net/sdk/network/Azure.ResourceManager.Network/src/Azure.ResourceManager.Network.csproj::TargetFramework=netstandard2.0],
    info	[Changelog] /home/cloudtest/.nuget/packages/microsoft.dotnet.apicompat/5.0.0-beta.20467.1/build/Microsoft.DotNet.ApiCompat.targets(82,5): error : MembersMustExist : Member 'public Azure.ResourceManager.Network.Models.InboundSecurityRule Azure.ResourceManager.Network.Models.ArmNetworkModelFactory.InboundSecurityRule(Azure.Core.ResourceIdentifier, System.String, System.Nullable<Azure.Core.ResourceType>, System.Nullable<Azure.ETag>, System.Collections.Generic.IEnumerable<Azure.ResourceManager.Network.Models.InboundSecurityRules>, System.Nullable<Azure.ResourceManager.Network.Models.NetworkProvisioningState>)' does not exist in the implementation but it does exist in the contract. [/mnt/vss/_work/1/s/azure-sdk-for-net/sdk/network/Azure.ResourceManager.Network/src/Azure.ResourceManager.Network.csproj::TargetFramework=netstandard2.0],
    info	[Changelog] /home/cloudtest/.nuget/packages/microsoft.dotnet.apicompat/5.0.0-beta.20467.1/build/Microsoft.DotNet.ApiCompat.targets(82,5): error : CannotRemoveBaseTypeOrInterface : Type 'Azure.ResourceManager.Network.Models.FirewallPacketCaptureContent' does not inherit from base type 'Azure.ResourceManager.Network.Models.NetworkSubResource' in the implementation but it does in the contract. [/mnt/vss/_work/1/s/azure-sdk-for-net/sdk/network/Azure.ResourceManager.Network/src/Azure.ResourceManager.Network.csproj::TargetFramework=netstandard2.0],
    info	[Changelog] /home/cloudtest/.nuget/packages/microsoft.dotnet.apicompat/5.0.0-beta.20467.1/build/Microsoft.DotNet.ApiCompat.targets(82,5): error : TypesMustExist : Type 'Azure.ResourceManager.Network.Models.InboundSecurityRule' does not exist in the implementation but it does exist in the contract. [/mnt/vss/_work/1/s/azure-sdk-for-net/sdk/network/Azure.ResourceManager.Network/src/Azure.ResourceManager.Network.csproj::TargetFramework=netstandard2.0],
    info	[Changelog] /home/cloudtest/.nuget/packages/microsoft.dotnet.apicompat/5.0.0-beta.20467.1/build/Microsoft.DotNet.ApiCompat.targets(96,5): error : ApiCompat failed for '/mnt/vss/_work/1/s/azure-sdk-for-net/artifacts/bin/Azure.ResourceManager.Network/Debug/netstandard2.0/Azure.ResourceManager.Network.dll' [/mnt/vss/_work/1/s/azure-sdk-for-net/sdk/network/Azure.ResourceManager.Network/src/Azure.ResourceManager.Network.csproj::TargetFramework=netstandard2.0]
    Please refer to the guidance for suppressing SDK breaking changes.
️🔄 azure-sdk-for-python inProgress [Detail]
️❌ azure-sdk-for-java failed [Detail]
    For more instructions, please refer to the FAQ .
  • Pipeline Framework Failed in generating from 79cfbcac74af39d8c93c26b8f171b51f8b384137. SDK Automation 14.0.0
    command	./eng/mgmt/automation/init.sh ../azure-sdk-for-java_tmp/initInput.json ../azure-sdk-for-java_tmp/initOutput.json
    command	./eng/mgmt/automation/generate.py ../azure-sdk-for-java_tmp/generateInput.json ../azure-sdk-for-java_tmp/generateOutput.json
    cmderr	[generate.py] [GENERATE][Error] Code generation failed.
    cmderr	[generate.py] Please first check if the failure happens only to Java automation, or for all SDK automations.
    cmderr	[generate.py] If it happens for all SDK automations, please double check your Swagger, and check whether there is errors in ModelValidation and LintDiff.
    cmderr	[generate.py] If it happens to Java alone, you can open an issue to https://github.com/Azure/autorest.java/issues. Please include the link of this Pull Request in the issue.
    ENOENT: no such file or directory, copyfile 'azure-sdk-for-java/sdk/network/azure-resourcemanager-network-generated/pom.xml' -> 'generatedSdkArtifacts/pom.xml'
    error	GenerationError: The following packages are still pending.
    error		azure-resourcemanager-network-generated
  • azure-resourcemanager-network-generated
    error	FatalError: ENOENT: no such file or directory, copyfile 'azure-sdk-for-java/sdk/network/azure-resourcemanager-network-generated/pom.xml' -> 'generatedSdkArtifacts/pom.xml'. Please refer to the inner logs for details or report this issue through https://aka.ms/azsdk/support/specreview-channel.
    error	ErrorStack: Error: ENOENT: no such file or directory, copyfile 'azure-sdk-for-java/sdk/network/azure-resourcemanager-network-generated/pom.xml' -> 'generatedSdkArtifacts/pom.xml'    at copyFileSync (node:fs:2982:3)    at workflowPkgSaveSDKArtifact (/mnt/vss/_work/1/a/unified-pipeline-runtime/private/openapi-sdk-automation/lib/automation/workflowPackage.js:227:35)    at workflowPkgMain (/mnt/vss/_work/1/a/unified-pipeline-runtime/private/openapi-sdk-automation/lib/automation/workflowPackage.js:79:11)    at process.processTicksAndRejections (node:internal/process/task_queues:95:5)    at async workflowHandleReadmeMdOrTypeSpecProject (/mnt/vss/_work/1/a/unified-pipeline-runtime/private/openapi-sdk-automation/lib/automation/workflow.js:259:9)    at async workflowMain (/mnt/vss/_work/1/a/unified-pipeline-runtime/private/openapi-sdk-automation/lib/automation/workflow.js:111:13)    at async sdkAutoMain (/mnt/vss/_work/1/a/unified-pipeline-runtime/private/openapi-sdk-automation/lib/automation/entrypoint.js:217:13)    at async /mnt/vss/_work/1/a/unified-pipeline-runtime/private/openapi-sdk-automation/lib/cli/cli.js:20:18.
    error	GenerationError: The following packages are still pending.
    error		azure-resourcemanager-network-generated
️️✔️ azure-sdk-for-go succeeded [Detail] [Expand]
    For more instructions, please refer to the FAQ .
  • ️✔️Succeeded in generating from 79cfbcac74af39d8c93c26b8f171b51f8b384137. SDK Automation 14.0.0
    command	sh ./eng/scripts/automation_init.sh ../../../../../azure-sdk-for-go_tmp/initInput.json ../../../../../azure-sdk-for-go_tmp/initOutput.json
    command	generator automation-v2 ../../../../../azure-sdk-for-go_tmp/generateInput.json ../../../../../azure-sdk-for-go_tmp/generateOutput.json
  • ️✔️sdk/resourcemanager/network/armnetwork [Preview SDK Changes] Breaking Change Detected
    info	[Changelog] ### Breaking Changes
    info	[Changelog]
    info	[Changelog] - Struct `FirewallPacketCaptureParametersFormat` has been removed
    info	[Changelog] - Field `ID`, `Properties` of struct `FirewallPacketCaptureParameters` has been removed
    info	[Changelog]
    info	[Changelog] ### Features Added
    info	[Changelog]
    info	[Changelog] - New value `BastionHostSKUNamePremium` added to enum type `BastionHostSKUName`
    info	[Changelog] - New enum type `ProbeNoHealthyBackendsBehavior` with values `ProbeNoHealthyBackendsBehaviorAllProbedDown`, `ProbeNoHealthyBackendsBehaviorAllProbedUp`
    info	[Changelog] - New function `*InboundSecurityRuleClient.Get(context.Context, string, string, string, *InboundSecurityRuleClientGetOptions) (InboundSecurityRuleClientGetResponse, error)`
    info	[Changelog] - New field `ConnectionResourceURI` in struct `AuthorizationPropertiesFormat`
    info	[Changelog] - New field `EnableSessionRecording` in struct `BastionHostPropertiesFormat`
    info	[Changelog] - New field `Filter` in struct `ExpressRouteCrossConnectionsClientListOptions`
    info	[Changelog] - New field `DurationInSeconds`, `FileName`, `Filters`, `Flags`, `NumberOfPacketsToCapture`, `Protocol`, `SasURL` in struct `FirewallPacketCaptureParameters`
    info	[Changelog] - New field `Identity` in struct `FlowLog`
    info	[Changelog] - New field `Identity` in struct `FlowLogInformation`
    info	[Changelog] - New field `NoHealthyBackendsBehavior` in struct `ProbePropertiesFormat`
    info	[Changelog] - New field `NetworkIdentifier` in struct `ServiceEndpointPropertiesFormat`
    info	[Changelog] - New field `Identity` in struct `VirtualNetworkGateway`
    info	[Changelog]
    info	[Changelog] Total 3 breaking change(s), 14 additive change(s).
    Present SDK breaking changes suppressions
    Field `ID`, `Properties` of struct `FirewallPacketCaptureParameters` has been removed
    Struct `FirewallPacketCaptureParametersFormat` has been removed
    Please refer to the guidance for suppressing SDK breaking changes.
️️✔️ azure-sdk-for-js succeeded [Detail] [Expand]
    For more instructions, please refer to the FAQ .
  • ️✔️Succeeded in generating from 79cfbcac74af39d8c93c26b8f171b51f8b384137. SDK Automation 14.0.0
    command	sh .scripts/automation_init.sh ../azure-sdk-for-js_tmp/initInput.json ../azure-sdk-for-js_tmp/initOutput.json
    warn	Warning: File azure-sdk-for-js_tmp/initOutput.json not found to read. Please re-run the pipeline if the error is transitient error or report this issue through https://aka.ms/azsdk/support/specreview-channel.
    command	sh .scripts/automation_generate.sh ../azure-sdk-for-js_tmp/generateInput.json ../azure-sdk-for-js_tmp/generateOutput.json
  • ️✔️@azure/arm-network [Preview SDK Changes]
    info	[Changelog] **Features**
    info	[Changelog]
    info	[Changelog]   - Added operation InboundSecurityRuleOperations.get
    info	[Changelog]   - Added Interface InboundSecurityRuleGetOptionalParams
    info	[Changelog]   - Added Type Alias InboundSecurityRuleGetResponse
    info	[Changelog]   - Added Type Alias ProbeNoHealthyBackendsBehavior
    info	[Changelog]   - Interface BastionHost has a new optional parameter enableSessionRecording
    info	[Changelog]   - Interface ExpressRouteCircuitAuthorization has a new optional parameter connectionResourceUri
    info	[Changelog]   - Interface ExpressRouteCrossConnectionsListOptionalParams has a new optional parameter filter
    info	[Changelog]   - Interface FlowLog has a new optional parameter identity
    info	[Changelog]   - Interface FlowLogInformation has a new optional parameter identity
    info	[Changelog]   - Interface Probe has a new optional parameter noHealthyBackendsBehavior
    info	[Changelog]   - Interface ServiceEndpointPropertiesFormat has a new optional parameter networkIdentifier
    info	[Changelog]   - Interface VirtualNetworkGateway has a new optional parameter identity
    info	[Changelog]   - Added Enum KnownProbeNoHealthyBackendsBehavior
    info	[Changelog]   - Enum KnownBastionHostSkuName has a new value Premium
️❌ azure-resource-manager-schemas failed [Detail]
    For more instructions, please refer to the FAQ .
  • Code Generator Failed in generating from 79cfbcac74af39d8c93c26b8f171b51f8b384137. Schema Automation 14.0.0
    command	.sdkauto/initScript.sh ../azure-resource-manager-schemas_tmp/initInput.json ../azure-resource-manager-schemas_tmp/initOutput.json
    cmderr	[initScript.sh] Submodule 'bicep-types-az' (https://github.com/Azure/bicep-types-az) registered for path 'bicep-types-az'
    cmderr	[initScript.sh] Cloning into '/mnt/vss/_work/1/s/azure-resource-manager-schemas/bicep-types-az'...
    cmderr	[initScript.sh] Submodule 'bicep-types' (https://github.com/Azure/bicep-types) registered for path 'bicep-types-az/bicep-types'
    cmderr	[initScript.sh] Cloning into '/mnt/vss/_work/1/s/azure-resource-manager-schemas/bicep-types-az/bicep-types'...
    cmderr	[initScript.sh] npm notice
    cmderr	[initScript.sh] npm notice New minor version of npm available! 10.7.0 -> 10.8.1
    cmderr	[initScript.sh] npm notice Changelog: https://github.com/npm/cli/releases/tag/v10.8.1
    cmderr	[initScript.sh] npm notice To update run: npm install -g npm@10.8.1
    cmderr	[initScript.sh] npm notice
    error	Script return with result [failed] code [1] signal [null] cwd [azure-resource-manager-schemas]: .sdkauto/initScript.sh
    warn	Warning: File azure-resource-manager-schemas_tmp/initOutput.json not found to read. Please re-run the pipeline if the error is transitient error or report this issue through https://aka.ms/azsdk/support/specreview-channel.
    command	.sdkauto/generateScript.sh ../azure-resource-manager-schemas_tmp/generateInput.json ../azure-resource-manager-schemas_tmp/generateOutput.json
    cmderr	[generateScript.sh] /mnt/vss/_work/1/a/unified-pipeline-runtime/common/temp/node_modules/.pnpm/ts-node@9.0.0_typescript@5.3.3/node_modules/ts-node/src/index.ts:500
    cmderr	[generateScript.sh]     return new TSError(diagnosticText, diagnosticCodes)
    cmderr	[generateScript.sh]            ^
    cmderr	[generateScript.sh] TSError: ⨯ Unable to compile TypeScript:
    cmderr	[generateScript.sh] cmd/generateall.ts(6,20): error TS2307: Cannot find module 'colors' or its corresponding type declarations.
    cmderr	[generateScript.sh] cmd/generateall.ts(10,19): error TS2307: Cannot find module 'yargs' or its corresponding type declarations.
    cmderr	[generateScript.sh] cmd/generateall.ts(11,18): error TS2307: Cannot find module 'path' or its corresponding type declarations.
    cmderr	[generateScript.sh] cmd/generateall.ts(13,35): error TS2307: Cannot find module 'fs' or its corresponding type declarations.
    cmderr	[generateScript.sh] cmd/generateall.ts(14,23): error TS2307: Cannot find module 'strip-ansi' or its corresponding type declarations.
    cmderr	[generateScript.sh] cmd/generateall.ts(42,9): error TS2584: Cannot find name 'console'. Do you need to change your target library? Try changing the 'lib' compiler option to include 'dom'.
    cmderr	[generateScript.sh] cmd/generateall.ts(53,9): error TS2584: Cannot find name 'console'. Do you need to change your target library? Try changing the 'lib' compiler option to include 'dom'.
    cmderr	[generateScript.sh] cmd/generateall.ts(69,67): error TS7006: Parameter 'x' implicitly has an 'any' type.
    cmderr	[generateScript.sh] cmd/generateall.ts(70,49): error TS7006: Parameter 'f' implicitly has an 'any' type.
    cmderr	[generateScript.sh] cmd/generateall.ts(94,21): error TS2584: Cannot find name 'console'. Do you need to change your target library? Try changing the 'lib' compiler option to include 'dom'.
    cmderr	[generateScript.sh] cmd/generateall.ts(105,21): error TS2584: Cannot find name 'console'. Do you need to change your target library? Try changing the 'lib' compiler option to include 'dom'.
    cmderr	[generateScript.sh] cmd/generateall.ts(106,21): error TS2584: Cannot find name 'console'. Do you need to change your target library? Try changing the 'lib' compiler option to include 'dom'.
    cmderr	[generateScript.sh] cmd/generateall.ts(157,13): error TS2591: Cannot find name 'process'. Do you need to install type definitions for node? Try `npm i --save-dev @types/node` and then add 'node' to the types field in your tsconfig.
    cmderr	[generateScript.sh]     at createTSError (/mnt/vss/_work/1/a/unified-pipeline-runtime/common/temp/node_modules/.pnpm/ts-node@9.0.0_typescript@5.3.3/node_modules/ts-node/src/index.ts:500:12)
    cmderr	[generateScript.sh]     at reportTSError (/mnt/vss/_work/1/a/unified-pipeline-runtime/common/temp/node_modules/.pnpm/ts-node@9.0.0_typescript@5.3.3/node_modules/ts-node/src/index.ts:504:19)
    cmderr	[generateScript.sh]     at getOutput (/mnt/vss/_work/1/a/unified-pipeline-runtime/common/temp/node_modules/.pnpm/ts-node@9.0.0_typescript@5.3.3/node_modules/ts-node/src/index.ts:739:36)
    cmderr	[generateScript.sh]     at Object.compile (/mnt/vss/_work/1/a/unified-pipeline-runtime/common/temp/node_modules/.pnpm/ts-node@9.0.0_typescript@5.3.3/node_modules/ts-node/src/index.ts:955:32)
    cmderr	[generateScript.sh]     at Module.m._compile (/mnt/vss/_work/1/a/unified-pipeline-runtime/common/temp/node_modules/.pnpm/ts-node@9.0.0_typescript@5.3.3/node_modules/ts-node/src/index.ts:1043:43)
    cmderr	[generateScript.sh]     at Module._extensions..js (node:internal/modules/cjs/loader:1422:10)
    cmderr	[generateScript.sh]     at Object.require.extensions.<computed> [as .ts] (/mnt/vss/_work/1/a/unified-pipeline-runtime/common/temp/node_modules/.pnpm/ts-node@9.0.0_typescript@5.3.3/node_modules/ts-node/src/index.ts:1046:12)
    cmderr	[generateScript.sh]     at Module.load (node:internal/modules/cjs/loader:1203:32)
    cmderr	[generateScript.sh]     at Function.Module._load (node:internal/modules/cjs/loader:1019:12)
    cmderr	[generateScript.sh]     at Function.executeUserEntryPoint [as runMain] (node:internal/modules/run_main:128:12)
    error	Script return with result [failed] code [1] signal [null] cwd [azure-resource-manager-schemas]: .sdkauto/generateScript.sh
    warn	Warning: Package processing is skipped as the SDK generation fails. Please look into the above generation errors or report this issue through https://aka.ms/azsdk/support/specreview-channel.
️⚠️ azure-powershell warning [Detail]
    For more instructions, please refer to the FAQ .
  • ⚠️Warning in generating from 79cfbcac74af39d8c93c26b8f171b51f8b384137. SDK Automation 14.0.0
    command	sh ./tools/SwaggerCI/init.sh ../azure-powershell_tmp/initInput.json ../azure-powershell_tmp/initOutput.json
    command	pwsh ./tools/SwaggerCI/psci.ps1 ../azure-powershell_tmp/generateInput.json ../azure-powershell_tmp/generateOutput.json
  • ⚠️Az.network.DefaultTag [Preview SDK Changes]
Posted by Swagger Pipeline | How to fix these errors?

jianzhao1992 and others added 2 commits June 17, 2024 21:02
…ssRoute CrossConnection (#29251)

* Add CrossConnection name as an optional query parameter for List CrossConnection

* update example

* Addressing comments

* Change to OData filtering

* Fix the parameter reference

* Update

---------

Co-authored-by: Jianqi Zhao <jianzhao@microsoft.com>
@JeffreyRichter JeffreyRichter added the BreakingChange-Approved-Previously Changes were reviewed and approved in a previous PR label Jun 18, 2024
@AzureRestAPISpecReview AzureRestAPISpecReview removed the BreakingChange-Approved-Previously Changes were reviewed and approved in a previous PR label Jun 20, 2024
@nikhilpadhye1 nikhilpadhye1 changed the base branch from release-network-Microsoft.Network-2024-01-01 to main June 20, 2024 19:46
Copy link

PR validation pipeline can not start as the pull request is not merged or mergeable - most likely it has merge conflicts.

@nikhilpadhye1 nikhilpadhye1 added the BreakingChange-Approved-Previously Changes were reviewed and approved in a previous PR label Jun 20, 2024
@nikhilpadhye1
Copy link
Contributor Author

/pr Requestmerge

@mentat9
Copy link
Member

mentat9 commented Jun 20, 2024

@nikhilpadhye1 - Couple of things:

  1. You need to resolve merge conflicts.
  2. The Go breaking change is not handled by the BreakingChange-ApprovedPreviously label. The SDK team needs to approve the Go SDK breaking change. Help link: https://github.com/Azure/azure-rest-api-specs/blob/main/documentation/ci-fix.md#sdk-azure-sdk-for--checks-like-sdk-azure-sdk-for-go.
  3. I also promoted the Approved-ModelValidation label from your private PR.

@nikhilpadhye1
Copy link
Contributor Author

@mentat9 i resolved the merge conflicts and ensured they are inline with main branch changes, Following up your documentation for #2.

@AzureRestAPISpecReview AzureRestAPISpecReview added the BreakingChangeReviewRequired <valid label in PR review process>add this label when breaking change review is required label Jun 20, 2024
@nikhilpadhye1
Copy link
Contributor Author

@mentat9 my azure-sdk-for-go passed its check, i will still follow up with ray regarding removing the tag

@mentat9
Copy link
Member

mentat9 commented Jun 20, 2024

@mentat9 my azure-sdk-for-go passed its check, i will still follow up with ray regarding removing the tag

@nikhilpadhye1 - They will actually add an approval label, which is required before merge. After you get the approval label, you can request merge and I will merge it for you. The Next Steps to Merge is constantly updated to inform you what you need to do, so always be sure to check there.

@nikhilpadhye1 nikhilpadhye1 removed the BreakingChangeReviewRequired <valid label in PR review process>add this label when breaking change review is required label Jun 21, 2024
@AzureRestAPISpecReview AzureRestAPISpecReview added the BreakingChangeReviewRequired <valid label in PR review process>add this label when breaking change review is required label Jun 21, 2024
@nikhilpadhye1
Copy link
Contributor Author

@mentat9 got the necessary surpression approval. Will request merge using /pr Requestmerge

@nikhilpadhye1
Copy link
Contributor Author

/pr Requestmerge

@mentat9
Copy link
Member

mentat9 commented Jun 21, 2024

/azp run

Copy link

Azure Pipelines successfully started running 4 pipeline(s).

@mentat9 mentat9 self-requested a review June 21, 2024 19:21
@mentat9 mentat9 merged commit a0ace9e into main Jun 21, 2024
26 of 32 checks passed
@mentat9 mentat9 deleted the packetCaptureFixToLatestAPI branch June 21, 2024 19:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Approved-ModelValidation ARMReview ARMSignedOff <valid label in PR review process>add this label when ARM approve updates after review BreakingChange-Approved-Previously Changes were reviewed and approved in a previous PR BreakingChange-Go-Sdk-Suppression BreakingChange-Go-Sdk-Suppression-Approved BreakingChangeReviewRequired <valid label in PR review process>add this label when breaking change review is required resource-manager
Projects
None yet
Development

Successfully merging this pull request may close these issues.