Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Added: Note that sunrise and sunset times not returned when solar day is observed in the requested region #30860

Merged
merged 5 commits into from
Oct 4, 2024
Merged

Added: Note that sunrise and sunset times not returned when solar day is observed in the requested region #30860

Show file tree
Hide file tree
Changes from 3 commits
Commits
Show all changes
5 commits
Select commit Hold shift + click to select a range
9149a56
Added: Note that the Timezone API does not return sunrise and sunset …
stevemunk Oct 4, 2024
bee09ea
Added TypeSpecRequirement suppression for timezone v1.
stevemunk Oct 4, 2024
45eea73
Merge branch 'main' into timezone-coordinates
stevemunk Oct 4, 2024
87b46ef
Added TypeSpecRequirement suppression for timezone v1.
stevemunk Oct 4, 2024
8e43fcf
Added TypeSpecRequirement suppression for timezone v1.
stevemunk Oct 4, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 3 additions & 3 deletions specification/maps/data-plane/Timezone/preview/1.0/timezone.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -189,7 +189,7 @@
"/timezone/byCoordinates/{format}": {
"get": {
"summary": "Use to get the current, historical, and future time zone information for the specified latitude-longitude pair.",
"description": "\n\nThe `Get Timezone By Coordinates` API is an HTTP `GET` request that returns current, historical, and future time zone information for a specified latitude-longitude pair. In addition, the API provides sunset and sunrise times for a given location.",
"description": "\n\nThe `Get Timezone By Coordinates` API is an HTTP `GET` request that returns current, historical, and future time zone information for a specified latitude-longitude pair. In addition, the API provides sunset and sunrise times for a given location, with the exception of regions that observe solar days.",
"operationId": "Timezone_GetTimezoneByCoordinates",
"x-ms-examples": {
"Successfully retrieve timezone by coordinates": {
Expand Down Expand Up @@ -670,13 +670,13 @@
"readOnly": true
},
"Sunrise": {
"description": "Sunrise at the given time zone as shown in the `Tag` property. The sunrise is described in the ISO8601 format. (Only be populated if the call is byCoordinates)",
"description": "Sunrise at the given time zone as shown in the `Tag` property, populated only when the call is `byCoordinates`. The sunrise is described in the [ISO 8601](https://www.iso.org/iso-8601-date-and-time-format.html) format. Note that the Timezone API does not return sunrise and sunset times when solar day is observed in the requested region.",
"type": "string",
"format": "date-time",
"readOnly": true
},
"Sunset": {
"description": "Sunset at the given time zone as shown in the `Tag` property. The sunset is described in the ISO8601 format.(Only be populated if the call is byCoordinates)",
"description": "Sunset at the given time zone as shown in the `Tag` property, populated only when the call is `byCoordinates`. The sunset is described in the [ISO 8601](https://www.iso.org/iso-8601-date-and-time-format.html) format. Note that the Timezone API does not return sunrise and sunset times when solar day is observed in the requested region.",
"type": "string",
"format": "date-time",
"readOnly": true
Expand Down
3 changes: 3 additions & 0 deletions specification/maps/suppressions.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,3 +1,6 @@
- tool: TypeSpecRequirement
path: ./data-plane/Route/preview/1.0/route.json
reason: Brownfield service not ready to migrate
- tool: TypeSpecRequirement
path: ./data-plane/timezone/preview/1.0/timezone.json
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
path: ./data-plane/timezone/preview/1.0/timezone.json
path: ./data-plane/Timezone/preview/1.0/timezone.json

reason: Brownfield service not ready to migrate
Loading