Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add missing debugsend and patch operation for NotificationHub resource #3215

Merged
merged 9 commits into from
Jun 13, 2018
Merged

Add missing debugsend and patch operation for NotificationHub resource #3215

merged 9 commits into from
Jun 13, 2018

Conversation

blocphan
Copy link
Contributor

@blocphan blocphan commented Jun 12, 2018 •
edited
Loading

This checklist is used to make sure that common issues in a pull request are addressed. This will expedite the process of getting your pull request merged and avoid extra work on your part to fix issues discovered during the review process.

PR information

  • The title of the PR is clear and informative.
  • There are a small number of commits, each of which have an informative message. This means that previously merged commits do not appear in the history of the PR. For information on cleaning up the commits in your pull request, see this page.
  • Except for special cases involving multiple contributors, the PR is started from a fork of the main repository, not a branch.
  • If applicable, the PR references the bug/issue that it fixes.
  • Swagger files are correctly named (e.g. the api-version in the path should match the api-version in the spec).

Quality of Swagger

@AutorestCI AutorestCI mentioned this pull request Jun 12, 2018
Merged
@AutorestCI
Copy link

AutorestCI commented Jun 12, 2018 •
edited
Loading

Automation for azure-sdk-for-python

The initial PR has been merged into your service PR:
Azure/azure-sdk-for-python#2737

@AutorestCI AutorestCI mentioned this pull request Jun 12, 2018
Merged
@AutorestCI
Copy link

AutorestCI commented Jun 12, 2018 •
edited
Loading

Automation for azure-sdk-for-node

The initial PR has been merged into your service PR:
Azure/azure-sdk-for-node#2897

@AutorestCI AutorestCI mentioned this pull request Jun 12, 2018
Merged
@AutorestCI
Copy link

AutorestCI commented Jun 12, 2018 •
edited
Loading

Automation for azure-libraries-for-java

The initial PR has been merged into your service PR:
AutorestCI/azure-libraries-for-java#187

@AutorestCI AutorestCI mentioned this pull request Jun 12, 2018
Merged
@AutorestCI
Copy link

AutorestCI commented Jun 12, 2018 •
edited
Loading

Automation for azure-sdk-for-ruby

The initial PR has been merged into your service PR:
Azure/azure-sdk-for-ruby#1369

@AutorestCI AutorestCI mentioned this pull request Jun 12, 2018
Merged
@AutorestCI
Copy link

AutorestCI commented Jun 12, 2018 •
edited
Loading

Automation for azure-sdk-for-go

The initial PR has been merged into your service PR:
Azure/azure-sdk-for-go#2036

jianghaolu
jianghaolu suggested changes Jun 12, 2018
View reviewed changes
...tionhubs/resource-manager/Microsoft.NotificationHubs/stable/2017-04-01/notificationhubs.json
},
"operationId": "NotificationHubs_DebugSend",
"description": "test send a push notification",
"parameters": [
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Missing parameter 'subscriptionId'

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Fixed now

...osoft.NotificationHubs/stable/2017-04-01/examples/NotificationHubs/NotificationHubPatch.json Outdated
"notificationHubName": "sdk-notificationHubs-8708",
"api-version": "2017-04-01",
"subscriptionId": "29cfa613-cbbc-4512-b1d6-1b3a92c7fa40",
"properties": {
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This should be "parameters"

...t.NotificationHubs/stable/2017-04-01/examples/NotificationHubs/NotificationHubDebugSend.json Outdated
"subscriptionId": "29cfa613-cbbc-4512-b1d6-1b3a92c7fa40"
},
"responses": {
"200": {
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

"200" is not a valid response defined in the spec.

...t.NotificationHubs/stable/2017-04-01/examples/NotificationHubs/NotificationHubDebugSend.json Outdated
"notificationHubName": "nh-sdk-hub",
"api-version": "2017-04-01",
"subscriptionId": "29cfa613-cbbc-4512-b1d6-1b3a92c7fa40"
},
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Required parameter "parameters" missing.

specification/notificationhubs/resource-manager/readme.md Outdated
@@ -24,6 +24,16 @@ To see additional help and options, run:
### Basic Information
These are the global settings for the NotificationHubs API.

directive:
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The directives must be defined in the yaml section for the tag containing this definition

@jianghaolu jianghaolu merged commit 289cf40 into Azure:master Jun 13, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jianghaolu jianghaolu jianghaolu approved these changes

Assignees

@jianghaolu jianghaolu

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@blocphan @AutorestCI @jianghaolu