fix query packet capture status in latest version #3601

junyezhu · 2018-08-07T19:33:46Z

This checklist is used to make sure that common issues in a pull request are addressed. This will expedite the process of getting your pull request merged and avoid extra work on your part to fix issues discovered during the review process.

PR information

The title of the PR is clear and informative.
There are a small number of commits, each of which have an informative message. This means that previously merged commits do not appear in the history of the PR. For information on cleaning up the commits in your pull request, see this page.
Except for special cases involving multiple contributors, the PR is started from a fork of the main repository, not a branch.
If applicable, the PR references the bug/issue that it fixes.
Swagger files are correctly named (e.g. the api-version in the path should match the api-version in the spec).

Quality of Swagger

I have read the contribution guidelines.
My spec meets the review criteria:
- The spec conforms to the Swagger 2.0 specification.
- The spec follows the guidelines described in the Swagger checklist document.
- Validation tools were run on swagger spec(s) and have all been fixed in this PR.

junyezhu · 2018-08-07T19:34:46Z

@lmazuel

azuresdkci · 2018-08-07T19:35:09Z

Can one of the admins verify this patch?

AutorestCI · 2018-08-07T19:39:42Z

Automation for azure-sdk-for-ruby

Nothing to generate for azure-sdk-for-ruby

AutorestCI · 2018-08-07T19:44:05Z

Automation for azure-sdk-for-python

A PR has been created for you:
Azure/azure-sdk-for-python#3094

AutorestCI · 2018-08-07T20:04:51Z

Automation for azure-sdk-for-node

Nothing to generate for azure-sdk-for-node

dsgouda · 2018-08-07T20:04:51Z

specification/network/resource-manager/Microsoft.Network/stable/2018-07-01/networkWatcher.json

@@ -728,6 +728,9 @@
        ],
        "operationId": "PacketCaptures_GetStatus",
        "x-ms-long-running-operation": true,
+        "x-ms-long-running-operation-options": {


@fearthecowboy are we supporting these options now?

@dsgouda I have confirmation of support in Python (already shipped part of the CLI), Ruby and Java. Whether C# supports it, I don't know :). Anyway, the C# runtime is doing "Location" by default, this is has no impact on C#, whether it's supported or not.

lmazuel · 2018-08-07T20:06:27Z

See #3597 for api-version <= 2018-06-01

lmazuel

Tested already in 2018-06-01, this is just catching up 2018-06-01

AutorestCI · 2018-08-07T20:43:11Z

Automation for azure-sdk-for-java

Nothing to generate for azure-sdk-for-java

AutorestCI · 2018-08-07T21:07:04Z

Automation for azure-sdk-for-go

Nothing to generate for azure-sdk-for-go

* Created folder for 2018-07-01 api version (#3509) * Created folder for 2018-07-01 api version * fixed incorrect encoding symbol * Fix lint diff and improve output on failure (#3528) Lint diff was failing on PRs with a base branch other than master. We needed to fetch the base branch ref from the origin before trying to resolve it to its commit hash. * Python conf for Network 2018-06 (#3535) * Py conf for Network 2018-07-01 (#3539) * Introduce Publicipprefix to swagger (#3520) * Add PublicIpPrefix * Add PublicIpPrefix * Add PublicIpPrefix * Move to 2018-07-01 branch * revertversionchange * Fix Syntax error * Fix IpTag description because evidently everything is global * Fix $ref for PublicIpPrefix * Fix Casing * Add Exception for PublicIPPrefix from RequiredPropertiesMissingInResourceModel * Fix Version# * Fix Examples * Publicipprefixaugust (#3573) * Add PublicIpPrefix * Add PublicIpPrefix * Add PublicIpPrefix * Move to 2018-07-01 branch * revertversionchange * Fix Syntax error * Fix IpTag description because evidently everything is global * Fix $ref for PublicIpPrefix * Fix Casing * Add Exception for PublicIPPrefix from RequiredPropertiesMissingInResourceModel * Fix Version# * Fix Examples * Remove IdleTimeout parameter * Fix comma * Service Endpoint Policies Swagger (#3558) * Service Endpoint Policies Swagger * Fix review comments * Updated Network Usage location parameter pattern (#3583) * Add enableTcpReset property to load balancer (#3545) * Add enableTcpReset property to load balancer. * Update loadbalancer examples with enableTcpReset. * added global reach flag (#3542) * fix query packet capture status in latest version (#3601) * Publicipprefixaugust (#3618) * Add PublicIpPrefix * Add PublicIpPrefix * Add PublicIpPrefix * Move to 2018-07-01 branch * revertversionchange * Fix Syntax error * Fix IpTag description because evidently everything is global * Fix $ref for PublicIpPrefix * Fix Casing * Add Exception for PublicIPPrefix from RequiredPropertiesMissingInResourceModel * Fix Version# * Fix Examples * Remove IdleTimeout parameter * Fix comma * Add PublicIpPrefix for PublicIpAddressConfiguration * Fix PublicIPAddress to refer to PublicIpPrefix as SubResource * Fix Comma * Remove compute update * Publicipprefixaugust (#3631) * Add PublicIpPrefix * Add PublicIpPrefix * Add PublicIpPrefix * Move to 2018-07-01 branch * revertversionchange * Fix Syntax error * Fix IpTag description because evidently everything is global * Fix $ref for PublicIpPrefix * Fix Casing * Add Exception for PublicIPPrefix from RequiredPropertiesMissingInResourceModel * Fix Version# * Fix Examples * Remove IdleTimeout parameter * Fix comma * Add PublicIpPrefix for PublicIpAddressConfiguration * Fix PublicIPAddress to refer to PublicIpPrefix as SubResource * Fix Comma * Remove compute update * Add PublicIpPrefix Subresource to VirtualMachineScaleSetPublicIPAddressConfigurationProperties * Changes to Support MSEEv2 Datapath for ExpressRoute. (#3647) Description of Changes: - Added a flag expressRouteGatewayBypass to the Connection Properties. - The user can set the flag to True to use MSEEv2 datapath Related work items: #2628003 * Added new API to networkwatcher.json and examples (#3650) * Added new API to networkwatcher.json and examples * Added NetworkWatcherNetworkConfigurationDiagnostic example * Fix name from ServiceEndpointDefinition to ServiceEndpointDefinitions while doing a put, get and delete (#3655) * Add/Edit Outbound Rule on Load Balancer and Examples (#3592) * Add/Edit Outbound Rule on Load Balancer and Examples * Adding properties enabletcpreset, idletimeoutinminutes and protocol * Adding a reference to Public IP Prefix * Dummy Commit * Removed QueryConnectionMOnitors API (#3661) * Added new API to networkwatcher.json and examples * Added NetworkWatcherNetworkConfigurationDiagnostic example * removed QueryConnectionMonitors Api

* Update shareInvites.json * Update shares.json * Update Share_Update.json * Update Share_Put.json * Update Share_List.json * Update Share_Invites_List.json * Update Share_Get.json * Update shareInvites.json * Update Share_Invites_List.json * Update shareInvites.json

fix query packet capture status in latest version

4a70619

junyezhu requested a review from MikhailTryakhov as a code owner August 7, 2018 19:33

azuresdkci assigned dsgouda Aug 7, 2018

azuresdkci requested a review from dsgouda August 7, 2018 19:35

AutorestCI mentioned this pull request Aug 7, 2018

[AutoPR network/resource-manager] fix query packet capture status in latest version Azure/azure-sdk-for-python#3094

Merged

lmazuel requested review from lmazuel and removed request for dsgouda August 7, 2018 20:02

lmazuel assigned lmazuel and unassigned dsgouda Aug 7, 2018

dsgouda reviewed Aug 7, 2018

View reviewed changes

lmazuel mentioned this pull request Aug 7, 2018

Juliet/fix/querypcstatus #3600

Closed

10 tasks

lmazuel approved these changes Aug 7, 2018

View reviewed changes

lmazuel merged commit c1be2e6 into Azure:Network-August-Release Aug 7, 2018

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

fix query packet capture status in latest version #3601

fix query packet capture status in latest version #3601

junyezhu commented Aug 7, 2018 •

edited

Loading

junyezhu commented Aug 7, 2018

azuresdkci commented Aug 7, 2018

AutorestCI commented Aug 7, 2018 •

edited

Loading

AutorestCI commented Aug 7, 2018 •

edited

Loading

AutorestCI commented Aug 7, 2018 •

edited

Loading

dsgouda Aug 7, 2018

lmazuel Aug 7, 2018

lmazuel commented Aug 7, 2018

lmazuel left a comment

AutorestCI commented Aug 7, 2018 •

edited

Loading

AutorestCI commented Aug 7, 2018 •

edited

Loading

fix query packet capture status in latest version #3601

fix query packet capture status in latest version #3601

Conversation

junyezhu commented Aug 7, 2018 • edited Loading

PR information

Quality of Swagger

junyezhu commented Aug 7, 2018

azuresdkci commented Aug 7, 2018

AutorestCI commented Aug 7, 2018 • edited Loading

Automation for azure-sdk-for-ruby

AutorestCI commented Aug 7, 2018 • edited Loading

Automation for azure-sdk-for-python

AutorestCI commented Aug 7, 2018 • edited Loading

Automation for azure-sdk-for-node

dsgouda Aug 7, 2018

Choose a reason for hiding this comment

lmazuel Aug 7, 2018

Choose a reason for hiding this comment

lmazuel commented Aug 7, 2018

lmazuel left a comment

Choose a reason for hiding this comment

AutorestCI commented Aug 7, 2018 • edited Loading

Automation for azure-sdk-for-java

AutorestCI commented Aug 7, 2018 • edited Loading

Automation for azure-sdk-for-go

junyezhu commented Aug 7, 2018 •

edited

Loading

AutorestCI commented Aug 7, 2018 •

edited

Loading

AutorestCI commented Aug 7, 2018 •

edited

Loading

AutorestCI commented Aug 7, 2018 •

edited

Loading

AutorestCI commented Aug 7, 2018 •

edited

Loading

AutorestCI commented Aug 7, 2018 •

edited

Loading