Rename Post to Grants #3947
Rename Post to Grants #3947
Conversation
Automation for azure-sdk-for-jsNothing to generate for azure-sdk-for-js |
Automation for azure-sdk-for-pythonA PR has been created for you based on this PR content. Once this PR will be merged, content will be added to your service PR: |
Automation for azure-sdk-for-rubyThe initial PR has been merged into your service PR: |
Automation for azure-sdk-for-nodeThe initial PR has been merged into your service PR: |
Automation for azure-sdk-for-javaNothing to generate for azure-sdk-for-java |
Automation for azure-sdk-for-goNothing to generate for azure-sdk-for-go |
|
Can one of the admins verify this patch? |
| @@ -1628,13 +1628,13 @@ | |||
| }, | |||
| "post" : { | |||
| "tags": [ | |||
| "OAuth2Permissions_post" | |||
| "OAuth2Permissions_Grants" | |||
There was a problem hiding this comment.
Making this plural suggests a read operation to me. I'd recommend "OAuth2Permissions_Grant" or even "OAuth2Permissions_CreateOrUpdate"
There was a problem hiding this comment.
For a POST action I would avoid "create_or_update", I go for "grant" :)
|
@AutorestCI rebuild azure-sdk-for-python |
@shanepeckham Our naming convention should not use HTTP verbs as part of operation ID, but be more meaningfull. This PR renames "post" to "grants", this will make SDK looks like:
which is very better user friendly. I do believe your CLI PR is not merged yet, so I think it's the right time to do that now. I discussed this with your initial reviewer @marstr and he agreed on that.
@yugangw-msft FYI