Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[ACR] Auto Build Swagger: Add registry identity properties to response #4036

Closed
wants to merge 1 commit into from

Conversation

xiadu94
Copy link
Contributor

@xiadu94 xiadu94 commented Sep 28, 2018

This checklist is used to make sure that common issues in a pull request are addressed. This will expedite the process of getting your pull request merged and avoid extra work on your part to fix issues discovered during the review process.

PR information

  • [* ] The title of the PR is clear and informative.
  • [ *] There are a small number of commits, each of which have an informative message. This means that previously merged commits do not appear in the history of the PR. For information on cleaning up the commits in your pull request, see this page.
  • [* ] Except for special cases involving multiple contributors, the PR is started from a fork of the main repository, not a branch.
  • If applicable, the PR references the bug/issue that it fixes.
  • Swagger files are correctly named (e.g. the api-version in the path should match the api-version in the spec).

Quality of Swagger

@AutorestCI
Copy link

AutorestCI commented Sep 28, 2018

Automation for azure-sdk-for-js

Nothing to generate for azure-sdk-for-js

@AutorestCI
Copy link

AutorestCI commented Sep 28, 2018

Automation for azure-sdk-for-python

A PR has been created for you based on this PR content.

Once this PR will be merged, content will be added to your service PR:
Azure/azure-sdk-for-python#3467

@AutorestCI
Copy link

AutorestCI commented Sep 28, 2018

Automation for azure-sdk-for-node

A PR has been created for you:
Azure/azure-sdk-for-node#3729

@AutorestCI
Copy link

AutorestCI commented Sep 28, 2018

Automation for azure-sdk-for-ruby

A PR has been created for you based on this PR content.

Once this PR will be merged, content will be added to your service PR:
Azure/azure-sdk-for-ruby#1574

@AutorestCI
Copy link

AutorestCI commented Sep 28, 2018

Automation for azure-sdk-for-go

A PR has been created for you based on this PR content.

Once this PR will be merged, content will be added to your service PR:
Azure/azure-sdk-for-go#2880

@AutorestCI
Copy link

AutorestCI commented Sep 28, 2018

Automation for azure-sdk-for-java

A PR has been created for you based on this PR content.

Once this PR will be merged, content will be added to your service PR:
Azure/azure-sdk-for-java#2460

@azuresdkci
Copy link
Contributor

Can one of the admins verify this patch?

@dsgouda
Copy link
Contributor

dsgouda commented Oct 1, 2018

@sergey-shandar I and @praries880 can take over this one

@dsgouda dsgouda assigned praries880 and dsgouda and unassigned sergey-shandar Oct 1, 2018
@dsgouda dsgouda requested review from praries880 and removed request for sergey-shandar October 1, 2018 23:01
@dsgouda
Copy link
Contributor

dsgouda commented Oct 1, 2018

@praries880 take a look and let me know if you have any queries

@@ -1515,6 +1515,24 @@
}
}
},
"RegistryIdentity": {

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@xiadu94

  • This new type is not referenced anywhere else in the model.. what is its purpose?
    • If this is indeed an object created at the server side and returned to the user, you should mark the properties as readonly. example here
  • Is this meant to be returned from the server side or is it a config object that the user will create?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants