[Hub Generated] Review request for Microsoft.Sql to add WorkloadGroups and WorkloadClasifiers to API 2019-06-01-preview #7349
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…preview to version 2019-06-01-preview
In Testing, Please Ignore[Logs] (Generated from 4e1c6d6, Iteration 10)
|
H-Huang
added
the
DoNotMerge
Automation for azure-sdk-for-pythonA PR has been created for you based on this PR content. Once this PR will be merged, content will be added to your service PR: |
Automation for azure-sdk-for-goA PR has been created for you based on this PR content. Once this PR will be merged, content will be added to your service PR: |
|
Can one of the admins verify this patch? |
H-Huang
added
the
WaitForARMFeedback
|
@H-Huang some examples are ill-formated. https://dev.azure.com/azure-sdk/public/_build/results?buildId=119412&view=logs&jobId=8c9a658c-6596-5897-87e8-abb327497d15 |
|
@jaredmoo please help review this PR as the code owner. Thanks for your help a lot. |
ryansbenson
reviewed
Oct 1, 2019
...ource-manager/Microsoft.Sql/preview/2019-06-01-preview/DataWarehouseWorkloadClassifiers.json
Outdated
Show resolved
Hide resolved
...l/resource-manager/Microsoft.Sql/preview/2019-06-01-preview/DataWarehouseWorkloadGroups.json
Outdated
Show resolved
Hide resolved
...esource-manager/Microsoft.Sql/preview/2019-06-01-preview/examples/GetWorkloadClassifier.json
Outdated
Show resolved
Hide resolved
ryansbenson
added
the
ARMChangesRequested
ryansbenson
added
ARMSignedOff
…into dev-sql-Microsoft.Sql-2019-06-01-preview
This was referenced Oct 25, 2019
H-Huang
changed the title
H-Huang
removed
the
DoNotMerge
jaredmoo
reviewed
Nov 14, 2019
| "memberName": "dbo", | ||
| "label": "test_label", | ||
| "context": "test_context", | ||
| "startTime": "12:00", |
There was a problem hiding this comment.
Swagger & ARM team reviewers, what is the guidance for exposing "time of day" (i.e. just time, not date+time)?
There was a problem hiding this comment.
Swagger & ARM team reviewers, what is the guidance for exposing "time of day" (i.e. just time, not date+time)?
@ryansbenson, what is the suggestion here?
jaredmoo
approved these changes
Nov 14, 2019
yaohaizh
approved these changes
Nov 27, 2019
This was referenced Nov 27, 2019
TalluriAnusha
pushed a commit
to AsrOneSdk/azure-rest-api-specs
that referenced
this pull request
Dec 11, 2019
…s and WorkloadClasifiers to API 2019-06-01-preview (Azure#7349) * Adds base for updating Microsoft.Sql from version preview/2018-06-01-preview to version 2019-06-01-preview * Updates readme * Updates API version in new specs and examples * Added workload group / workload classifiers to package tags with included examples * Undoing the files that were copied over from 2018-06-01-preview folder * Fix linter error for invalid tag * updated create or update classifier example with missing field * updated examples with correct types, correct workload classifiers to save with encoding UTF-8 * modified example resource groups to correct value * update types to WorkloadGroups and WorkloadClassifiers * update readme.md with correct types * update workload group and workload classifier mutability * fix typos in error responses
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Workload Management
Adding new WorkloadGroups.json and WorkloadClassifiers.json swagger files and their examples. These are also part of a new API version 2019-06-01-preview.
Workload groups and workload classifiers are new objects in Azure SQL Data Warehouse which allow customer to manage their instance resources and workloads.
The new swagger files contain the CRUD operations which include
If you are a MSFT employee you can view your work branch via this link.
Contribution checklist: