Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add Microsoft.AVS 2020-03-20 API spec #9859

Merged
merged 10 commits into from
Jul 2, 2020
Merged

Conversation

ctaggart
Copy link
Contributor

The current API version is 2019-08-09-preview from #8296 . This is a new stable API version that includes these changes:

Major changes:

Minor changes:

  • PrivateCloud & Cluster updates use separate definitions
  • sku added and required for a cluster resource
  • Add x-ms-client-flatten for resource properties
  • add x-ms-secret to secrets
  • rename cluster to managementCluster
  • Adding Deleting status
  • removed read-only IDs of subresources in private cloud

MSFT employees can try out our new experience at OpenAPI Hub - one location for using our validation tools and finding your workflow.

Contribution checklist:

If any further question about AME onboarding or validation tools, please view the FAQ.

ARM API Review Checklist

  • Service team MUST add the "WaitForARMFeedback" label if the management plane API changes fall into one of the below categories.
    • adding/removing APIs.
    • adding/removing properties.
    • adding/removing API-version.
    • adding a new service in Azure.

Failure to comply may result in delays for manifest application. Note this does not apply to data plane APIs.

  • If you are blocked on ARM review and want to get the PR merged urgently, please get the ARM oncall for reviews (RP Manifest Approvers team under Azure Resource Manager service) from IcM and reach out to them.
    Please follow the link to find more details on API review process.

@openapi-pipeline-app
Copy link

openapi-pipeline-app bot commented Jun 16, 2020

[Staging] Swagger Validation Report

️✔️BreakingChange [Detail]
 There are no breaking changes. 
️✔️LintDiff [Detail]
 Validation passes for LintDiff. 
️✔️Avocado [Detail]
 Validation passes for Avocado. 
Posted by Swagger Pipeline | How to fix these errors?

@azure-pipelines
Copy link

Azure Pipelines successfully started running 1 pipeline(s).

@ctaggart ctaggart changed the title add Microsot.AVS 2020-03-20 API spec add Microsoft.AVS 2020-03-20 API spec Jun 16, 2020
@azuresdkci
Copy link
Contributor

Can one of the admins verify this patch?

@openapi-sdkautomation
Copy link

openapi-sdkautomation bot commented Jun 16, 2020

Trenton Generation - Release

No readme.md specification configuration files were found that are associated with the files modified in this pull request, or swagger_to_sdk section in readme.md is not configured

@openapi-sdkautomation
Copy link

openapi-sdkautomation bot commented Jun 16, 2020

azure-sdk-for-java - Release

️✔️ succeeded [Logs] [Expand Details]

@openapi-sdkautomation
Copy link

openapi-sdkautomation bot commented Jun 16, 2020

azure-sdk-for-go - Release

️✔️ succeeded [Logs] [Expand Details]

@openapi-sdkautomation
Copy link

openapi-sdkautomation bot commented Jun 16, 2020

azure-sdk-for-python - Release

- Breaking Change detected in SDK

⚠️ warning [Logs] [Expand Details]
  • ⚠️ Generate from 8df7086 with merge commit 6c9921e. SDK Automation 13.0.17.20200619.4
  • ⚠️azure-mgmt-avs [View full logs]  [Release SDK Changes] Breaking Change Detected
    [build_conf] INFO:packaging_tools:Building template azure-mgmt-avs
    [build_conf] INFO:packaging_tools.conf:Skipping default conf since the file exists
    [build_conf] INFO:packaging_tools:Skipping CHANGELOG.md template, since a previous one was found
    [build_conf] INFO:packaging_tools:Template done azure-mgmt-avs
    [build_package] /usr/lib/python3.6/distutils/dist.py:261: UserWarning: Unknown distribution option: 'long_description_content_type'
    [build_package]   warnings.warn(msg)
    [build_package] warning: no files found matching '*.py' under directory 'tests'
    [build_package] warning: no files found matching '*.yaml' under directory 'tests'
    [build_package] /usr/lib/python3.6/distutils/dist.py:261: UserWarning: Unknown distribution option: 'long_description_content_type'
    [build_package]   warnings.warn(msg)
    [build_package] warning: no files found matching '*.py' under directory 'tests'
    [build_package] warning: no files found matching '*.yaml' under directory 'tests'
    [breaking_change_setup] Ignoring mock: markers 'python_version <= "2.7"' don't match your environment
    [ChangeLog] Size of delta 56.419% size of original (original: 19979 chars, delta: 11272 chars)
    [ChangeLog] **Features**
    [ChangeLog] 
    [ChangeLog]   - Model Endpoints has a new parameter hcx_cloud_manager
    [ChangeLog]   - Model Cluster has a new parameter provisioning_state
    [ChangeLog]   - Model Cluster has a new parameter hosts
    [ChangeLog]   - Model Cluster has a new parameter cluster_id
    [ChangeLog]   - Model Cluster has a new parameter cluster_size
    [ChangeLog]   - Added operation group HcxEnterpriseSitesOperations
    [ChangeLog]   - Added operation group AuthorizationsOperations
    [ChangeLog] 
    [ChangeLog] **Breaking changes**
    [ChangeLog] 
    [ChangeLog]   - Operation ClustersOperations.update has a new signature
    [ChangeLog]   - Operation ClustersOperations.create_or_update has a new signature
    [ChangeLog]   - Operation PrivateCloudsOperations.update has a new signature
    [ChangeLog]   - Operation ClustersOperations.create_or_update has a new signature
    [ChangeLog]   - Model Circuit no longer has parameter authorizations
    [ChangeLog]   - Model Cluster no longer has parameter properties
    [ChangeLog]   - Model Cluster has a new required parameter sku
    [ChangeLog]   - Model PrivateCloud has a new signature
    [ChangeLog]   - Model ExpressRouteAuthorization has a new signature

@openapi-sdkautomation
Copy link

openapi-sdkautomation bot commented Jun 16, 2020

Azure CLI Extension Generation - Release

No readme.md specification configuration files were found that are associated with the files modified in this pull request, or swagger_to_sdk section in readme.md is not configured

@openapi-sdkautomation
Copy link

openapi-sdkautomation bot commented Jun 16, 2020

azure-sdk-for-js - Release

️✔️ succeeded [Logs] [Expand Details]
  • ️✔️ Generate from 8df7086 with merge commit 6c9921e. SDK Automation 13.0.17.20200619.4
  • ️✔️@azure/arm-avs [View full logs]  [Release SDK Changes]
    Only show 100 items here, please refer to log for details.
    [npmPack] npm WARN deprecated rollup-plugin-node-resolve@5.2.0: This package has been deprecated and is no longer maintained. Please use @rollup/plugin-node-resolve.
    [npmPack] npm WARN deprecated resolve-url@0.2.1: https://github.com/lydell/resolve-url#deprecated
    [npmPack] npm WARN deprecated urix@0.1.0: Please see https://github.com/lydell/urix#deprecated
    [npmPack] npm notice created a lockfile as package-lock.json. You should commit this file.
    [npmPack] loaded rollup.config.js with warnings
    [npmPack] (!) Unused external imports
    [npmPack] default imported from external module 'rollup' but never used
    [npmPack] 
    [npmPack] ./esm/avsClient.js → ./dist/arm-avs.js...
    [npmPack] created ./dist/arm-avs.js in 327ms
    [npmPack] npm notice 
    [npmPack] npm notice package: @azure/arm-avs@0.1.0
    [npmPack] npm notice === Tarball Contents === 
    [npmPack] npm notice 91.2kB  dist/arm-avs.js                              
    [npmPack] npm notice 29.8kB  dist/arm-avs.min.js                          
    [npmPack] npm notice 9.1kB   esm/operations/authorizations.js             
    [npmPack] npm notice 671B    esm/models/authorizationsMappers.js          
    [npmPack] npm notice 1.7kB   esm/avsClient.js                             
    [npmPack] npm notice 2.4kB   esm/avsClientContext.js                      
    [npmPack] npm notice 10.8kB  esm/operations/clusters.js                   
    [npmPack] npm notice 662B    esm/models/clustersMappers.js                
    [npmPack] npm notice 6.5kB   esm/operations/hcxEnterpriseSites.js         
    [npmPack] npm notice 667B    esm/models/hcxEnterpriseSitesMappers.js      
    [npmPack] npm notice 345B    esm/models/index.js                          
    [npmPack] npm notice 543B    esm/operations/index.js                      
    [npmPack] npm notice 2.6kB   esm/operations/locations.js                  
    [npmPack] npm notice 454B    esm/models/locationsMappers.js               
    [npmPack] npm notice 25.1kB  esm/models/mappers.js                        
    [npmPack] npm notice 2.2kB   esm/operations/operations.js                 
    [npmPack] npm notice 485B    esm/models/operationsMappers.js              
    [npmPack] npm notice 2.7kB   esm/models/parameters.js                     
    [npmPack] npm notice 12.6kB  esm/operations/privateClouds.js              
    [npmPack] npm notice 695B    esm/models/privateCloudsMappers.js           
    [npmPack] npm notice 961B    rollup.config.js                             
    [npmPack] npm notice 1.6kB   package.json                                 
    [npmPack] npm notice 457B    tsconfig.json                                
    [npmPack] npm notice 187.1kB dist/arm-avs.js.map                          
    [npmPack] npm notice 26.7kB  dist/arm-avs.min.js.map                      
    [npmPack] npm notice 2.4kB   esm/operations/authorizations.d.ts.map       
    [npmPack] npm notice 4.3kB   esm/operations/authorizations.js.map         
    [npmPack] npm notice 366B    esm/models/authorizationsMappers.d.ts.map    
    [npmPack] npm notice 379B    esm/models/authorizationsMappers.js.map      
    [npmPack] npm notice 767B    esm/avsClient.d.ts.map                       
    [npmPack] npm notice 983B    esm/avsClient.js.map                         
    [npmPack] npm notice 484B    esm/avsClientContext.d.ts.map                
    [npmPack] npm notice 1.4kB   esm/avsClientContext.js.map                  
    [npmPack] npm notice 2.8kB   esm/operations/clusters.d.ts.map             
    [npmPack] npm notice 5.3kB   esm/operations/clusters.js.map               
    [npmPack] npm notice 361B    esm/models/clustersMappers.d.ts.map          
    [npmPack] npm notice 374B    esm/models/clustersMappers.js.map            
    [npmPack] npm notice 2.8kB   esm/operations/hcxEnterpriseSites.d.ts.map   
    [npmPack] npm notice 3.7kB   esm/operations/hcxEnterpriseSites.js.map     
    [npmPack] npm notice 374B    esm/models/hcxEnterpriseSitesMappers.d.ts.map
    [npmPack] npm notice 387B    esm/models/hcxEnterpriseSitesMappers.js.map  
    [npmPack] npm notice 12.2kB  esm/models/index.d.ts.map                    
    [npmPack] npm notice 248B    esm/operations/index.d.ts.map                
    [npmPack] npm notice 126B    esm/models/index.js.map                      
    [npmPack] npm notice 263B    esm/operations/index.js.map                  
    [npmPack] npm notice 1.1kB   esm/operations/locations.d.ts.map            
    [npmPack] npm notice 1.5kB   esm/operations/locations.js.map              
    [npmPack] npm notice 220B    esm/models/locationsMappers.d.ts.map         
    [npmPack] npm notice 233B    esm/models/locationsMappers.js.map           
    [npmPack] npm notice 1.5kB   esm/models/mappers.d.ts.map                  
    [npmPack] npm notice 14.4kB  esm/models/mappers.js.map                    
    [npmPack] npm notice 1.0kB   esm/operations/operations.d.ts.map           
    [npmPack] npm notice 1.4kB   esm/operations/operations.js.map             
    [npmPack] npm notice 235B    esm/models/operationsMappers.d.ts.map        
    [npmPack] npm notice 248B    esm/models/operationsMappers.js.map          
    [npmPack] npm notice 639B    esm/models/parameters.d.ts.map               
    [npmPack] npm notice 2.0kB   esm/models/parameters.js.map                 
    [npmPack] npm notice 3.7kB   esm/operations/privateClouds.d.ts.map        
    [npmPack] npm notice 6.6kB   esm/operations/privateClouds.js.map          
    [npmPack] npm notice 390B    esm/models/privateCloudsMappers.d.ts.map     
    [npmPack] npm notice 403B    esm/models/privateCloudsMappers.js.map       
    [npmPack] npm notice 3.0kB   README.md                                    
    [npmPack] npm notice 7.1kB   esm/operations/authorizations.d.ts           
    [npmPack] npm notice 13.1kB  src/operations/authorizations.ts             
    [npmPack] npm notice 361B    esm/models/authorizationsMappers.d.ts        
    [npmPack] npm notice 657B    src/models/authorizationsMappers.ts          
    [npmPack] npm notice 1.1kB   esm/avsClient.d.ts                           
    [npmPack] npm notice 1.8kB   src/avsClient.ts                             
    [npmPack] npm notice 754B    esm/avsClientContext.d.ts                    
    [npmPack] npm notice 2.3kB   src/avsClientContext.ts                      
    [npmPack] npm notice 7.6kB   esm/operations/clusters.d.ts                 
    [npmPack] npm notice 14.3kB  src/operations/clusters.ts                   
    [npmPack] npm notice 352B    esm/models/clustersMappers.d.ts              
    [npmPack] npm notice 656B    src/models/clustersMappers.ts                
    [npmPack] npm notice 7.8kB   esm/operations/hcxEnterpriseSites.d.ts       
    [npmPack] npm notice 13.9kB  src/operations/hcxEnterpriseSites.ts         
    [npmPack] npm notice 357B    esm/models/hcxEnterpriseSitesMappers.d.ts    
    [npmPack] npm notice 649B    src/models/hcxEnterpriseSitesMappers.ts      
    [npmPack] npm notice 32.6kB  esm/models/index.d.ts                        
    [npmPack] npm notice 227B    esm/operations/index.d.ts                    
    [npmPack] npm notice 31.1kB  src/models/index.ts                          
    [npmPack] npm notice 511B    src/operations/index.ts                      
    [npmPack] npm notice 2.1kB   esm/operations/locations.d.ts                
    [npmPack] npm notice 4.5kB   src/operations/locations.ts                  
    [npmPack] npm notice 144B    esm/models/locationsMappers.d.ts             
    [npmPack] npm notice 421B    src/models/locationsMappers.ts               
    [npmPack] npm notice 1.8kB   esm/models/mappers.d.ts                      

@openapi-sdkautomation
Copy link

openapi-sdkautomation bot commented Jun 16, 2020

azure-sdk-for-net - Release

️✔️ succeeded [Logs] [Expand Details]

@azure-pipelines
Copy link

Azure Pipelines successfully started running 1 pipeline(s).

@openapi-sdkautomation
Copy link

openapi-sdkautomation bot commented Jun 16, 2020

azure-sdk-for-python-track2 - Release

No readme.md specification configuration files were found that are associated with the files modified in this pull request, or swagger_to_sdk section in readme.md is not configured

@azure-pipelines
Copy link

Azure Pipelines successfully started running 1 pipeline(s).

@ctaggart
Copy link
Contributor Author

@qianwens, can you please review and merge if approved?

@dw511214992
Copy link
Member

Hi @ctaggart Please check the comment. Thank you

@azure-pipelines
Copy link

Azure Pipelines successfully started running 1 pipeline(s).

@azure-pipelines
Copy link

Azure Pipelines successfully started running 1 pipeline(s).

@azure-pipelines
Copy link

Azure Pipelines successfully started running 1 pipeline(s).

@azure-pipelines
Copy link

Azure Pipelines successfully started running 1 pipeline(s).

@pilor pilor added the ARMChangesRequested <valid label in PR review process>add this label when require changes after ARM review label Jun 30, 2020
@azure-pipelines
Copy link

Azure Pipelines successfully started running 1 pipeline(s).

@ctaggart
Copy link
Contributor Author

ctaggart commented Jul 1, 2020

@pilor, thanks for the feedback. It has all been resolved. Can we get this approved and merged now?

@pilor pilor added ARMSignedOff <valid label in PR review process>add this label when ARM approve updates after review and removed ARMChangesRequested <valid label in PR review process>add this label when require changes after ARM review labels Jul 1, 2020
Copy link
Member

@qianwens qianwens left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

:shipit:

@qianwens qianwens merged commit 6c9921e into Azure:master Jul 2, 2020
"clusterName": "cluster1",
"cluster": {
"sku": {
"name": "AV20"
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is it possible to change to "av20'? Because in response it is "av20" after testing.

"privateCloud": {
"location": "eastus2",
"sku": {
"name": "AV36"
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is it possible to change to "av36'? Because in response it is "av36" after testing.

@leedouglas leedouglas mentioned this pull request Sep 21, 2020
10 tasks
00Kai0 pushed a commit to 00Kai0/azure-rest-api-specs that referenced this pull request Oct 12, 2020
* add Microsot.AVS 2020-03-20 API spec

* fix spelling

* prettier

* empty object {} passed in to create

* multi-api for Java & Go

* prettier

* review preview for go

* mark properties required

* add tags to PrivateCloudUpdate
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
ARMSignedOff <valid label in PR review process>add this label when ARM approve updates after review
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants