Potential issue in sdk/src/azure/iot/az_iot_hub_client_c2d.c: Return Value Not Checked from Function Call

[monocle-ai]

In this codebase, you often check the return value of the implicated function when calling it, but in this instance, it appears that you didn’t. Using a consistent return value checking and/or error handling approach can improve code robustness and readability.

1 instance of this defect were found in the following locations:

---

Instance 1
File : sdk/src/azure/iot/az_iot_hub_client_c2d.c
Enclosing Function : az_iot_hub_client_c2d_parse_received_topic
Function : _az_span_token

azure-sdk-for-c/sdk/src/azure/iot/az_iot_hub_client_c2d.c

Line 31 in 5e9d7b9

_az_span_token(received_topic, c2d_topic_suffix, &remainder, &index);

Code extract:

  int32_t index = 0;
  az_span remainder;
  _az_span_token(received_topic, c2d_topic_suffix, &remainder, &index); <------ HERE
  if (index == -1)
  {

How can I fix it?
Correct reference usage found in sdk/src/azure/iot/az_iot_provisioning_client.c at line 545.

azure-sdk-for-c/sdk/src/azure/iot/az_iot_provisioning_client.c

Line 545 in 5e9d7b9

int_slice = _az_span_token(remainder, AZ_SPAN_FROM_STR("&"), &remainder, &index);

Code extract:

  if (idx != -1)
  {
    remainder = az_span_slice_to_end(remainder, idx + az_span_size(retry_after));
    int_slice = _az_span_token(remainder, AZ_SPAN_FROM_STR("&"), &remainder, &index); <------ HERE

    _az_RETURN_IF_FAILED(az_span_atou32(int_slice, &out_response->retry_after_seconds));