Move tests to use azure pipeline credentials #5754

gearama · 2024-07-01T19:48:26Z

Run all pipelines for the following steps.

1. update GetTestCredentials method to use chained creds with pipeline first and default second
2. update the creds with the proper ENVs for pipeline auth and UseFederatedAuth in ci.yml -- except evenhubs and attestation -- ran all ci and ran live pieplines except attestation and eventhubs
3 remove the UseFederatedAuth from the individual cy.ymls and move it to the central one, set the storage one to false if needed.
No idea where the change should go , i asked but got no answer
i found the definition in ENG folder in 3 files :
- live.tests.yml,
- archetype-sdk-client.yml
- archetype-sdk-tests.yml
Some are in common code , thus the change would have to come down form the ENG repo through a merge into our repo
4 disable KV samples temporarily until we get a resolution to the auth dilema

Pull Request Checklist

Please leverage this checklist as a reminder to address commonly occurring feedback when submitting a pull request to make sure your PR can be reviewed quickly:

See the detailed list in the contributing guide.

gearama · 2024-07-01T21:00:03Z

/azp run cpp - keyvault - ci

azure-pipelines · 2024-07-01T21:00:31Z

Azure Pipelines failed to run 1 pipeline(s).

…nto testCreds

gearama · 2024-07-02T00:09:13Z

/azp run cpp - keyvault

azure-pipelines · 2024-07-02T00:09:40Z

Azure Pipelines successfully started running 1 pipeline(s).

gearama · 2024-07-02T17:31:15Z

/azp run cpp - attestation , cpp - keyvault

azure-pipelines · 2024-07-02T17:31:53Z

Azure Pipelines successfully started running 2 pipeline(s).

gearama · 2024-07-02T17:36:39Z

/azp run cpp - core, cpp - eventhubs, cpp - identity, cpp - storage, cpp - tables

azure-pipelines · 2024-07-02T17:37:38Z

Azure Pipelines successfully started running 5 pipeline(s).

gearama · 2024-07-02T19:29:50Z

/azp run cpp - keyvault

azure-pipelines · 2024-07-02T19:30:21Z

Azure Pipelines successfully started running 1 pipeline(s).

gearama · 2024-07-02T19:30:45Z

/azp run cpp - attestation, cpp - core, cpp - eventhubs, cpp - identity, cpp - storage, cpp - tables

azure-pipelines · 2024-07-02T19:32:02Z

Azure Pipelines successfully started running 6 pipeline(s).

gearama · 2024-07-02T20:47:45Z

/azp run cpp - keyvault

azure-pipelines · 2024-07-02T20:48:11Z

Azure Pipelines successfully started running 1 pipeline(s).

gearama · 2024-07-09T18:48:40Z

/azp run cpp - keyvault, cpp - core, cpp - storage, cpp - tables, cpp - identity

azure-pipelines · 2024-07-09T18:49:47Z

Azure Pipelines successfully started running 5 pipeline(s).

gearama · 2024-07-10T18:52:30Z

to record this for posterity ( since i'll have to redo the build ) this includes all CI and LIVE pipelines

only mac os failures dur to vcpkg

sdk/identity/azure-identity/samples/CMakeLists.txt

antkmsft

I thought the plan was to add AzurePipelinesCredential into the list of sources for DefaultAzureCredential?

BTW, how do the rest of samples succeed now, if they are still using DAC?

ahsonkhan · 2024-07-10T19:23:18Z

eng/pipelines/templates/jobs/live.tests.yml

-    - bash: |
-        IFS=$'\n'
-        if [[ -f "./${{ parameters.ServiceDirectory }}-samples.txt" ]]; then
-          for sample in `cat ./${{ parameters.ServiceDirectory }}-samples.txt`
-          do
-            export AZURE_CLIENT_ID=$(${{parameters.ServiceDirectory}}_CLIENT_ID)
-            export AZURE_TENANT_ID=$(${{parameters.ServiceDirectory}}_TENANT_ID)


What's motivating this change to move this as an else?

the if statement is IF use AzrurePipelineCredentials define these ENVs , ti was upside down

@weshaggard since Daniel is OOF, can you please help review the changes in this live.tests.yml file. I think it could benefit from an extra set of eyes to make sure it is as expected :)

it was very easy to check , before my change the build the live tests were failing, after it was working
and if you read the line right above it you see the if statement

It looks correct assuming you want to continue to run the samples via default credentials instead of with pipeline credentials.

Daniel was aware of the change, i talked to him before making it

[7/3 10:01 AM] George Arama
from what i see in the live.tests.yml the

${{ if parameters.UseFederatedAuth }}:
.....
-${{ else }}:
..
$env:AZURESUBSCRIPTION_CLIENT_ID = $account.Id

$env:AZURESUBSCRIPTION_TENANT_ID = $account.Tenants

...

the variables get defined when not using federated auth on the False branch

[7/3 10:24 AM] George Arama
in the live tests yaml the if/else branches for the run samples are flipped , i'm testing my fix for it

[7/3 11:13 AM] George Arama
looks like ti's working now as expected

sdk/core/azure-core-test/inc/azure/core/test/test_base.hpp

sdk/keyvault/azure-security-keyvault-keys/README.md

sdk/storage/README.md

sdk/keyvault/azure-security-keyvault-secrets/CMakeLists.txt

ahsonkhan · 2024-07-10T19:31:04Z

sdk/identity/azure-identity/samples/CMakeLists.txt

+#add_executable(default_azure_credential_sample default_azure_credential.cpp)
+#target_link_libraries(default_azure_credential_sample PRIVATE azure-identity service)
+#target_include_directories(default_azure_credential_sample PRIVATE .)
+#create_per_service_target_build_for_sample(identity default_azure_credential_sample)


Please explain why we are commenting all the samples out.

identity samples that don't run due to creds issues in live

I am not sure I understand the issue.

It's reasonable for us to disable building/running the samples if we know the problem and have a plan to update it (even in a separate, follow-up PR).

Can you share the error you were seeing or the link to the failing pipeline that required us to comment these out?

Looking at the pipelines that build and run Identity samples, they seem to pass from this PR, without commenting them out:
#5785

https://dev.azure.com/azure-sdk/internal/_build/results?buildId=3955376&view=logs&j=ea109acd-b7d3-5ded-4f2b-e0ac8b0c5651&t=88917f58-d2f9-5f14-5936-80f13f049405

https://dev.azure.com/azure-sdk/internal/_build/results?buildId=3955376&view=logs&j=fad7e5d9-ee9d-5455-29cf-12d77fc3497f&t=e819b337-613f-5b6a-fedf-c6b8af28994f

eng/pipelines/templates/stages/archetype-sdk-client.yml

antkmsft

Approving to unbock the CI

…nto testCreds

sdk/identity/azure-identity/test/ut/azure_pipelines_credential_test.cpp

ahsonkhan

We certainly need to revisit the decision to comment out the identity samples and see how we can turn them back on.
I don't fully understand the changes to live.tests.yml that flip the if/else and the implications of doing so, but it seems reasonable from a quick glance.

Approving to unblock the change since we can revisit this discussion in a follow-up.

antkmsft · 2024-07-12T00:36:01Z

/check-enforcer override

* Update vcpkg SHA (#5757) Co-authored-by: Anton Kolesnyk <antkmsft@users.noreply.github.com> * Sync eng/common directory with azure-sdk-tools for PR 8528 (#5755) * Fix default value for env vars in build-test-resource-config template * Add empty pool condition --------- Co-authored-by: Ben Broderick Phillips <bebroder@microsoft.com> * Sync eng/common directory with azure-sdk-tools for PR 8516 (#5752) * Ensure subConfigFiles is not an empty string * Skip instances where $file is an empty string --------- Co-authored-by: Daniel Jurek <djurek@microsoft.com> * Sync eng/common directory with azure-sdk-tools for PR 8549 (#5762) * commit the file changes so that we can see them running * use standalone tool --------- Co-authored-by: Scott Beddall (from Dev Box) <scbedd@microsoft.com> * Disable codeql as it is causing build issues (#5761) All the other languages have disabled codeql and we are now hitting blocking issues when running codeql on macos (https://dev.azure.com/twcdot/Data/_workitems/edit/138580) and even on the other OS's the configuration causes the builds to run for a long time. * Delete eng/common/InterdependencyGraph.html which is unused. (#5763) Co-authored-by: Wes Haggard <weshaggard@users.noreply.github.com> * Add missing include (#5766) * Update GitHubEventProcessor version to 1.0.0-dev.20240708.1 (#5768) Co-authored-by: James Suplizio <jasupliz@microsoft.com> * Provide a walkthrough for how to install the Azure SDK packages in a VS (#5751) MSBuild project via vcpkg. * Sync eng/common directory with azure-sdk-tools for PR 8558 (#5764) * Support storage network access and worm removal in remove test resources script * Move storage network access script to common resource helpers file * Improve storage container deletion resilience * Plumb through pool variable to live test cleanup template * Add sleep for network rule application --------- Co-authored-by: Ben Broderick Phillips <bebroder@microsoft.com> * add the ability to override default succeeded() conditioning by parameter (#5780) Co-authored-by: Scott Beddall <scbedd@microsoft.com> * Support regex/negative regex filters for stress test discovery. Add storage env defaults (#5779) Co-authored-by: Ben Broderick Phillips <bebroder@microsoft.com> * Update vcpkg SHA (#5772) * Show-FailureLogs to include vcpkg build failure logs (#5776) * Show-FailureLogs to include vcpkg build failure logs * Add comment * Add proper array syntax * Use proper syntax to create an array even if there's only a single element Co-authored-by: Ben Broderick Phillips <ben@benbp.net> --------- Co-authored-by: Anton Kolesnyk <antkmsft@users.noreply.github.com> Co-authored-by: Ben Broderick Phillips <ben@benbp.net> * Turn federated auth on for Identity tests. (#5785) * Turn federated auth on for Identity tests. * Update test resources json. * Move tests to use azure pipeline credentials (#5754) * test1 * hgdfchg * remove the remnants of azure client secret * test KV with federated auth * UseFederatedAuth * fdsa * kv template with managed * try try again * retry permissions * add net acls * blunt force replace the resource json * put back stuff * trey again with new method * attempt * missed something * flip if else * Temporarily use empty sub config file path for preview cloud * remove client secret * try to fix the identity tests * live skip failing tests and return in samples * samples for identity fix * disable failing samples in identity * fix winhttp failing test * comment out code * remove managed identity * restore version from main * revert readme changes * PR comments * test 2 * clang * attempt default creds with pipeline chanined * clangs * identity test and clangs * oops * live * cleanup * reter * test * revert the DAC change * missed one * taking the samples to a farm upstate * PR comments * Fix bad merge --------- Co-authored-by: Daniel Jurek <djurek@microsoft.com> Co-authored-by: Anton Kolesnyk <antkmsft@users.noreply.github.com> Co-authored-by: Anton Kolesnyk <41349689+antkmsft@users.noreply.github.com> * Update the RetryPolicy for the GA release, keeping ShouldRetry extension point hidden. (#5771) * Update the RetryPolicy for the GA release, keeping ShouldRetry extension point hidden. * Mark test helper virtual functions private, so they aren't accessible/callable by callers. * Update the changelog. * Update CL. * Azure Core July GA Release (#5792) Co-authored-by: Anton Kolesnyk <antkmsft@users.noreply.github.com> * Revert commits related to the new RetryPolicy method (#5793) * Revert "Update the RetryPolicy for the GA release, keeping ShouldRetry extension point hidden. (#5771)" This reverts commit 9ccd206. * Revert "Update the RetryPolicy and ShouldRetry customization logic to allow loosening the retry condition. (#5656)" This reverts commit f1d9552. * Do not remove changelog entry from a previous beta release * Revert "Add a virtual ShouldRetry method to the RetryPolicy for customization. (#5584)" This reverts commit ab90ef6. --------- Co-authored-by: Anton Kolesnyk <antkmsft@users.noreply.github.com> * Sync eng/common directory with azure-sdk-tools for PR 8598 (#5777) * Set storage account test resources to disable blob public access * Skip adding network rules to storage accounts that don't need them during cleanup * Add succeeded check to set pipeline subnet info step * Disable network firewall by default in resource creation/removal --------- Co-authored-by: Ben Broderick Phillips <bebroder@microsoft.com> * Increment package version after release of azure-core (#5794) * Acknowledge community contribution in the changelog (#5797) * Mention community contribution in the changelog * cspell * Remove double spaces --------- Co-authored-by: Anton Kolesnyk <antkmsft@users.noreply.github.com> --------- Co-authored-by: Anton Kolesnyk <41349689+antkmsft@users.noreply.github.com> Co-authored-by: Anton Kolesnyk <antkmsft@users.noreply.github.com> Co-authored-by: Azure SDK Bot <53356347+azure-sdk@users.noreply.github.com> Co-authored-by: Ben Broderick Phillips <bebroder@microsoft.com> Co-authored-by: Daniel Jurek <djurek@microsoft.com> Co-authored-by: Scott Beddall (from Dev Box) <scbedd@microsoft.com> Co-authored-by: Wes Haggard <weshaggard@users.noreply.github.com> Co-authored-by: Robert Schulze <robert@clickhouse.com> Co-authored-by: James Suplizio <jasupliz@microsoft.com> Co-authored-by: Ahson Khan <ahson_ahmedk@yahoo.com> Co-authored-by: Ben Broderick Phillips <ben@benbp.net> Co-authored-by: George Arama <50641385+gearama@users.noreply.github.com>

* Update vcpkg SHA (Azure#5757) Co-authored-by: Anton Kolesnyk <antkmsft@users.noreply.github.com> * Sync eng/common directory with azure-sdk-tools for PR 8528 (Azure#5755) * Fix default value for env vars in build-test-resource-config template * Add empty pool condition --------- Co-authored-by: Ben Broderick Phillips <bebroder@microsoft.com> * Sync eng/common directory with azure-sdk-tools for PR 8516 (Azure#5752) * Ensure subConfigFiles is not an empty string * Skip instances where $file is an empty string --------- Co-authored-by: Daniel Jurek <djurek@microsoft.com> * Sync eng/common directory with azure-sdk-tools for PR 8549 (Azure#5762) * commit the file changes so that we can see them running * use standalone tool --------- Co-authored-by: Scott Beddall (from Dev Box) <scbedd@microsoft.com> * Disable codeql as it is causing build issues (Azure#5761) All the other languages have disabled codeql and we are now hitting blocking issues when running codeql on macos (https://dev.azure.com/twcdot/Data/_workitems/edit/138580) and even on the other OS's the configuration causes the builds to run for a long time. * Delete eng/common/InterdependencyGraph.html which is unused. (Azure#5763) Co-authored-by: Wes Haggard <weshaggard@users.noreply.github.com> * Add missing include (Azure#5766) * Update GitHubEventProcessor version to 1.0.0-dev.20240708.1 (Azure#5768) Co-authored-by: James Suplizio <jasupliz@microsoft.com> * Provide a walkthrough for how to install the Azure SDK packages in a VS (Azure#5751) MSBuild project via vcpkg. * Sync eng/common directory with azure-sdk-tools for PR 8558 (Azure#5764) * Support storage network access and worm removal in remove test resources script * Move storage network access script to common resource helpers file * Improve storage container deletion resilience * Plumb through pool variable to live test cleanup template * Add sleep for network rule application --------- Co-authored-by: Ben Broderick Phillips <bebroder@microsoft.com> * add the ability to override default succeeded() conditioning by parameter (Azure#5780) Co-authored-by: Scott Beddall <scbedd@microsoft.com> * Support regex/negative regex filters for stress test discovery. Add storage env defaults (Azure#5779) Co-authored-by: Ben Broderick Phillips <bebroder@microsoft.com> * Update vcpkg SHA (Azure#5772) * Show-FailureLogs to include vcpkg build failure logs (Azure#5776) * Show-FailureLogs to include vcpkg build failure logs * Add comment * Add proper array syntax * Use proper syntax to create an array even if there's only a single element Co-authored-by: Ben Broderick Phillips <ben@benbp.net> --------- Co-authored-by: Anton Kolesnyk <antkmsft@users.noreply.github.com> Co-authored-by: Ben Broderick Phillips <ben@benbp.net> * Turn federated auth on for Identity tests. (Azure#5785) * Turn federated auth on for Identity tests. * Update test resources json. * Move tests to use azure pipeline credentials (Azure#5754) * test1 * hgdfchg * remove the remnants of azure client secret * test KV with federated auth * UseFederatedAuth * fdsa * kv template with managed * try try again * retry permissions * add net acls * blunt force replace the resource json * put back stuff * trey again with new method * attempt * missed something * flip if else * Temporarily use empty sub config file path for preview cloud * remove client secret * try to fix the identity tests * live skip failing tests and return in samples * samples for identity fix * disable failing samples in identity * fix winhttp failing test * comment out code * remove managed identity * restore version from main * revert readme changes * PR comments * test 2 * clang * attempt default creds with pipeline chanined * clangs * identity test and clangs * oops * live * cleanup * reter * test * revert the DAC change * missed one * taking the samples to a farm upstate * PR comments * Fix bad merge --------- Co-authored-by: Daniel Jurek <djurek@microsoft.com> Co-authored-by: Anton Kolesnyk <antkmsft@users.noreply.github.com> Co-authored-by: Anton Kolesnyk <41349689+antkmsft@users.noreply.github.com> * Update the RetryPolicy for the GA release, keeping ShouldRetry extension point hidden. (Azure#5771) * Update the RetryPolicy for the GA release, keeping ShouldRetry extension point hidden. * Mark test helper virtual functions private, so they aren't accessible/callable by callers. * Update the changelog. * Update CL. * Azure Core July GA Release (Azure#5792) Co-authored-by: Anton Kolesnyk <antkmsft@users.noreply.github.com> * Revert commits related to the new RetryPolicy method (Azure#5793) * Revert "Update the RetryPolicy for the GA release, keeping ShouldRetry extension point hidden. (Azure#5771)" This reverts commit 9ccd206. * Revert "Update the RetryPolicy and ShouldRetry customization logic to allow loosening the retry condition. (Azure#5656)" This reverts commit f1d9552. * Do not remove changelog entry from a previous beta release * Revert "Add a virtual ShouldRetry method to the RetryPolicy for customization. (Azure#5584)" This reverts commit ab90ef6. --------- Co-authored-by: Anton Kolesnyk <antkmsft@users.noreply.github.com> * Sync eng/common directory with azure-sdk-tools for PR 8598 (Azure#5777) * Set storage account test resources to disable blob public access * Skip adding network rules to storage accounts that don't need them during cleanup * Add succeeded check to set pipeline subnet info step * Disable network firewall by default in resource creation/removal --------- Co-authored-by: Ben Broderick Phillips <bebroder@microsoft.com> * Increment package version after release of azure-core (Azure#5794) * Acknowledge community contribution in the changelog (Azure#5797) * Mention community contribution in the changelog * cspell * Remove double spaces --------- Co-authored-by: Anton Kolesnyk <antkmsft@users.noreply.github.com> --------- Co-authored-by: Anton Kolesnyk <41349689+antkmsft@users.noreply.github.com> Co-authored-by: Anton Kolesnyk <antkmsft@users.noreply.github.com> Co-authored-by: Azure SDK Bot <53356347+azure-sdk@users.noreply.github.com> Co-authored-by: Ben Broderick Phillips <bebroder@microsoft.com> Co-authored-by: Daniel Jurek <djurek@microsoft.com> Co-authored-by: Scott Beddall (from Dev Box) <scbedd@microsoft.com> Co-authored-by: Wes Haggard <weshaggard@users.noreply.github.com> Co-authored-by: Robert Schulze <robert@clickhouse.com> Co-authored-by: James Suplizio <jasupliz@microsoft.com> Co-authored-by: Ahson Khan <ahson_ahmedk@yahoo.com> Co-authored-by: Ben Broderick Phillips <ben@benbp.net> Co-authored-by: George Arama <50641385+gearama@users.noreply.github.com>

* Storage/STG95 Files OAuth - full data plane support (#5759) * File OAuth * Remove comment * update test record * [Storage STG95 Branch] Merge Main to fix cmake build error (#5796) * Update vcpkg SHA (#5757) Co-authored-by: Anton Kolesnyk <antkmsft@users.noreply.github.com> * Sync eng/common directory with azure-sdk-tools for PR 8528 (#5755) * Fix default value for env vars in build-test-resource-config template * Add empty pool condition --------- Co-authored-by: Ben Broderick Phillips <bebroder@microsoft.com> * Sync eng/common directory with azure-sdk-tools for PR 8516 (#5752) * Ensure subConfigFiles is not an empty string * Skip instances where $file is an empty string --------- Co-authored-by: Daniel Jurek <djurek@microsoft.com> * Sync eng/common directory with azure-sdk-tools for PR 8549 (#5762) * commit the file changes so that we can see them running * use standalone tool --------- Co-authored-by: Scott Beddall (from Dev Box) <scbedd@microsoft.com> * Disable codeql as it is causing build issues (#5761) All the other languages have disabled codeql and we are now hitting blocking issues when running codeql on macos (https://dev.azure.com/twcdot/Data/_workitems/edit/138580) and even on the other OS's the configuration causes the builds to run for a long time. * Delete eng/common/InterdependencyGraph.html which is unused. (#5763) Co-authored-by: Wes Haggard <weshaggard@users.noreply.github.com> * Add missing include (#5766) * Update GitHubEventProcessor version to 1.0.0-dev.20240708.1 (#5768) Co-authored-by: James Suplizio <jasupliz@microsoft.com> * Provide a walkthrough for how to install the Azure SDK packages in a VS (#5751) MSBuild project via vcpkg. * Sync eng/common directory with azure-sdk-tools for PR 8558 (#5764) * Support storage network access and worm removal in remove test resources script * Move storage network access script to common resource helpers file * Improve storage container deletion resilience * Plumb through pool variable to live test cleanup template * Add sleep for network rule application --------- Co-authored-by: Ben Broderick Phillips <bebroder@microsoft.com> * add the ability to override default succeeded() conditioning by parameter (#5780) Co-authored-by: Scott Beddall <scbedd@microsoft.com> * Support regex/negative regex filters for stress test discovery. Add storage env defaults (#5779) Co-authored-by: Ben Broderick Phillips <bebroder@microsoft.com> * Update vcpkg SHA (#5772) * Show-FailureLogs to include vcpkg build failure logs (#5776) * Show-FailureLogs to include vcpkg build failure logs * Add comment * Add proper array syntax * Use proper syntax to create an array even if there's only a single element Co-authored-by: Ben Broderick Phillips <ben@benbp.net> --------- Co-authored-by: Anton Kolesnyk <antkmsft@users.noreply.github.com> Co-authored-by: Ben Broderick Phillips <ben@benbp.net> * Turn federated auth on for Identity tests. (#5785) * Turn federated auth on for Identity tests. * Update test resources json. * Move tests to use azure pipeline credentials (#5754) * test1 * hgdfchg * remove the remnants of azure client secret * test KV with federated auth * UseFederatedAuth * fdsa * kv template with managed * try try again * retry permissions * add net acls * blunt force replace the resource json * put back stuff * trey again with new method * attempt * missed something * flip if else * Temporarily use empty sub config file path for preview cloud * remove client secret * try to fix the identity tests * live skip failing tests and return in samples * samples for identity fix * disable failing samples in identity * fix winhttp failing test * comment out code * remove managed identity * restore version from main * revert readme changes * PR comments * test 2 * clang * attempt default creds with pipeline chanined * clangs * identity test and clangs * oops * live * cleanup * reter * test * revert the DAC change * missed one * taking the samples to a farm upstate * PR comments * Fix bad merge --------- Co-authored-by: Daniel Jurek <djurek@microsoft.com> Co-authored-by: Anton Kolesnyk <antkmsft@users.noreply.github.com> Co-authored-by: Anton Kolesnyk <41349689+antkmsft@users.noreply.github.com> * Update the RetryPolicy for the GA release, keeping ShouldRetry extension point hidden. (#5771) * Update the RetryPolicy for the GA release, keeping ShouldRetry extension point hidden. * Mark test helper virtual functions private, so they aren't accessible/callable by callers. * Update the changelog. * Update CL. * Azure Core July GA Release (#5792) Co-authored-by: Anton Kolesnyk <antkmsft@users.noreply.github.com> * Revert commits related to the new RetryPolicy method (#5793) * Revert "Update the RetryPolicy for the GA release, keeping ShouldRetry extension point hidden. (#5771)" This reverts commit 9ccd206. * Revert "Update the RetryPolicy and ShouldRetry customization logic to allow loosening the retry condition. (#5656)" This reverts commit f1d9552. * Do not remove changelog entry from a previous beta release * Revert "Add a virtual ShouldRetry method to the RetryPolicy for customization. (#5584)" This reverts commit ab90ef6. --------- Co-authored-by: Anton Kolesnyk <antkmsft@users.noreply.github.com> * Sync eng/common directory with azure-sdk-tools for PR 8598 (#5777) * Set storage account test resources to disable blob public access * Skip adding network rules to storage accounts that don't need them during cleanup * Add succeeded check to set pipeline subnet info step * Disable network firewall by default in resource creation/removal --------- Co-authored-by: Ben Broderick Phillips <bebroder@microsoft.com> * Increment package version after release of azure-core (#5794) * Acknowledge community contribution in the changelog (#5797) * Mention community contribution in the changelog * cspell * Remove double spaces --------- Co-authored-by: Anton Kolesnyk <antkmsft@users.noreply.github.com> --------- Co-authored-by: Anton Kolesnyk <41349689+antkmsft@users.noreply.github.com> Co-authored-by: Anton Kolesnyk <antkmsft@users.noreply.github.com> Co-authored-by: Azure SDK Bot <53356347+azure-sdk@users.noreply.github.com> Co-authored-by: Ben Broderick Phillips <bebroder@microsoft.com> Co-authored-by: Daniel Jurek <djurek@microsoft.com> Co-authored-by: Scott Beddall (from Dev Box) <scbedd@microsoft.com> Co-authored-by: Wes Haggard <weshaggard@users.noreply.github.com> Co-authored-by: Robert Schulze <robert@clickhouse.com> Co-authored-by: James Suplizio <jasupliz@microsoft.com> Co-authored-by: Ahson Khan <ahson_ahmedk@yahoo.com> Co-authored-by: Ben Broderick Phillips <ben@benbp.net> Co-authored-by: George Arama <50641385+gearama@users.noreply.github.com> * Storage/STG95 Premium Files Paid Burst (#5795) * paid burst * update record * Storeage/STG95 Files Binary ACE (#5824) * feature code * update test case to playback only * update records * fix cspell * update record * fix cspell * fix cspell * fix comments * Remove copy opreation rest code. * Storage/STG95 Support Sas StringToSign for debugging (#5830) * StringToSign * Update deprecate * Update Func name * ignore deprecated warning * Add missing ignore * fix clang format * Storage/STG95 Resolve Archboard Review Comments (#5856) * fix comments * fix comments * Add Create dir and upload from support (#5866) * merge test recordings * Remove other changes * Remove deprecated (#5873) * Remove others --------- Co-authored-by: Anton Kolesnyk <41349689+antkmsft@users.noreply.github.com> Co-authored-by: Anton Kolesnyk <antkmsft@users.noreply.github.com> Co-authored-by: Azure SDK Bot <53356347+azure-sdk@users.noreply.github.com> Co-authored-by: Ben Broderick Phillips <bebroder@microsoft.com> Co-authored-by: Daniel Jurek <djurek@microsoft.com> Co-authored-by: Scott Beddall (from Dev Box) <scbedd@microsoft.com> Co-authored-by: Wes Haggard <weshaggard@users.noreply.github.com> Co-authored-by: Robert Schulze <robert@clickhouse.com> Co-authored-by: James Suplizio <jasupliz@microsoft.com> Co-authored-by: Ahson Khan <ahson_ahmedk@yahoo.com> Co-authored-by: Ben Broderick Phillips <ben@benbp.net> Co-authored-by: George Arama <50641385+gearama@users.noreply.github.com>

test1

b5bb953

github-actions bot added Azure.Core Azure.Identity Event Hubs KeyVault Storage Storage Service (Queues, Blobs, Files) Tables labels Jul 1, 2024

gearama added 4 commits July 1, 2024 14:14

hgdfchg

e4c3ea2

remove the remnants of azure client secret

2c9810f

Merge branch 'main' of https://github.com/gearama/azure-sdk-for-cpp i…

023df7b

…nto testCreds

test KV with federated auth

2bd4ad2

UseFederatedAuth

e916110

gearama added 2 commits July 2, 2024 11:36

fdsa

c429beb

kv template with managed

718edf4

try try again

6c1d77f

retry permissions

7bff790

gearama requested a review from ahsonkhan July 9, 2024 18:44

RickWinter approved these changes Jul 10, 2024

View reviewed changes

antkmsft reviewed Jul 10, 2024

View reviewed changes

sdk/identity/azure-identity/samples/CMakeLists.txt Show resolved Hide resolved

antkmsft reviewed Jul 10, 2024

View reviewed changes

ahsonkhan reviewed Jul 10, 2024

View reviewed changes

antkmsft approved these changes Jul 10, 2024

View reviewed changes

gearama added 2 commits July 10, 2024 12:59

PR comments

56dc0e8

Merge branch 'main' of https://github.com/gearama/azure-sdk-for-cpp i…

80ed23c

…nto testCreds

ahsonkhan reviewed Jul 11, 2024

View reviewed changes

sdk/identity/azure-identity/test/ut/azure_pipelines_credential_test.cpp Outdated Show resolved Hide resolved

ahsonkhan mentioned this pull request Jul 11, 2024

Turn federated auth on for Identity tests. #5785

Merged

antkmsft and others added 3 commits July 11, 2024 16:31

Merge remote-tracking branch 'upstream/main' into HEAD

13d3170

Merge branch 'main' into testCreds

5d502b8

Fix bad merge

f717e6f

ahsonkhan approved these changes Jul 12, 2024

View reviewed changes

antkmsft enabled auto-merge (squash) July 12, 2024 00:36

antkmsft disabled auto-merge July 12, 2024 00:36

antkmsft enabled auto-merge (squash) July 12, 2024 00:37

antkmsft disabled auto-merge July 12, 2024 00:37

antkmsft enabled auto-merge (squash) July 12, 2024 00:38

antkmsft disabled auto-merge July 12, 2024 00:38

antkmsft merged commit 313fb0e into Azure:main Jul 12, 2024
263 checks passed

ahsonkhan mentioned this pull request Jul 15, 2024

Added ClientAssertionCredential to enable applications to authenticate with custom client assertions. #5789

Merged

ahsonkhan mentioned this pull request Jul 18, 2024

Re-enable running previously disabled samples using AzureCliCredential. #5818

Merged

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Move tests to use azure pipeline credentials #5754

Move tests to use azure pipeline credentials #5754

gearama commented Jul 1, 2024 •

edited

Loading

gearama commented Jul 1, 2024

azure-pipelines bot commented Jul 1, 2024

gearama commented Jul 2, 2024

azure-pipelines bot commented Jul 2, 2024

gearama commented Jul 2, 2024

azure-pipelines bot commented Jul 2, 2024

gearama commented Jul 2, 2024

azure-pipelines bot commented Jul 2, 2024

gearama commented Jul 2, 2024

azure-pipelines bot commented Jul 2, 2024

gearama commented Jul 2, 2024

azure-pipelines bot commented Jul 2, 2024

gearama commented Jul 2, 2024

azure-pipelines bot commented Jul 2, 2024

gearama commented Jul 9, 2024

azure-pipelines bot commented Jul 9, 2024

gearama commented Jul 10, 2024 •

edited

Loading

antkmsft left a comment

ahsonkhan Jul 10, 2024

gearama Jul 10, 2024

ahsonkhan Jul 10, 2024

gearama Jul 10, 2024

weshaggard Jul 10, 2024

gearama Jul 10, 2024

gearama Jul 10, 2024

ahsonkhan Jul 10, 2024

gearama Jul 10, 2024

ahsonkhan Jul 11, 2024

ahsonkhan Jul 11, 2024

antkmsft left a comment

ahsonkhan left a comment

antkmsft commented Jul 12, 2024

Move tests to use azure pipeline credentials #5754

Move tests to use azure pipeline credentials #5754

Conversation

gearama commented Jul 1, 2024 • edited Loading

Pull Request Checklist

gearama commented Jul 1, 2024

azure-pipelines bot commented Jul 1, 2024

gearama commented Jul 2, 2024

azure-pipelines bot commented Jul 2, 2024

gearama commented Jul 2, 2024

azure-pipelines bot commented Jul 2, 2024

gearama commented Jul 2, 2024

azure-pipelines bot commented Jul 2, 2024

gearama commented Jul 2, 2024

azure-pipelines bot commented Jul 2, 2024

gearama commented Jul 2, 2024

azure-pipelines bot commented Jul 2, 2024

gearama commented Jul 2, 2024

azure-pipelines bot commented Jul 2, 2024

gearama commented Jul 9, 2024

azure-pipelines bot commented Jul 9, 2024

gearama commented Jul 10, 2024 • edited Loading

antkmsft left a comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

antkmsft left a comment

Choose a reason for hiding this comment

ahsonkhan left a comment

Choose a reason for hiding this comment

antkmsft commented Jul 12, 2024

gearama commented Jul 1, 2024 •

edited

Loading

gearama commented Jul 10, 2024 •

edited

Loading