Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Azure Media Services, support for Azure AD authentication #1940

Merged
merged 18 commits into from
Oct 20, 2017
Merged

Azure Media Services, support for Azure AD authentication #1940

merged 18 commits into from
Oct 20, 2017

Conversation

rnrneverdies
Copy link
Contributor

ChangeLog

  • Update to Blob storage API version that supports 256MB PUT requests
  • Add Azure Active Directory (Azure AD) Authentication
    • Service principal with symmetric key scenario
    • Service principal with certificate scenario
    • User credentials with username and password scenario
  • Remove ACS Authentication
  • Fix Streaming Endpoints error handling

Emanuel Vecchio (Southworks SRL) and others added 17 commits September 19, 2017 17:12
Update api version + update sas token to support 256MB uploads
c7baa6f
Add Azure Ad authentication + Remove ACS authentication
1a17176
Add AzureAD authentication (fixes previous commit)
614fe62
Added missing configuration settings for AD tests (user credentials a…
e841a34 
…nd service principal certificate)
Fix integration tests + stabilization
ce317d6
Removed debug info in canUploadLargeBlockBlob test
7582304
Fix javadoc
52e6cf7
Update streaming endpoint create operation + Add integration test
ec1cb2f
Fix checkstyle issues
71dcddc
Fixed JavaDoc typo in MediaService class
8470faa
Fix checkstyle issues Azure#2
c2e4410
t push Merge branch 'azure-ad-features' of https://github.com/southwo…
0e39b9d 
…rkscom/azure-sdk-for-java into azure-ad-features
Fix checkstyle issues Azure#3
a50e0e6
Fix checkstyles Azure#4
fd32c3f
Minor refactor in AzureAdTokenProviderTest class
5ba7af1
Fix task integration test assert
fea8578
Add TokenProvider interface
1a825c4
@jianghaolu
Copy link
Contributor

@azuresdkci retest this please

@jianghaolu
Copy link
Contributor

@azuresdkci test this please

@jianghaolu
Copy link
Contributor

Hi @rnrneverdies
Apologize for getting back to you late! The PR looks great and almost passes CI except for a couple style errors. - Style errors like missing javadoc tags can prevent you from publishing to Maven. If you can run mvn checkstyle:check locally on media services and fix those issues, we can get this PR merged right away.

@rnrneverdies
Copy link
Contributor Author

rnrneverdies commented Oct 20, 2017 •
edited
Loading

Hi @jianghaolu,
I didn't find any missing Javadoc but unwanted tab characters which were causing checkstyle to fail. I've replaced them with spaces and the build works well now.
Let me know if you have additional feedback.
Regards.

@jianghaolu
Copy link
Contributor

Thanks @rnrneverdies - merging

@jianghaolu jianghaolu merged commit 38300c2 into Azure:0.9 Oct 20, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jianghaolu jianghaolu Awaiting requested review from jianghaolu

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@rnrneverdies @jianghaolu