Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix 252: Table: Need to support signing when URL contains escapable characters #31

Merged
merged 5 commits into from
Apr 4, 2012

Conversation

jcookems
Copy link
Contributor

No description provided.

Changed catch statement to perform a reasonable fallback if the URLEncoder call fails.
Added missing imports statements.
@jcookems
Copy link
Contributor Author

jcookems commented Apr 3, 2012

Added a unit test and addressed the review feedback.

service.deleteEntity(TEST_TABLE_2, result3.getEntity().getPartitionKey(), result3.getEntity().getRowKey());
service.deleteEntity(TEST_TABLE_2, result4.getEntity().getPartitionKey(), result4.getEntity().getRowKey());

// Assert
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Do we need to assert the success of the deletion by validating the original entities do not exist any more?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good idea. I'll add that.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

See below for the new asserts

jcookems added a commit that referenced this pull request Apr 4, 2012
Fix 252: Table: Need to support signing when URL contains escapable characters
@jcookems jcookems merged commit 7ea8763 into Azure:dev-bookmark Apr 4, 2012
joostdenijs pushed a commit to joostdenijs/azure-sdk-for-java that referenced this pull request Jan 18, 2013
implement the get version of MediaProcessorType
joostdenijs pushed a commit to joostdenijs/azure-sdk-for-java that referenced this pull request Jan 18, 2013
joostdenijs pushed a commit to joostdenijs/azure-sdk-for-java that referenced this pull request Jan 18, 2013
Remove wrapper code that corresponds to non-existant processors
gcheng pushed a commit that referenced this pull request Apr 12, 2013
andrerod pushed a commit that referenced this pull request May 9, 2014
jianghaolu pushed a commit to jianghaolu/azure-sdk-for-java that referenced this pull request Apr 5, 2017
Fix 252: Table: Need to support signing when URL contains escapable characters
jianghaolu pushed a commit to jianghaolu/azure-sdk-for-java that referenced this pull request Apr 5, 2017
g2vinay pushed a commit to g2vinay/azure-sdk-for-java that referenced this pull request Feb 12, 2019
Re-release for corrupt signing
g2vinay pushed a commit to g2vinay/azure-sdk-for-java that referenced this pull request Mar 4, 2019
g2vinay pushed a commit to g2vinay/azure-sdk-for-java that referenced this pull request May 30, 2019
samvaity added a commit to samvaity/azure-sdk-for-java that referenced this pull request Dec 18, 2019
navalev pushed a commit to navalev/azure-sdk-for-java that referenced this pull request Dec 24, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants