Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

health insights sdk for java #33948

Merged
merged 29 commits into from
Mar 30, 2023
Merged

health insights sdk for java #33948

merged 29 commits into from
Mar 30, 2023

Conversation

asaflevi-ms
Copy link
Member

Description

First PR for Health Insights - First Public preview

Please add an informative description that covers that changes made by the pull request and link all relevant issues.

If an SDK is being regenerated based on a new swagger spec, a link to the pull request containing these swagger spec changes has been included above.

All SDK Contribution checklist:

  • The pull request does not introduce [breaking changes]
  • CHANGELOG is updated for new features, bug fixes or other significant changes.
  • I have read the contribution guidelines.

General Guidelines and Best Practices

  • Title of the pull request is clear and informative.
  • There are a small number of commits, each of which have an informative message. This means that previously merged commits do not appear in the history of the PR. For more information on cleaning up the commits in your PR, see this page.

Testing Guidelines

  • Pull request includes test coverage for the included changes.

@asaflevi-ms
Copy link
Member Author

/azp run prepare-pipelines

@azure-pipelines
Copy link

Azure Pipelines successfully started running 1 pipeline(s).

@asaflevi-ms
Copy link
Member Author

Hi
@josefree , @srnagar , @anuchandy , @conniey , @lmolkova , @JonathanGiles
This is my first pr fro Health Insights (first public preview).
We are targeting public preview release end of March and would like to be ready as soon as possible for that release.
I will be happy to get your comments on this PR.
CADL PR: Azure/azure-rest-api-specs#22990

JonathanGiles
JonathanGiles reviewed Mar 14, 2023
View reviewed changes
Copy link
Member

@JonathanGiles JonathanGiles left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Did you have APIView links we should also review?

sdk/healthinsights/azure-health-insights-cancerprofiling/CHANGELOG.md Outdated Show resolved Hide resolved
@asaflevi-ms
Copy link
Member Author

Hi @JonathanGiles

Links to APIView:
https://apiview.dev/Assemblies/Review/0b97445ff704422abfa9df4206a20efd
https://apiview.dev/Assemblies/Review/0296d6261b444f2691f3d2f020ebb97b

@weshaggard
Copy link
Member

@asaflevi-ms for my information how was this library generated? What steps did you use and what documentation did you reference?

@asaflevi-ms
Copy link
Member Author

@asaflevi-ms for my information how was this library generated? What steps did you use and what documentation did you reference?

Generated with Cadl: Azure/azure-rest-api-specs#22990

Used Cadl documentation and help from cadl/sdk support teams

@azure-sdk
Copy link
Collaborator

azure-sdk commented Mar 15, 2023 •
edited
Loading

API change check

APIView has identified API level changes in this PR and created following API reviews.

azure-health-insights-clinicalmatching
azure-health-insights-cancerprofiling

@weshaggard
Copy link
Member

Used Cadl documentation and help from cadl/sdk support teams

Could you provide a link to the docs you are using? I'm mostly trying to make sure we have the right docs for folks to be successful.

haolingdong-msft
haolingdong-msft reviewed Mar 23, 2023
View reviewed changes
.vscode/cspell.json Show resolved Hide resolved
.vscode/cspell.json Outdated Show resolved Hide resolved
sdk/healthinsights/azure-health-insights-cancerprofiling/src/samples/README.md Show resolved Hide resolved
sdk/healthinsights/azure-health-insights-cancerprofiling/README.md Outdated Show resolved Hide resolved
sdk/healthinsights/azure-health-insights-cancerprofiling/README.md Outdated Show resolved Hide resolved
...ing/src/samples/java/com/azure/health/insights/cancerprofiling/SampleInferCancerProfile.java Show resolved Hide resolved
...iling/src/test/java/com/azure/health/insights/cancerprofiling/CancerProfilingClientTest.java Outdated Show resolved Hide resolved
...g/src/test/java/com/azure/health/insights/cancerprofiling/CancerProfilingClientTestBase.java Show resolved Hide resolved
sdk/healthinsights/azure-health-insights-clinicalmatching/pom.xml Show resolved Hide resolved
sdk/healthinsights/azure-health-insights-clinicalmatching/src/samples/README.md Outdated Show resolved Hide resolved
@haolingdong-msft
Copy link
Member

Hi @asaflevi-ms , could you please also check the comments in the two API views?

@asaflevi-ms
Copy link
Member Author

Hi @asaflevi-ms , could you please also check the comments in the two API views?

Hi @haolingdong-msft ,
Sure, checked.

@weidongxu-microsoft
Copy link
Member

@haolingdong-msft Could you make one final pass (and approve if you are good with it; I will do so as well)?

@haolingdong-msft
Copy link
Member

@haolingdong-msft Could you make one final pass (and approve if you are good with it; I will do so as well)?

Sure, I am checking.

@haolingdong-msft
Copy link
Member

LGTM, except this #33948 (comment), not sure if this is expected.

@asaflevi-ms
Copy link
Member Author

What is LGTM ?

@haolingdong-msft
Copy link
Member

What is LGTM ?

It means Looks good to me.

weidongxu-microsoft
weidongxu-microsoft approved these changes Mar 29, 2023
View reviewed changes
Copy link
Member

@weidongxu-microsoft weidongxu-microsoft left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

If anyone has change request, please comment in PR.

I will merge it on 3/30.

@weidongxu-microsoft weidongxu-microsoft merged commit 660c4c4 into Azure:main Mar 30, 2023
@asaflevi-ms asaflevi-ms mentioned this pull request Mar 30, 2023
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@JonathanGiles JonathanGiles JonathanGiles left review comments

@weidongxu-microsoft weidongxu-microsoft weidongxu-microsoft approved these changes

@haolingdong-msft haolingdong-msft haolingdong-msft approved these changes

@joshfree joshfree Awaiting requested review from joshfree joshfree is a code owner

@srnagar srnagar Awaiting requested review from srnagar srnagar is a code owner

@anuchandy anuchandy Awaiting requested review from anuchandy anuchandy is a code owner

@conniey conniey Awaiting requested review from conniey conniey is a code owner

@lmolkova lmolkova Awaiting requested review from lmolkova lmolkova is a code owner

@alzimmermsft alzimmermsft Awaiting requested review from alzimmermsft alzimmermsft is a code owner

@samvaity samvaity Awaiting requested review from samvaity

@g2vinay g2vinay Awaiting requested review from g2vinay g2vinay is a code owner

@JimSuplizio JimSuplizio Awaiting requested review from JimSuplizio

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
8 participants
@asaflevi-ms @weshaggard @azure-sdk @lirenhe @weidongxu-microsoft @haolingdong-msft @JonathanGiles @srnagar