Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Allow configuration of disableChallengeResourceVerification property of AKV SecretClient #36628

Merged
merged 4 commits into from
Sep 5, 2023
Merged

Allow configuration of disableChallengeResourceVerification property of AKV SecretClient #36628

merged 4 commits into from
Sep 5, 2023

Conversation

Netyyyy
Copy link
Member

@Netyyyy Netyyyy commented Sep 4, 2023 •
edited
Loading

Description

Sync codes from #36603

All SDK Contribution checklist:

  • The pull request does not introduce [breaking changes]
  • CHANGELOG is updated for new features, bug fixes or other significant changes.
  • I have read the contribution guidelines.

General Guidelines and Best Practices

  • Title of the pull request is clear and informative.
  • There are a small number of commits, each of which have an informative message. This means that previously merged commits do not appear in the history of the PR. For more information on cleaning up the commits in your PR, see this page.

Testing Guidelines

  • Pull request includes test coverage for the included changes.

@github-actions github-actions bot added the azure-spring All azure-spring related issues label Sep 4, 2023
@Azure Azure deleted a comment from azure-pipelines bot Sep 4, 2023
@Netyyyy
Copy link
Member Author

Netyyyy commented Sep 4, 2023

/azp run java - spring - tests

@azure-pipelines
Copy link

Azure Pipelines successfully started running 1 pipeline(s).

@azure-sdk
Copy link
Collaborator

API change check

API changes are not detected in this pull request.

@Netyyyy Netyyyy marked this pull request as ready for review September 5, 2023 01:30
@Netyyyy
Copy link
Member Author

Netyyyy commented Sep 5, 2023

@saragluna please help take a look

@saragluna
Copy link
Member

/azp run java - spring - tests

@azure-pipelines
Copy link

Azure Pipelines successfully started running 1 pipeline(s).

@Netyyyy Netyyyy merged commit 1ef034e into Azure:main Sep 5, 2023
49 checks passed
@Netyyyy Netyyyy deleted the myao/sync_challengeResourceVerificationEnabled_kv branch October 13, 2023 08:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@saragluna saragluna saragluna approved these changes

@backwind1233 backwind1233 Awaiting requested review from backwind1233

@chenrujun chenrujun Awaiting requested review from chenrujun

@hui1110 hui1110 Awaiting requested review from hui1110

@stliu stliu Awaiting requested review from stliu

@yiliuTo yiliuTo Awaiting requested review from yiliuTo

@moarychan moarychan Awaiting requested review from moarychan moarychan is a code owner

@fangjian0423 fangjian0423 Awaiting requested review from fangjian0423

Assignees
No one assigned
Labels
azure-spring All azure-spring related issues
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@Netyyyy @azure-sdk @saragluna