Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adding local helm chart and changing install script #45

Merged
merged 1 commit into from
Feb 11, 2022
Merged

Conversation

jainr
Copy link
Member

@jainr jainr commented Jan 28, 2022

Adding helm chart and changing script, so feast can be installed from local helm chart that contains the updates rbac apis thats compatible with latest versions of Kubernetes.

This PR solves the issue where the older rbac v1beta apis are not compatible with latest Kubernetes version.
This fixes that problem but the chart needs to be installed from local feast-0.9.5-helmchart folder.

… local helm chart that contains the updates rbac apis thats compatible with latest versions of Kubernetes
@jainr jainr requested a review from rramani January 28, 2022 20:46
@jainr
Copy link
Member Author

jainr commented Jan 28, 2022

@snowmanmsft

@andrijaperovic
Copy link
Contributor

This is how I was able to also install the helm chart on AKS v1.22.

However, I think (I may be wrong) that the crux of the problem is the fact that feast-azure-provider is not compatible with newest versions of feast which might also be correlated to the fact that feast-spark depends on feast v0.9:
#40

Unless there is a plan to somehow stage this helm chart internally @ Microsoft (e.g. central helm repository), this is probably the only viable short-term fix.

@cbtham
Copy link
Contributor

cbtham commented Feb 7, 2022

This is how I was able to also install the helm chart on AKS v1.22.

However, I think (I may be wrong) that the crux of the problem is the fact that feast-azure-provider is not compatible with newest versions of feast which might also be correlated to the fact that feast-spark depends on feast v0.9: #40

Unless there is a plan to somehow stage this helm chart internally @ Microsoft (e.g. central helm repository), this is probably the only viable short-term fix.

feast-azure-provider will not work with any version other than 0.15.1 at the moment

@adchia
Copy link

adchia commented Feb 7, 2022

There weren't any breaking changes for this provider between 0.15.1 and 0.17/0.18, so should be as simple as doing feast[redis] >= 0.15.1

@jainr jainr merged commit 214c949 into main Feb 11, 2022
@jainr
Copy link
Member Author

jainr commented Feb 11, 2022

We are dependent on feast 0.9 because of spark dependency.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants