Skip to content
This repository has been archived by the owner on Mar 20, 2024. It is now read-only.

Murata IoT Device Models #545

Merged
merged 5 commits into from
Aug 24, 2023
Merged

Murata IoT Device Models #545

merged 5 commits into from
Aug 24, 2023

Conversation

xlinmurata
Copy link
Contributor

Thank you for contributing to the IoT Plug and Play Models repository

📝 Please review this checklist before submission

  • 👀 The models submitted in this PR follow the DTDL Naming Guidelines for contributing to this repository.
  • 🕵️I have validated the models locally using the dmr-client command line tool.
  • ❗ I understand once the PR is approved, the models are considered immutable: any edits will require to submit new files.
  • ✨ When creating a new top level dtmi:namespace, I have completed the PR Info Template below.

⚡ PR validation steps are described in the tools Wiki.

PR Info Template

When submitting models to the repository we ask that you provide as much of the following meta information around your models and related devices as possible. This info will be used to improve the IoT Plug and Play ecosystem.

👇: Please replace the markdown comment examples with your own values.

Company Info

Info identifying your company (if applicable).

IoT Plug and Play Device Info

Info identifying your device.

Model Submission Goals

Info related to broader submission goals.

Code Owners & Reserved Names

Indicates GitHub alias entries to be added to the repo CODEOWNERS for the incoming model namespace. The codeowner is expected to be involved in subsequent DTDL model submissions against the same namespace.

This project has adopted the Microsoft Open Source Code of Conduct. For more information see the Code of Conduct FAQ or contact opencode@microsoft.com with any additional questions or comments.

@xlinmurata xlinmurata requested a review from a team as a code owner August 21, 2023 19:40
@xlinmurata
Copy link
Contributor Author

xlinmurata commented Aug 21, 2023 via email

@xlinmurata
Copy link
Contributor Author

Hi,

I am trying to add the device models for my company("Murata"). It is my first project on github, I don't have any idea on what failed and why, can you please explain?
Thanks,
Xlin

@rido-min
Copy link
Member

@xlinmurata thanks for submitting a new model.

This submission is failing because some files do not have the @context specifier

https://github.com/Azure/iot-plugandplay-models/actions/runs/5930729946/job/16081218156?pr=545#step:3:582

@xlinmurata
Copy link
Contributor Author

I updated files. and now what I need to do next?

@rido-min
Copy link
Member

I updated files. and now what I need to do next?

commit and push to the same branch

Copy link
Member

@rido-min rido-min left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

the validation still fails.

You can validate locally by using dmr-client as described in https://github.com/Azure/iot-plugandplay-models-tools/tree/dev/clients/dotnet/Microsoft.IoT.ModelsRepository.CommandLine

dtmi/murata/demo_iot-1.json Outdated Show resolved Hide resolved
@xlinmurata
Copy link
Contributor Author

I have a change request, I have made/commit/push the change and replied with dmr-client validation result. is there anything I need to do to trigger the PR? sorry for all the questions as I am a newbie.

@rido-min rido-min merged commit 0275df1 into Azure:main Aug 24, 2023
2 checks passed
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants