Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

azure: Upgrade dependencies for armcontainerservice #48

Merged
merged 1 commit into from
Sep 29, 2023
Merged

azure: Upgrade dependencies for armcontainerservice #48

merged 1 commit into from
Sep 29, 2023

Conversation

mqasimsarfraz
Copy link
Member

@mqasimsarfraz mqasimsarfraz commented Sep 28, 2023 •
edited
Loading

We were using containerservice/armcontainerservice v0.3.0 which uses api-version (2021-11-01-preview) for managedClusters and it seems to be removed and we get following error with config import:

RESPONSE 400: 400 Bad Request
ERROR CODE: NoRegisteredProviderFound
--------------------------------------------------------------------------------
{
  "error": {
    "code": "NoRegisteredProviderFound",
    "message": "No registered resource provider found for location 'eastus' and API version '2021-11-01-preview' for type 'managedClusters'. The supported api-versions are '2017-08-31, 2018-03-31, 2019-02-01, 2019-04-01, 2019-06-01, 2019-08-01, 2019-10-01, 2019-11-01, 2020-01-01, 2020-02-01, 2020-03-01, 2020-04-01, 2020-06-01, 2020-07-01, 2020-09-01, 2020-11-01, 2020-12-01, 2021-02-01, 2021-03-01, 2021-05-01, 2021-07-01, 2021-08-01, 2021-09-01, 2021-10-01, 2022-01-01, 2022-01-02-preview, 2022-02-01, 2022-03-01, 2022-03-02-preview, 2022-04-01, 2022-04-02-preview, 2022-05-02-preview, 2022-06-01, 2022-06-02-preview, 2022-07-01, 2022-07-02-preview, 2022-08-01, 2022-08-02-preview, 2022-08-03-preview, 2022-09-01, 2022-09-02-preview, 2022-10-02-preview, 2022-11-01, 2022-11-02-preview, 2023-01-01, 2023-01-02-preview, 2023-02-01, 2023-02-02-preview, 2023-03-01, 2023-03-02-preview, 2023-04-01, 2023-04-02-preview, 2023-05-01, 2023-05-02-preview, 2023-06-01, 2023-06-02-preview, 2023-07-01, 2023-07-02-preview, 2023-08-01, 2023-08-02-preview'. The supported locations are 'australiacentral, australiacentral2, australiaeast, australiasoutheast, brazilsouth, brazilsoutheast, canadacentral, canadaeast, centralindia, centralus, eastasia, eastus, eastus2, francecentral, francesouth, germanynorth, germanywestcentral, israelcentral, italynorth, japaneast, japanwest, jioindiacentral, jioindiawest, koreacentral, koreasouth, northcentralus, northeurope, norwayeast, norwaywest, polandcentral, qatarcentral, southafricanorth, southafricawest, southcentralus, southindia, southeastasia, swedencentral, switzerlandnorth, switzerlandwest, uaecentral, uaenorth, uksouth, ukwest, westcentralus, westeurope, westus, westus2, westus3'."
  }
}

This change upgrade armcontainerservice alongside all the dependencies and uses stable api-version (2022-04-01) to avoid future regression.

Note: All the changes in this PR and because underlying API changes in azure go sdk.

Testing done

Integration test are passing again

@mqasimsarfraz mqasimsarfraz temporarily deployed to aks September 28, 2023 14:03 — with GitHub Actions Inactive
@mqasimsarfraz mqasimsarfraz temporarily deployed to aks September 28, 2023 14:12 — with GitHub Actions Inactive
@mqasimsarfraz
azure: Upgrade dependencies for armcontainerservice
406be10 
We were using containerservice/armcontainerservice v0.3.0 which
uses api-version (2021-11-01-preview) and it seem to have been removed.
This change upgrade it and alongside all the dependencies to ensure
we move to a stabe api-version (2022-04-01) to avoid future regression.
@mqasimsarfraz mqasimsarfraz changed the title ci: Set subscription id explicitly azure: Upgrade dependencies for armcontainerservice Sep 29, 2023
@mqasimsarfraz mqasimsarfraz temporarily deployed to aks September 29, 2023 07:55 — with GitHub Actions Inactive
@mqasimsarfraz mqasimsarfraz temporarily deployed to aks September 29, 2023 08:00 — with GitHub Actions Inactive
@mqasimsarfraz mqasimsarfraz temporarily deployed to aks September 29, 2023 08:00 — with GitHub Actions Inactive
@mqasimsarfraz mqasimsarfraz temporarily deployed to aks September 29, 2023 08:00 — with GitHub Actions Inactive
@mqasimsarfraz mqasimsarfraz added the bug Something isn't working label Sep 29, 2023
@mqasimsarfraz mqasimsarfraz temporarily deployed to aks September 29, 2023 08:13 — with GitHub Actions Inactive
burak-ok
burak-ok approved these changes Sep 29, 2023
View reviewed changes
Copy link
Collaborator

@burak-ok burak-ok left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM and works for me. Thanks for fixing this so fast

@mqasimsarfraz mqasimsarfraz merged commit f8ef83e into main Sep 29, 2023
14 checks passed
@mqasimsarfraz mqasimsarfraz deleted the qasim/ci-subscription-id branch September 29, 2023 17:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@burak-ok burak-ok burak-ok approved these changes

@blanquicet blanquicet Awaiting requested review from blanquicet

Assignees
No one assigned
Labels
bug Something isn't working
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@mqasimsarfraz @burak-ok