Use vercel/ncc #367
Closed
Use vercel/ncc #367
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kWozniak-tt
had a problem deploying
to
Automation test
GitHub Actions
Failure
kWozniak-tt
force-pushed
the
use-vercel
branch
from
e210f88
to
53b0462
Compare
kWozniak-tt
had a problem deploying
to
Automation test
GitHub Actions
Failure
winiarskipsn
approved these changes
Nov 13, 2023
|
@microsoft-github-policy-service agree |
|
@BALAGA-GAYATRI can you take a look? |
|
@kWozniak-tt Just FYI, we're busing on the next release now but we'll get back to your PR soon. Thanks for your contribution. |
kWozniak-tt
force-pushed
the
use-vercel
branch
from
53b0462
to
5b7aaec
Compare
kWozniak-tt
had a problem deploying
to
Automation test
GitHub Actions
Failure
|
@microsoft-github-policy-service agree |
|
Thanks @kWozniak-tt for your valuable contribution on this topic! But there are still some modifications needed for using ncc. Let's track this in #428. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix for #103 #366
Use github suggested solution to slim-down package and improve Download and Unwrap performace on self-hosted runners
Reference:
https://docs.github.com/en/actions/creating-actions/creating-a-javascript-action#commit-tag-and-push-your-action-to-github
https://github.com/actions/typescript-action
Before:
After: