Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Change LangVersion to be 11 #2184

Merged
merged 1 commit into from
Jul 27, 2023
Merged

Change LangVersion to be 11 #2184

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion build/common.props
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -32,7 +32,7 @@
<TargetFrameworks Condition=" '$(OS)' == 'Windows_NT' ">$(SrcTargets)</TargetFrameworks>
<TargetFrameworks Condition=" '$(OS)' != 'Windows_NT' ">$(SrcStandardTargets)</TargetFrameworks>
<NetStandardImplicitPackageVersion>$(NetStandardVersion)</NetStandardImplicitPackageVersion>
<LangVersion>7.3</LangVersion>
<LangVersion>11</LangVersion>
</PropertyGroup>

<PropertyGroup Condition="'$(TF_BUILD)' == 'true'">
Expand Down
1 change: 0 additions & 1 deletion ...rosoft.IdentityModel.KeyVaultExtensions/Microsoft.IdentityModel.KeyVaultExtensions.csproj
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -6,7 +6,6 @@
<AssemblyName>Microsoft.IdentityModel.KeyVaultExtensions</AssemblyName>
<Description>Includes types that provide support for signing and encrypting tokens with Azure Key Vault.</Description>
<GenerateDocumentationFile>true</GenerateDocumentationFile>
<LangVersion>latest</LangVersion>
<PackageId>Microsoft.IdentityModel.KeyVaultExtensions</PackageId>
<TargetFrameworks Condition="'$(TargetNet8)' == 'True'">netstandard2.0;net6.0;net8.0</TargetFrameworks>
<TargetFrameworks Condition="'$(TargetNet8)' != 'True'">netstandard2.0;net6.0</TargetFrameworks>
Expand Down
3 changes: 1 addition & 2 deletions ...odel.ManagedKeyVaultSecurityKey/Microsoft.IdentityModel.ManagedKeyVaultSecurityKey.csproj
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -7,7 +7,6 @@
<Description>Includes types that provide support for signing and encrypting tokens with Azure Key Vault for
Applications that are using Managed identities for Azure resources.</Description>
<GenerateDocumentationFile>true</GenerateDocumentationFile>
<LangVersion>latest</LangVersion>
<PackageId>Microsoft.IdentityModel.ManagedKeyVaultSecurityKey</PackageId>
<TargetFrameworks>netstandard2.0</TargetFrameworks>
<PackageTags>.NET;Windows;Authentication;Identity;Azure;Key;Vault;Extensions</PackageTags>
Expand All @@ -31,4 +30,4 @@
<ProjectReference Include="..\Microsoft.IdentityModel.KeyVaultExtensions\Microsoft.IdentityModel.KeyVaultExtensions.csproj" />
</ItemGroup>

</Project>
</Project>
8 changes: 4 additions & 4 deletions src/Microsoft.IdentityModel.Protocols.SignedHttpRequest/SignedHttpRequestHandler.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -300,7 +300,7 @@ internal virtual void AddQClaim(Dictionary<string, object> payload, SignedHttpRe
if (!firstQueryParam)
stringBuffer.Append("&");

stringBuffer.Append($"{queryParam.Key}={queryParam.Value}");
stringBuffer.Append(queryParam.Key).Append('=').Append(queryParam.Value);

queryParamNameList.Add(queryParam.Key);
firstQueryParam = false;
Expand Down Expand Up @@ -342,7 +342,7 @@ internal virtual void AddHClaim(Dictionary<string, object> payload, SignedHttpRe
if (!firstHeader)
stringBuffer.Append(_newlineSeparator);

stringBuffer.Append($"{headerName}: {header.Value}");
stringBuffer.Append(headerName).Append(": ").Append(header.Value);
firstHeader = false;
}

Expand Down Expand Up @@ -847,7 +847,7 @@ internal virtual void ValidateQClaim(JsonWebToken signedHttpRequest, SignedHttpR
if (!firstQueryParam)
stringBuffer.Append("&");

stringBuffer.Append($"{queryParamName}={queryParamsValue}");
stringBuffer.Append(queryParamName).Append('=').Append(queryParamsValue);
firstQueryParam = false;

// remove the query param from the dictionary to mark it as covered.
Expand Down Expand Up @@ -915,7 +915,7 @@ internal virtual void ValidateHClaim(JsonWebToken signedHttpRequest, SignedHttpR
if (!firstHeader)
stringBuffer.Append(_newlineSeparator);

stringBuffer.Append($"{headerName}: {headerValue}");
stringBuffer.Append(headerName).Append(": ").Append(headerValue);
firstHeader = false;

// remove the header from the dictionary to mark it as covered.
Expand Down
1 change: 0 additions & 1 deletion src/Microsoft.IdentityModel.Tokens/Microsoft.IdentityModel.Tokens.csproj
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -8,7 +8,6 @@
<GenerateDocumentationFile>true</GenerateDocumentationFile>
<PackageId>Microsoft.IdentityModel.Tokens</PackageId>
<PackageTags>.NET;Windows;Authentication;Identity;SecurityTokens;Cryptographic operations;Signing;Verifying Signatures;Encryption</PackageTags>
<LangVersion>latest</LangVersion>
<AllowUnsafeBlocks>true</AllowUnsafeBlocks>
</PropertyGroup>

Expand Down
1 change: 0 additions & 1 deletion ...ityModel.KeyVaultExtensions.Tests/Microsoft.IdentityModel.KeyVaultExtensions.Tests.csproj
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -8,7 +8,6 @@
<DelaySign>true</DelaySign>
<Description>Tests for Microsoft.IdentityModel.KeyVaultExtensions</Description>
<GenerateRuntimeConfigurationFiles>true</GenerateRuntimeConfigurationFiles>
<LangVersion>latest</LangVersion>
<PackageId>Microsoft.IdentityModel.KeyVaultExtensions.Tests</PackageId>
<SignAssembly>true</SignAssembly>
</PropertyGroup>
Expand Down
3 changes: 1 addition & 2 deletions ...KeyVaultSecurityKey.Tests/Microsoft.IdentityModel.ManagedKeyVaultSecurityKey.Tests.csproj
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,4 +1,4 @@
<Project Sdk="Microsoft.NET.Sdk">
<Project Sdk="Microsoft.NET.Sdk">

<Import Project="..\..\build\commonTest.props" />

Expand All @@ -8,7 +8,6 @@
<DelaySign>true</DelaySign>
<Description>Tests for Microsoft.IdentityModel.ManagedKeyVaultSecurityKey</Description>
<GenerateRuntimeConfigurationFiles>true</GenerateRuntimeConfigurationFiles>
<LangVersion>latest</LangVersion>
<PackageId>Microsoft.IdentityModel.ManagedKeyVaultSecurityKey.Tests</PackageId>
<SignAssembly>true</SignAssembly>
</PropertyGroup>
Expand Down
Loading