Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Split tests into parameter testing and value testing #2827

Merged
merged 1 commit into from
Sep 18, 2024

Conversation

brentschmaltz
Copy link
Member

Some changes to set a pattern for coding style.

Separate TheoryData sets for parameter testing vs. functional testing.
Instead of setting TheoryData.TestId, pass the testId to base.
Then pass theoryData.CallContext inside the test method, rather than passing 'new CallContext()' this gives you two things.

  1. stepping into the method avoids stepping through the ctor of CallContext.
  2. More importantly, by passing the testId to base, theoryData.CallContext.DebugId is set to testId, which allows for setting a conditional breakpoint deep into the call graph. When a test case has many variations, this is very helpful.

Change setting TestId to passing testid to base, then use theoryData.CallContext
@brentschmaltz brentschmaltz requested a review from a team as a code owner September 16, 2024 04:03
@brentschmaltz brentschmaltz merged commit 9f61d7b into dev Sep 18, 2024
6 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants