Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix thread safety issues in TokenAcquisition classes #1082

Merged
merged 5 commits into from
Mar 26, 2021
Merged

Fix thread safety issues in TokenAcquisition classes #1082

merged 5 commits into from
Mar 26, 2021

Conversation

DavidParks8
Copy link
Contributor

There were some cases where highly multithreaded environments could cause issues due to non thread-safe code. This PR attempts to resolve the thread safety issues with an eye on maintaining performant execution.

@henrik-me
Copy link
Contributor

Would like to see us test this out. I would like though to split out the change done for creating new CC objects from the change on locking.

@jmprieur jmprieur added this to the 1.9.0 milestone Mar 25, 2021
@henrik-me
Copy link
Contributor

Can we make this change only about httpcontext and take the application objection creation in the other PR or is that other one replacing this? #1084

In reply to: 805976220 [](ancestors = 805976220)

@jennyf19 jennyf19 changed the base branch from master to locking March 26, 2021 00:39
@jennyf19
Copy link
Collaborator

going to merge to another branch and we will fix up anything as we test if needed. thank you so much @DavidParks8

@jennyf19 jennyf19 merged commit 2fc3d8e into AzureAD:locking Mar 26, 2021
@jennyf19 jennyf19 mentioned this pull request Mar 29, 2021
Merged
jennyf19 added a commit that referenced this pull request Mar 29, 2021
@jennyf19 @DavidParks8
Locking (#1099)
8137188 
* Fix thread safety issues in TokenAcquisition classes (#1082)

* Fix thread safety issues in TokenAcquisition classes

* fix tests

* Add confidential client app locking back

* fix warnings

* add more locks on httpContext

* one more

Co-authored-by: David Parks <DavidParks8@outlook.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Tratcher Tratcher Tratcher left review comments

@bgavrilMS bgavrilMS bgavrilMS left review comments

@jmprieur jmprieur jmprieur left review comments

@jennyf19 jennyf19 jennyf19 left review comments

@henrik-me henrik-me henrik-me left review comments

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
1.9.0
Development

Successfully merging this pull request may close these issues.
6 participants
@DavidParks8 @henrik-me @jennyf19 @Tratcher @bgavrilMS @jmprieur