Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Rebalance melee #156

Merged
merged 8 commits into from
Dec 24, 2020
Merged

Rebalance melee #156

merged 8 commits into from
Dec 24, 2020

Conversation

TomyLobo
Copy link
Collaborator

@TomyLobo TomyLobo commented Mar 18, 2020

  1. Bring stock attack damage down to the current level of regular melee attacks
    • Now you can only do 1-hit kills on freshly spawned people if you have the melee buff and Persuader/Vindicator/Black Magic.
  2. Make all melee semi-automatic burst in order to fix an exploit
  3. Scale melee style charge usage based on damage
  4. Reduce akimbo melee damage to single gun damage

@TomyLobo
Copy link
Collaborator Author

Slight problem: this makes the issue worse: now you can slide-punch someone with a vindicator and they'll just die, from 100 health, and without any melee boost.
So do NOT merge this yet

Comment on lines 452 to 454
if (pOwner->GetPunchesThrown() > 0)
return;

Copy link
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

If you want to make punches semi auto, I don't think you have to track punches thrown, I think you can just check whether the key was pressed as opposed to down.

Copy link
Collaborator Author

@TomyLobo TomyLobo Mar 22, 2020

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

That information is available several function calls further up, in each weapon's ItemPostFrame, but not here, where all melee converges :)

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

btw, like i said, this probably needs some further touches, please don't merge yet

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Still not sure whether to make melee semi-auto or keep it full-auto.
I've seen people abuse it by just typing +attack2 in the console and then leaving it on to get that extra damage in case they're near someone, but otherwise just using guns.
But then there are lag issues that basically require you to spam to hit.

What's your opinion?
Since I already have a count, maybe allow bursts of 3 (ish) punches?

Copy link
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

My opinion is disable shooting for a time after you melee if you want to fix the +attack2 problem.

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think that'd be too much of a melee nerf and in the long run it'd mostly affect less experienced players anyway, since the pros would get used to the new way quickly.
Also, that'd be one more thing that can have bugs, whereas that melee burst system was just a copypasta of the existing burst system.

@TomyLobo
Copy link
Collaborator Author

TomyLobo commented Dec 24, 2020

Slight problem: this makes the issue worse: now you can slide-punch someone with a vindicator and they'll just die, from 100 health, and without any melee boost.
So do NOT merge this yet

This problem seems to be solved by reducing the scaling.
Now you can only do 1-hit kills on freshly spawned people if you have the melee buff and Persuader/Vindicator/Black Magic.

@TomyLobo TomyLobo merged commit ebc32e4 into develop Dec 24, 2020
@TomyLobo TomyLobo deleted the melee-balance branch December 24, 2020 09:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants