Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Weapon sounds now work on dedicated servers #162

Merged
merged 4 commits into from
Feb 15, 2021

Conversation

voxelizedworld
Copy link
Contributor

Co-authored-by: Joshua Ashton joshua@froggi.es

Co-authored-by: Joshua Ashton <joshua@froggi.es>
@TomyLobo
Copy link
Collaborator

We tested this and got double sounds.
When we tested the release version, we still had the regular sounds.
I think there's some randomness involved, or maybe some buildup.

@TomyLobo
Copy link
Collaborator

Well it took 3 people to fix it :)

Co-authored-by: Valkyrie <valkyrie@aliencow.org>
Copy link
Collaborator

@TomyLobo TomyLobo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Last commit developed in pair programming with @voxelizedworld, rest looks ok to me and we successfully tested it.

@TomyLobo TomyLobo merged commit 89d9e6e into BSVino:develop Feb 15, 2021
Copy link
Owner

@BSVino BSVino left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can't tell what went wrong from a naive reading of the code, but it looks like you folks tested pretty thoroughly and it plausibly works, so approved.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants