Add name labels to players in spectator mode #64
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
TomyLobo
force-pushed
the
spectator-names
branch
3 times, most recently
from
08e34dd
to
d5cf68c
Compare
|
|
||
| if (!pPlayer->IsVisible()) | ||
| continue; | ||
|
|
There was a problem hiding this comment.
good point, gotta check if you can see spectators with this :D
Otherwise, it's probably covered by the visibility check
There was a problem hiding this comment.
It seems to be covered by the visibility check.
TomyLobo
force-pushed
the
spectator-names
branch
5 times, most recently
from
8e128f9
to
707c00a
Compare
TomyLobo
force-pushed
the
spectator-names
branch
from
707c00a
to
1b329f2
Compare
TomyLobo
force-pushed
the
spectator-names
branch
from
1b329f2
to
645b8ef
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Should be useful when trying to spot excessive teaming.