Use Plugin instead of JavaPlugin in Bukkit Metrics constructor #121
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Thank you and sorry for the late merge! |
|
No worries :) better late than never! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Pluginis an abstract base type for all plugin types supported by the Bukkit plugin loading API. Specifically requiringJavaPluginforces 3rd party plugin loaders such as PyPlugins to use older versions of bStats because they cannot pass instances ofPythonPlugin.JavaPluginisn't strictly required for theMetricsclass and even has aPluginfield so this change is rather harmless but allows plugin loaders to still use bStats.