[CBRD-25248] Server crash for Java SPs running a SELECT statement wit…

…h 'WHERE 0 <> 0' clause (#5017) (#5037)

http://jira.cubrid.org/browse/CBRD-25248

For false query such as 'SELECT * FROM db_class WHERE 0 <> 0', dummy query id is set. I've changed to set the query_id as NULL_QUERY_ID if a query is not executed (tuple_count <= 0).

backport of #5017

src/method/method_invoke_group.cpp

@@ -343,6 +343,12 @@ namespace cubmethod
   query_cursor *
   method_invoke_group::create_cursor (QUERY_ID query_id, bool oid_included)
   {
+    if (query_id == NULL_QUERY_ID || query_id >= SHRT_MAX)
+      {
+	// false query e.g) SELECT * FROM db_class WHERE 0 <> 0
+	return nullptr;
+      }
+
     m_cursor_set.insert (query_id);
     return m_rctx->create_cursor (m_thread_p, query_id, oid_included);
   }

src/method/method_invoke_java.cpp

@@ -451,9 +451,7 @@ namespace cubmethod
 	    {
 	      std::uint64_t qid = current_result_info.query_id;
 	      bool is_oid_included = current_result_info.include_oid;
-	      query_cursor *cursor = m_group->create_cursor (qid, is_oid_included);
-
-	      assert (cursor != nullptr);
+	      (void) m_group->create_cursor (qid, is_oid_included);
 	    }
 	}
 
@@ -496,7 +494,6 @@ namespace cubmethod
       }
 
     fetch_info info;
-
     int i = 0;
     SCAN_CODE s_code = S_SUCCESS;
     while (s_code == S_SUCCESS)

src/method/method_query_handler.cpp

@@ -523,7 +523,14 @@ namespace cubmethod
 
     if (qres && qres->type == T_SELECT)
       {
-	result_info.query_id = qres->res.s.query_id;
+	if (qresult.tuple_count > 0)
+	  {
+	    result_info.query_id = qres->res.s.query_id;
+	  }
+	else
+	  {
+	    result_info.query_id = NULL_QUERY_ID; // initialized value
+	  }
       }
     return error;
   }

src/method/method_runtime_context.cpp

@@ -259,8 +259,7 @@ namespace cubmethod
   {
     if (query_id == NULL_QUERY_ID || query_id >= SHRT_MAX)
       {
-	// something wrong!
-	assert (false);
+	// false query e.g) SELECT * FROM db_class WHERE 0 <> 0
 	return nullptr;
       }