[CBRD-23633] protocol: Prevent endless busy waiting for query execution in abnormal network circumstance #2252
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…on in abnormal network circumstance
Codecov Report
@@ Coverage Diff @@
## develop #2252 +/- ##
===========================================
- Coverage 49.19% 47.31% -1.88%
===========================================
Files 491 491
Lines 384879 384892 +13
===========================================
- Hits 189340 182112 -7228
- Misses 195539 202780 +7241
Continue to review full report at Codecov.
|
shparkcubrid
approved these changes
Apr 20, 2020
hgryoo
reviewed
Apr 20, 2020
Comment on lines
+2065
to
+2071
| public static boolean protoVersionIsLower(int ver) { | ||
| if (protocolVersion < ver){ | ||
| return true; | ||
| } | ||
| return false; | ||
| } | ||
|
|
There was a problem hiding this comment.
there is protoVersionIsUnder(). why we need it?
There was a problem hiding this comment.
We need a new method like as protoVersionIsUnder in order to avoid side effect.
The readability could be considered by code refactoring in the future.
hgryoo
approved these changes
Apr 20, 2020
beyondykk9
added a commit
that referenced
this pull request
Apr 21, 2020
…rmal network circumstance (#2219, #2259) (#2259) * [CBRD-23633] Prevent endless busy waiting for query execution in abnormal network circumstance (#2219) * [CBRD-23633] Prevent endless busy waiting for query execution in abnormal network circumstance * [CBRD-23633] Prevent endless busy waiting for query execution in abnormal network circumstance * [CBRD-23633] fix indentation * [CBRD-23633] revised code to be simple and shorten * [CBRD-23633] revised to throw JciException instead of IOException * [CBRD-23633] the omitted code added to check the function status of cas * [CBRD-23633] removed unnecessary exception code * [CBRD-23633] revised sedn_recv_msg without argument * [CBRD-23633] added code to retry once for invalid status of the cas * [CBRD-23633] revised: UInputBuffer constructor modified for compatibility (#2243) * [CBRD-23633] protocol: Prevent endless busy waiting for query execution in abnormal network circumstance (#2252)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
http://jira.cubrid.org/browse/CBRD-23633
It's needed to upgrade cas protocol V8 to V9 for backward compatibility.