Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[CBRD-23658] counting Error occurred when argument of COUNT function is constant 'NULL'. #2296

Merged
merged 1 commit into from
May 6, 2020

Conversation

shparkcubrid
Copy link
Contributor

@shparkcubrid shparkcubrid commented May 6, 2020

http://jira.cubrid.org/browse/CBRD-23658

This issue is a regression of CBRD-21694
In CBRD-21694, logic to change count_star when argument of count function is constant has been added.

When the argument of the count function is null, I modify it so that it does not change to count_star.
And I eliminates unnecessary duplicate logic in the type check.

@shparkcubrid shparkcubrid self-assigned this May 6, 2020
@shparkcubrid shparkcubrid added this to the damson milestone May 6, 2020
@codecov-io
Copy link

codecov-io commented May 6, 2020

Codecov Report

Merging #2296 into develop will increase coverage by 2.27%.
The diff coverage is 100.00%.

Impacted file tree graph

@@             Coverage Diff             @@
##           develop    #2296      +/-   ##
===========================================
+ Coverage    46.52%   48.79%   +2.27%     
===========================================
  Files          491      491              
  Lines       384908   384890      -18     
===========================================
+ Hits        179068   187797    +8729     
+ Misses      205840   197093    -8747     
Impacted Files Coverage Δ
src/parser/type_checking.c 57.53% <100.00%> (+6.30%) ⬆️
src/storage/extendible_hash.c 22.08% <0.00%> (-11.72%) ⬇️
src/query/regu_var.cpp 13.84% <0.00%> (-10.77%) ⬇️
src/base/perf_monitor.h 43.02% <0.00%> (-6.98%) ⬇️
src/thread/thread_daemon.hpp 93.33% <0.00%> (-6.67%) ⬇️
src/query/query_dump.c 50.36% <0.00%> (-4.61%) ⬇️
src/thread/critical_section.c 43.35% <0.00%> (-3.59%) ⬇️
src/base/chartype.c 92.85% <0.00%> (-3.58%) ⬇️
src/query/partition.c 73.46% <0.00%> (-3.41%) ⬇️
src/storage/btree_load.c 72.66% <0.00%> (-2.29%) ⬇️
... and 130 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update b314991...6e6adc9. Read the comment docs.

@shparkcubrid
Copy link
Contributor Author

I accidentally merged incorrectly.
If there are no problems with the review, I will remove the revert PR.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants