Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[CBRD-23629] Fix regression of Java SP server utility #2508

Merged
merged 2 commits into from
Dec 1, 2020
Merged

[CBRD-23629] Fix regression of Java SP server utility #2508

merged 2 commits into from
Dec 1, 2020

Conversation

hgryoo
Copy link
Member

@hgryoo hgryoo commented Nov 30, 2020 •
edited
Loading

http://jira.cubrid.org/browse/CBRD-23629

  • unexpected result: 'usage' is not displayed for cubrid javasp status without <db_name>. STATUS was not correctly checked in process_javasp().
  • there is a bug that cubrid javasp stop is always printed as 'fail'. but actually it is successfully stopped on windows. it is because of the wrong testing of is_javasp_running () in process_javasp_stop().
  • slip, there may be no return case in is_javasp_running ()
  • Make javasp utility run last so that it does not occupy another CUBRID process's port first when the javasp utility is run from the service utility.

@hgryoo hgryoo added the bug label Nov 30, 2020
@hgryoo hgryoo added this to the damson milestone Nov 30, 2020
@hgryoo hgryoo self-assigned this Nov 30, 2020
@hgryoo hgryoo merged commit f40c3c9 into CUBRID:develop Dec 1, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@beyondykk9 beyondykk9 beyondykk9 approved these changes

@shparkcubrid shparkcubrid shparkcubrid approved these changes

Assignees

@hgryoo hgryoo

Labels
bug
Projects
None yet
Milestone
damson
Development

Successfully merging this pull request may close these issues.
3 participants
@hgryoo @beyondykk9 @shparkcubrid