Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[CBRD-24285] Problem of sort limit optimization without checking not null of foreign key #3509

Merged
merged 7 commits into from
Jun 28, 2022

Conversation

shparkcubrid
Copy link
Contributor

@shparkcubrid shparkcubrid commented Apr 14, 2022

http://jira.cubrid.org/browse/CBRD-24285

check not null of fk when sort limit optimization

@shparkcubrid shparkcubrid self-assigned this Apr 14, 2022
@codecov-commenter
Copy link

codecov-commenter commented Apr 20, 2022

Codecov Report

Merging #3509 (ca65339) into develop (e66683a) will decrease coverage by 15.84%.
The diff coverage is 90.47%.

❗ Current head ca65339 differs from pull request most recent head 2a903e3. Consider uploading reports for the commit 2a903e3 to get more accurate results

@@             Coverage Diff              @@
##           develop    #3509       +/-   ##
============================================
- Coverage    52.23%   36.39%   -15.85%     
============================================
  Files          515      516        +1     
  Lines       396197   399417     +3220     
============================================
- Hits        206970   145354    -61616     
- Misses      189227   254063    +64836     
Impacted Files Coverage Δ
src/optimizer/query_graph.c 67.01% <90.47%> (-16.28%) ⬇️
src/xasl/xasl_analytic.cpp 0.00% <0.00%> (-100.00%) ⬇️
src/object/object_printer.hpp 0.00% <0.00%> (-100.00%) ⬇️
src/base/memory_reference_store.hpp 0.00% <0.00%> (-94.60%) ⬇️
src/base/memory_private_allocator.hpp 0.00% <0.00%> (-86.67%) ⬇️
src/query/scan_json_table.cpp 0.00% <0.00%> (-83.11%) ⬇️
src/xasl/access_spec.hpp 18.18% <0.00%> (-81.82%) ⬇️
src/object/lob_locator.cpp 0.00% <0.00%> (-79.17%) ⬇️
src/compat/db_json_path.cpp 0.00% <0.00%> (-78.07%) ⬇️
src/compat/db_json.cpp 0.00% <0.00%> (-74.82%) ⬇️
... and 246 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update e66683a...2a903e3. Read the comment docs.

src/optimizer/query_graph.c Show resolved Hide resolved
src/optimizer/query_graph.c Show resolved Hide resolved
@shparkcubrid shparkcubrid merged commit 04f3b80 into CUBRID:develop Jun 28, 2022
@shparkcubrid shparkcubrid deleted the CBRD-24285 branch June 28, 2022 04:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

7 participants