Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[CBRD-24400] The problem of comparing plan fixed and variable cost respectively #3665

Merged
merged 4 commits into from
Jun 28, 2022

Conversation

shparkcubrid
Copy link
Contributor

http://jira.cubrid.org/browse/CBRD-24400

if (af <= bf && aa <= ba)
    return PLAN_COMP_LT
if (bf <= af && ba <= aa)
    return PLAN_COMP_GT;
return PLAN_COMP_UNK;

An unknown case occurs because of the comparison as above. I modify it to compare with the sum of each.

@shparkcubrid shparkcubrid self-assigned this Jun 16, 2022
@codecov-commenter
Copy link

codecov-commenter commented Jun 17, 2022

Codecov Report

Merging #3665 (99f1d00) into develop (9bc2c88) will decrease coverage by 1.19%.
The diff coverage is 100.00%.

@@             Coverage Diff             @@
##           develop    #3665      +/-   ##
===========================================
- Coverage    52.07%   50.88%   -1.20%     
===========================================
  Files          515      515              
  Lines       397906   397898       -8     
===========================================
- Hits        207201   202455    -4746     
- Misses      190705   195443    +4738     
Impacted Files Coverage Δ
src/optimizer/query_planner.c 79.94% <100.00%> (-1.33%) ⬇️
src/method/method_oid_handler.hpp 0.00% <0.00%> (-100.00%) ⬇️
src/method/method_struct_query.hpp 0.00% <0.00%> (-100.00%) ⬇️
src/method/method_struct_oid_info.hpp 0.00% <0.00%> (-100.00%) ⬇️
src/method/method_connection_cl.cpp 0.00% <0.00%> (-83.34%) ⬇️
src/method/method_struct_query.cpp 0.00% <0.00%> (-70.83%) ⬇️
src/method/method_query_handler.cpp 0.00% <0.00%> (-55.40%) ⬇️
src/parser/method_transform.c 14.33% <0.00%> (-51.27%) ⬇️
src/method/method_query_cursor.cpp 0.00% <0.00%> (-50.57%) ⬇️
src/method/method_connection_cl.hpp 0.00% <0.00%> (-50.00%) ⬇️
... and 104 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 9bc2c88...99f1d00. Read the comment docs.

@shparkcubrid shparkcubrid merged commit 7a5fdb8 into CUBRID:develop Jun 28, 2022
@shparkcubrid shparkcubrid deleted the CBRD-24400 branch June 28, 2022 07:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

7 participants